From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#46003: prolog-mode: inferior prolog process not available when prolog-inferior-mode-hook is run Date: Tue, 07 Jun 2022 16:37:56 +0200 Message-ID: <87pmjkfsjf.fsf_-_@gnus.org> References: <4049adea-058e-f97a-ad4a-3727d2a1db98@gmail.com> <20210127061134.wzaxfjsqinhkk2oe@sildranDT.localdomain> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40899"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: progscriptclone@gmail.com, 46003@debbugs.gnu.org To: k3tu0isui@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jun 07 16:39:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyaMQ-000AJS-QY for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 16:39:10 +0200 Original-Received: from localhost ([::1]:45658 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nyaMP-0004G5-J6 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 07 Jun 2022 10:39:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55622) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nyaMI-0004Fq-IX for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:47213) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nyaMI-0005KW-Ad for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:39:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nyaMI-0007oo-7q for bug-gnu-emacs@gnu.org; Tue, 07 Jun 2022 10:39:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 07 Jun 2022 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 46003 X-GNU-PR-Package: emacs Original-Received: via spool by 46003-submit@debbugs.gnu.org id=B46003.165461268929993 (code B ref 46003); Tue, 07 Jun 2022 14:39:02 +0000 Original-Received: (at 46003) by debbugs.gnu.org; 7 Jun 2022 14:38:09 +0000 Original-Received: from localhost ([127.0.0.1]:41110 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyaLQ-0007ng-NI for submit@debbugs.gnu.org; Tue, 07 Jun 2022 10:38:08 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:54370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyaLO-0007nC-MP for 46003@debbugs.gnu.org; Tue, 07 Jun 2022 10:38:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EfRniCt/BMuKo5syBHug+L8gBJc4ibWPx9WXn6PscoQ=; b=XOT9nyE2zPu8+KIoHawuvRiBM4 K8KxGf+O0xUbP7SGqlTvimpMUROt/oteo7onyBOyyC0yTZxxbEi8kABT1c1pKQL1tZ9GQnnhWeTDF i1p+5JH9XSy6fmRNTzsU5qAypqMxxa7lqfHIoke4kXiCGNRsc0rHaPzlg1qFkC1b3aGM=; Original-Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyaLF-0003rV-SZ; Tue, 07 Jun 2022 16:38:00 +0200 X-Now-Playing: The Wake's _Harmony & Singles_: "Host" In-Reply-To: <20210127061134.wzaxfjsqinhkk2oe@sildranDT.localdomain> (k3tu0isui@gmail.com's message of "Wed, 27 Jan 2021 11:41:34 +0530") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233899 Archived-At: k3tu0isui@gmail.com writes: > I assume this was required because (prolog-inferior-mode) sets up the > variables required for (prolog-program-name) and (prolog-program-switches). Those are computed before we enter prolog-inferior-mode, though... Oh, because you've fixed that in an earlier applied patch. > If the relevant variables are inherited from the buffer from which > run-prolog is called then, this bug fix[1] will remove this dependency > and prolog-inferior-mode can be activated after the process is > created. > > [1]: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=45795 OK, then I'm applying this patch to Emacs 29, which should fix this bug report: diff --git a/lisp/progmodes/prolog.el b/lisp/progmodes/prolog.el index 8382c4bd09..9598209f5e 100644 --- a/lisp/progmodes/prolog.el +++ b/lisp/progmodes/prolog.el @@ -1355,8 +1355,6 @@ prolog-ensure-process (error "This Prolog system has defined no interpreter")) (unless (comint-check-proc "*prolog*") (with-current-buffer (get-buffer-create "*prolog*") - (prolog-inferior-mode) - ;; The "INFERIOR=yes" hack is for SWI-Prolog 7.2.3 and earlier, ;; which assumes it is running under Emacs if either INFERIOR=yes or ;; if EMACS is set to a nonempty value. The EMACS setting is @@ -1369,6 +1367,7 @@ prolog-ensure-process (cons "INFERIOR=yes" process-environment)))) (apply 'make-comint-in-buffer "prolog" (current-buffer) pname nil pswitches)) + (prolog-inferior-mode) (unless prolog-system ;; Setup auto-detection. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no