unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Lars Ingebrigtsen <larsi@gnus.org>
To: kobarity <kobarity@gmail.com>
Cc: Stephen Berman <stephen.berman@gmx.net>, 56742@debbugs.gnu.org
Subject: bug#56742: 29.0.50; Python indendation problem after comment
Date: Wed, 27 Jul 2022 11:39:04 +0200	[thread overview]
Message-ID: <87pmhqzyh3.fsf@gnus.org> (raw)
In-Reply-To: <CAMQkrSpwCkvs28Wa5FRtsJUd8PkDQ__FDdhJVdikbdz66TCr9A@mail.gmail.com> (kobarity@gmail.com's message of "Wed, 27 Jul 2022 12:27:09 +0900")

kobarity <kobarity@gmail.com> writes:

> I'm not so familiar with this part of python.el, but it looks good to me.

Thanks; I've now applied Stephen's patch to Emacs 29.

> How about modifying the ERT to address this issue?
>
> diff --git a/test/lisp/progmodes/python-tests.el
> b/test/lisp/progmodes/python-tests.el
> index 3b10bde23b..3828d4d5aa 100644
> --- a/test/lisp/progmodes/python-tests.el
> +++ b/test/lisp/progmodes/python-tests.el
> @@ -1108,6 +1108,7 @@ python-indent-dedenters-2
>      except Exception:
>          if hide_details:
>              logger.exception('Unhandled exception')
> +        # comment
>              else
>      finally:
>          data.free()

And I added a new test that does this (so that we have a test both with
and without the #comment).






  reply	other threads:[~2022-07-27  9:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-24 15:42 bug#56742: 29.0.50; Python indendation problem after comment Stephen Berman
2022-07-26 12:51 ` Lars Ingebrigtsen
2022-07-27  3:27   ` kobarity
2022-07-27  9:39     ` Lars Ingebrigtsen [this message]
2022-07-27 18:01       ` Stephen Berman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pmhqzyh3.fsf@gnus.org \
    --to=larsi@gnus.org \
    --cc=56742@debbugs.gnu.org \
    --cc=kobarity@gmail.com \
    --cc=stephen.berman@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).