From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#57082: 29.0.50; emacs-news-view-mode breakage Date: Wed, 10 Aug 2022 20:58:03 +0200 Message-ID: <87pmh8uds4.fsf@gmx.net> References: <87zggdxuf0.fsf@gmx.net> <874jylwa17.fsf@gnus.org> <865yj1p6o2.fsf@mail.linkov.net> <87v8r1xj9u.fsf@gmx.net> <86bkssedll.fsf@mail.linkov.net> <87r11owlx4.fsf@gmx.net> <86sfm4q6nu.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="39224"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 57082@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Aug 10 21:12:04 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oLr7c-000A0t-0b for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 21:12:04 +0200 Original-Received: from localhost ([::1]:57272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oLr7b-0006Ae-3e for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 10 Aug 2022 15:12:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45520) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oLquz-0000OD-Ue for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 14:59:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:32802) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oLquz-0000nB-LC for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 14:59:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oLquz-0004RF-HQ for bug-gnu-emacs@gnu.org; Wed, 10 Aug 2022 14:59:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 10 Aug 2022 18:59:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57082 X-GNU-PR-Package: emacs Original-Received: via spool by 57082-submit@debbugs.gnu.org id=B57082.166015789817010 (code B ref 57082); Wed, 10 Aug 2022 18:59:01 +0000 Original-Received: (at 57082) by debbugs.gnu.org; 10 Aug 2022 18:58:18 +0000 Original-Received: from localhost ([127.0.0.1]:50784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLquH-0004QI-JA for submit@debbugs.gnu.org; Wed, 10 Aug 2022 14:58:17 -0400 Original-Received: from mout.gmx.net ([212.227.15.15]:44249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oLquD-0004Q0-7s for 57082@debbugs.gnu.org; Wed, 10 Aug 2022 14:58:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1660157886; bh=2DbpNY+sXjdqUjO1TRX6rzffW0jpfD5a1JigqxRHsEM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Kykk/HviOtqnRyTZoRf6sOksR4bpuuJi52EPLHid7ka9DwVGjb7tWktP4lcFBvsML 2R/XYYAaL7FE5xb6IyH438ofRCXwDwxtqljUk2y0yCFFYsCbY7j2BQFLdIktimmM0H KWhuOPQ+Cp82obXv7VSTvKzFPME6fKynw6v/Ki8Y= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs2 ([89.246.36.16]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MHG8g-1o8bLa2pEG-00DIL9; Wed, 10 Aug 2022 20:58:06 +0200 In-Reply-To: <86sfm4q6nu.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 10 Aug 2022 21:45:25 +0300") X-Provags-ID: V03:K1:BQ97/dAHq1A5FLTVIhGs44co66e2l7bSKV33/YLD/FpfX7fu/U4 F28Un8wAafbNgoSQ9BxalKwnyjqQUqzxvYYGqJAKC8INOJCdyTH0hY2onU87OXrq2Buc+0q aIygNIAafBu8Pr6Ba+ykEv1mvg1ptP/GylowbXF/zVotwyBxKYwtQTxqs/DSaICXRHHbIdq vNmMLJNoddS1iH1vT/MVQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:uO97bJLY1wE=:pAGoGRJgJtMU+lTv/96VyR mOF4zuh0tl9/yIpiLbyQaxGzJlxZpdoUacjobzlzg7jIQEvsbqXk4yCZYL2xNfiH089cJxr3G zHMmTw7Lmr3mjuLBy78G/rUx363POu29zOVJLPRRzXR6Hvk1OP6Ec9oWBcZ9QSj7nggR/eLSF NhUPz/FTrwI6Zcvscku2kvz293YGd7K3QOgebztAYp7sz4gpu/bhIzfJusDC/bBgOr4eIXdXP TQ8Rtksf9tysZ2+rWyI4IP4zboADSopJw236c/QuKuuxTUgAvOXdch2OjHJX7mJvF4UIVetJK AQ3T4a8c31kLxCYQ1d9vabhHPKGiMvdciIq1ZIwGLtlchKidrM6P+/7HgrRhIyPmGpDIRta7k 2TwEgS8M782M1DXtYdLzjdb7FYjD0LaYYsLp05EWD5jrVF7lYFcm9RfXxfMAQKanHxywjJXiS AEpoFTU7lUXr4Kyyv0geCHJ//XA7JDGx/tDRE0tnQNcOK4X6jm7xOjBiPVCJDlUbuQhzevl+n UVlCllyYorga/GXc8l9JtUfB1r3l2k3kKwp2lI6YRl9zJ7fj42VUf5zNgTxJt3PQG5l89MqcB cyyoloDJw8EQryBWonZP4mkjj3QzwgvjovrTHFtoQ5ZaIsiGvX1lEzGjTnSi4Keq3twK9o/zx eyjRcQAqB967s9c5+sQhTWNq4hql8RhxKGcmZxs1+yH4CzjZzVXH2cpaG6Mrdki4aavtKerw2 rWotcoC6SdKLP6nrKr3QnhJqng8trsIMnDmO5MiqWYpFsZmPuFvq3jkXDwTtSFBEp9/lGQ8Z X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239316 Archived-At: On Wed, 10 Aug 2022 21:45:25 +0300 Juri Linkov wrote: >>>>> `outline-minor-mode-highlight-buffer' is intended only for buffers >>>>> that don't support font-lock highlighting. >>>> >>>> Yes, but with that change, arrows are displayed on first visiting the >>>> NEWS buffer; without it, they only appear when typing TAB on an outline >>>> heading. >>> >>> This change broke fontification e.g. in diff buffers that now >>> add outline faces on diff hunks. So we need another solution. >> >> Oh, dear (as I noted in my OP, I only checked NEWS and *Help* with >> describe-binding). But do you have a recipe to see this? When I create >> a diff with vc-diff I don't see outline faces on the hunks. > > The minimal test case is this: > > (setq-default outline-minor-mode-highlight t) > (add-hook 'diff-mode-hook 'outline-minor-mode) > > Then the first lines of diff is highlighted with blue outline-1 face, > the @@-lines with outline-2 face, etc. Yes, I see it now, thanks. > This is because outline-font-lock-keywords and > outline-minor-mode-highlight-buffer have slightly different > interpretations of the values for outline-minor-mode-highlight. > > This could be improved, but in any case both these functions > should not be applied at the same time. Ok. I'm not familiar enough with the intricacies of font-lock to whip up a quick fix and can't afford to spend a lot of time on it, so I hope someone better qualified than me will do it. Steve Berman