From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#56896: 29.0.50; [PATCHv3] Make the bookmark fringe icon look like a bookmark Date: Mon, 15 Aug 2022 08:44:44 +0200 Message-ID: <87pmh2c8f7.fsf@gnus.org> References: <39a51230-2a0f-4eb7-a811-e4509a826f5d@gmail.com> <83tu6u5u9r.fsf@gnu.org> <57ab6ad0-8b1f-ac3c-b675-bc4131d3e0c2@gmail.com> <83sfme5acq.fsf@gnu.org> <3b7b3223-3710-c57b-4c75-eb050eec63a9@gmail.com> <83edxw4hzn.fsf@gnu.org> <7566691d-090e-f380-b395-4d2aa2fdebdb@gmail.com> <01ebb4e2-4f0d-98c1-2e34-e7f5ea3fdc39@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27925"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 56896@debbugs.gnu.org, Eli Zaretskii To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 15 08:46:29 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNTro-00075n-TG for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 08:46:28 +0200 Original-Received: from localhost ([::1]:42602 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oNTrn-0001U2-C7 for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 15 Aug 2022 02:46:27 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53840) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oNTqQ-0001TJ-PE for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 02:45:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50694) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oNTqQ-00026x-GN for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 02:45:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oNTqQ-0000Tw-D0 for bug-gnu-emacs@gnu.org; Mon, 15 Aug 2022 02:45:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 Aug 2022 06:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56896 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56896-submit@debbugs.gnu.org id=B56896.16605458951792 (code B ref 56896); Mon, 15 Aug 2022 06:45:02 +0000 Original-Received: (at 56896) by debbugs.gnu.org; 15 Aug 2022 06:44:55 +0000 Original-Received: from localhost ([127.0.0.1]:40443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNTqJ-0000Sq-CO for submit@debbugs.gnu.org; Mon, 15 Aug 2022 02:44:55 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:55722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oNTqH-0000SY-UG for 56896@debbugs.gnu.org; Mon, 15 Aug 2022 02:44:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VC5+xvQtMN0HQaNo8R6YKSVksVSjdfMPgCz6cu5mmq0=; b=mMGP9TPZGV40VnzwgyTesMuLJC 1dB2lZo/+oAxf/P33WdTFziudvIR1OuFwVzIf/EFkemyksHwRsd1dSZyA/KJo1IkySCmqptfSfucu DcArpitbUOrXsuzgoAq2mcsspbMomj47ys3RwXXIsI4Pt+66bHJFdw0+KX/oHPvgv9vU=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNTq9-0004bn-63; Mon, 15 Aug 2022 08:44:47 +0200 In-Reply-To: <01ebb4e2-4f0d-98c1-2e34-e7f5ea3fdc39@gmail.com> (Jim Porter's message of "Sat, 13 Aug 2022 14:59:49 -0700") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEW6ub0TExZaWl// ///b7+IJAAAAAWJLR0QDEQxM8gAAAAd0SU1FB+YIDwYdNL6P7bMAAAHBSURBVCjPLZFBi9swFIQn Bpe174Ylp7CgkuRXJLklJ2M8QvZJNZsl9q9wDIF1T70obHNyCgrJ/so+byuQ4NPTG0kzAO3VMPPJ MY8ArqKUafgW6VBgo4yASRghqFfuPwQIm1VyYBZq5eYIh059CHDiY7BU/Bo/SDB3ZCqzHKGSXStV 7QjfyypSZFijD7V3r0lNbrd4d/q7w6QomNWQloztRM7mCbajaNfTUSuIjuK7YkGu4Zo86SvvS+7/ gAfro1I9zPnzLpfWPLI+8uZLyGUi11TcsgB1Un742IY1azBlc5sFbaDdA6cqX97aEdQOfW+WEAD7 DreFmeFFKqweMIV5xqxrJ/IPeaiZtnPVXse3nQpzGWI3XLXvoXZWD9/us/j1kcHtMt6jdojPysAV jcDh12JPDceYh8A8L8QFOH0RmE1/j75FWckmsNNSJ1v87ATQCoQbqEp+A1ykUiHRlRNw9djj2PIw wpcaNzQCxX5MoVwlVpL9PLscizerLF7cp+aAcJ/GA2L3oBiypp2n/8AjpX3KReAxpqCdXSpxoJdQ 4b19CiXRiHWN/TqdT6R5wtMezOw8kEAjiUu8Hubifhdp8i8Ngbq/aYpF5AAAACV0RVh0ZGF0ZTpj cmVhdGUAMjAyMi0wOC0xNVQwNjoyOTo1MSswMDowMDyZ7KQAAAAldEVYdGRhdGU6bW9kaWZ5ADIw MjItMDgtMTVUMDY6Mjk6NTErMDA6MDBNxFQYAAAAAElFTkSuQmCC X-Now-Playing: Prince's _Dirty Mind_: "Head" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:239734 Archived-At: Jim Porter writes: > Here's a better version of this patch. Rather than a proxy object, it > just sets the 'fringe' property on the defcustom, which the rest of > the bookmark code can then use like a "regular" fringe bitmap > (essentially, it's just an alias to a real fringe bitmap). I also > added a 'fringe-custom-set-bitmap' function that anyone can use as a > :set function. Makes sense to me; please go ahead and push. > This should be general enough that it could be used wherever anyone > wants to allow users to use Customize to change the fringe bitmap that > gets used for a particular purpose. Potentially, it could even be used > for *every* use of a fringe bitmap. That would let users pick icons > they like for a particular purpose based on their general description > (e.g. 'right-triangle'), but they could also independently adjust the > bitmaps (e.g. redefining all the fringe bitmaps to be larger for high > DPI monitors). For the latter case, maybe users could download a > package from ELPA to do that. I wonder whether we could usefully fold this stuff into the new icons.el library. I'm not sure how, though, because the fringe stuff is so low level. And icons.el is all about graceful degradation, and there's not much to degrade to in a fringe context.