From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#57915: 29.0.50; Misleading warning about use of quote in clause of cl-case Date: Mon, 19 Sep 2022 10:32:01 +0200 Message-ID: <87pmfrwyri.fsf@gnus.org> References: <87y1ugo4qk.fsf@bernoul.li> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="1609"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Philipp Stephani , 57915@debbugs.gnu.org To: Jonas Bernoulli Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Sep 19 10:43:01 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaCMn-0000Ad-6M for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 10:43:01 +0200 Original-Received: from localhost ([::1]:39114 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oaCMk-0001CO-1C for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 19 Sep 2022 04:42:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:60792) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oaCD8-000190-FB for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 04:33:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:53222) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oaCD8-0002uz-5p for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 04:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oaCD7-0002LK-MS for bug-gnu-emacs@gnu.org; Mon, 19 Sep 2022 04:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 08:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57915 X-GNU-PR-Package: emacs Original-Received: via spool by 57915-submit@debbugs.gnu.org id=B57915.16635763378945 (code B ref 57915); Mon, 19 Sep 2022 08:33:01 +0000 Original-Received: (at 57915) by debbugs.gnu.org; 19 Sep 2022 08:32:17 +0000 Original-Received: from localhost ([127.0.0.1]:52300 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaCCO-0002KC-NI for submit@debbugs.gnu.org; Mon, 19 Sep 2022 04:32:16 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:47954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaCCM-0002Jz-RN for 57915@debbugs.gnu.org; Mon, 19 Sep 2022 04:32:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1mi+RIQ1gyPYiJnScfaLmZQn/h0o8UIDo8vNeX8b5bM=; b=nx6jkRpfjvDkEo4AS+N9q5edqD S0RObhRNMGC/tSVyDWmibqWmJc4Ap6cDuNy0qbWEWeh8iQ4w9cIJcB80kSXGeD/5H654pTwwPEJ/+ IAo4LsxcorT5B4KsYcu0E81EOltXwMLmjHrsohIJrzUZJ9EST5F3pFoaxvfa01DgeWrQ=; Original-Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaCCB-0007Fl-VT; Mon, 19 Sep 2022 10:32:08 +0200 In-Reply-To: <87y1ugo4qk.fsf@bernoul.li> (Jonas Bernoulli's message of "Sun, 18 Sep 2022 21:35:31 +0200") X-Now-Playing: 13 & God's _Own Your Ghost_: "Armored Scarves" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243051 Archived-At: Jonas Bernoulli writes: > I inherited some code like this: > > (cl-case foo > ((quote) ...) > ((funcall) ...)) > > While I probably would not have written it like this, I think it > makes sense, since (quote ...) looks like ... is being quoted. Using > ((quote) ...) make it clear to the human reader that that is not what is > happening. Unfortunately the byte-compiler now provides this misleading > warning: > > Warning: Case (quote) will match =E2=80=98quote=E2=80=99. If that=E2= =80=99s intended, > write (nil quote) instead. Otherwise, don=E2=80=99t quote =E2=80=98n= il=E2=80=99. [...] > Could this special case, (quote), be handled differently? I understand > we want to catch, pcase-inspired clauses like 'x. I am not sure we can > tell the difference between (quote), (quote nil) and 'nil, but it seems > to me, that if that is not the case, we should avoid the invalid > recommendation at the cost of not warning about the other, likely > unintended uses. Yeah, since there isn't really any other way to express this (or is there?), we should probably not warn about this construction. I've added Philipp to the CCs; perhaps he has some comments.