From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#51384: 28.0.60; substitute-command-keys finds global binding for undo instead of in specified keymap Date: Wed, 21 Sep 2022 09:17:46 +0200 Message-ID: <87pmfpci1x.fsf@gmail.com> References: <877de1s9yl.fsf@gmail.com> <87o87d9zpv.fsf@igel.home> <87y26hqtgt.fsf@gmail.com> <8635nxcow3.fsf@mail.linkov.net> <87czn1nwdr.fsf@gmail.com> <871qsd4xnj.fsf@gnus.org> <877d25krwg.fsf@gmail.com> <87wna3y8eh.fsf@gnus.org> <87fsgriqt1.fsf@gmail.com> <874jx7y705.fsf@gnus.org> <875yhidp47.fsf@gmail.com> <87fsgmavsm.fsf@gnus.org> <87v8pic81i.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Andreas Schwab , 51384@debbugs.gnu.org, Juri Linkov To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 21 09:19:08 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oau0i-0004U6-4H for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 09:19:08 +0200 Original-Received: from localhost ([::1]:49962 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oau0g-0004ZT-HK for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 21 Sep 2022 03:19:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57098) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oatze-0004Wn-Mj for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 03:18:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:33130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oatze-0002z3-Ac for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 03:18:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oatze-0003Lg-4R for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 03:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 07:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51384 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed Original-Received: via spool by 51384-submit@debbugs.gnu.org id=B51384.166374468012864 (code B ref 51384); Wed, 21 Sep 2022 07:18:02 +0000 Original-Received: (at 51384) by debbugs.gnu.org; 21 Sep 2022 07:18:00 +0000 Original-Received: from localhost ([127.0.0.1]:60441 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oatzb-0003LQ-N0 for submit@debbugs.gnu.org; Wed, 21 Sep 2022 03:17:59 -0400 Original-Received: from mail-wm1-f50.google.com ([209.85.128.50]:42971) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oatzX-0003L8-6P for 51384@debbugs.gnu.org; Wed, 21 Sep 2022 03:17:58 -0400 Original-Received: by mail-wm1-f50.google.com with SMTP id o20-20020a05600c4fd400b003b4a516c479so3199273wmq.1 for <51384@debbugs.gnu.org>; Wed, 21 Sep 2022 00:17:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=uiJCJ97xdUM1T790WlH56BHzV1AXPApkSaqjULTIt+A=; b=ANp8IMCPPBvSctR7sZHAPQWNHeqoPE+ddlTnwmDnUv8MEsZfO26WMA1W5R6sglAhK1 4SdhswOWi1LtmHyuq7K2w53eX6NHwoJrWikyZild2oEhoVSGheuOFbJ7aWjr7Bpqb6+5 /d3fydHgTIvzu0UUg9SL7vMxExpUw0B4QEOFW7thslNjOZA4o030uLl7QDR+ep5p+D3H LsFslgSFosuOUwjUJgrvTvENSDi8Z/nP8bM00xj4uGH8fc4nDoByZMnAMjmBPXBtacxu +LgyNTxIEShAloyusLKaEcV7n5SPtDbagzBd16XbdlNeKIn0cD7YOOrSO+aV+yfxbwjf IDRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=uiJCJ97xdUM1T790WlH56BHzV1AXPApkSaqjULTIt+A=; b=pbMM+78B5jZhIjOJz4j8BTVlmtwJ9aXlmzvlwwaPI1iYRW0hNrpb4B4yAwKqvZMZ9W 5eFrwxq4pdsvPpfkoSHwzfxWbcdhLle/cBPyTDnIaaGv5DTiIXJWNqn7W7E35sL5trMR es0Lr+EliU/mpx+TizJdFb7sfJr+gU4oG8mFgUMtbqPKHkv+k2Ko/zXTM3aIvfrqd0pD YMf1flpZ0p2nfjCozg/vJl6KASk4N5sDK+6viqx2z7ghLQyO+s/dmqSmJk810wWxMVE0 WdQCNtDhjL/OKtzZvvh5V4FwZHALsxopvvfLT2FCh43WPzM1GPBbgdwPxm+3+wlui43p Uj1A== X-Gm-Message-State: ACrzQf1oQJw8u1krfce4rO+rriz8J0/v/ZkW7QORtPWL5qND2ZDfEYz4 1wV5mdRy6G02BOeD9zlCoZg= X-Google-Smtp-Source: AMsMyM5SeYtDo359cYAPggEUgzDk529urSK+1TDGYU4PotsRMoeCJy0tyEjXirwLRb8LlQJNCqSGuQ== X-Received: by 2002:a05:600c:19ce:b0:3b4:c709:4307 with SMTP id u14-20020a05600c19ce00b003b4c7094307mr4748802wmq.182.1663744668194; Wed, 21 Sep 2022 00:17:48 -0700 (PDT) Original-Received: from rltb ([2a01:e0a:3f3:fb50:16a0:9848:d23c:7dcb]) by smtp.gmail.com with ESMTPSA id x12-20020a5d650c000000b00228cbac7a25sm1665558wru.64.2022.09.21.00.17.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 00:17:47 -0700 (PDT) In-Reply-To: (Stefan Kangas's message of "Tue, 20 Sep 2022 14:03:53 -0400") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:243278 Archived-At: >>>>> On Tue, 20 Sep 2022 14:03:53 -0400, Stefan Kangas said: Stefan> This looks eerily similar to the code I removed here: Stefan> commit ac0027f6a5480bd4739fdf71413a19012f400483 Stefan> Author: Stefan Kangas Stefan> Date: Mon Jul 11 17:21:23 2022 +0200 Stefan> Remove dead branch from substitute-command-keys Stefan> * lisp/help.el (substitute-command-keys): Remove dead b= ranch; Stefan> where-is-internal will follow any remaps for us. Note = also that the Stefan> test case for remapping still pass. Similar, but not the same. That dead branch followed remaps, this code redoes the lookup in the global map. Stefan> Do we have a test case that reverting that commit would fix? No, and I don=CA=BCt see why you=CA=BCd want to revert it, it seems correct= to me. Stefan> (I can't see Lars' message yet, so the delays with the gnu.org = mail Stefan> systems seem to be ongoing...) It=CA=BCs not jut gnu.org for me, but maybe that=CA=BCs a local issue. Anyway, I=CA=BCve pushed the fix as cee9a2cbe0 Robert --=20