From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57639: [PATCH] Add new command 'toggle-theme' Date: Mon, 10 Oct 2022 08:16:06 +0000 Message-ID: <87pmf0aybd.fsf@posteo.net> References: <875yhzmz25.fsf@posteo.net> <87edw955ls.fsf@gnus.org> <8735coewsk.fsf@posteo.net> <871qs7ztgq.fsf@gnus.org> <87o7vbg56k.fsf@posteo.net> <874jx3ye41.fsf@gnus.org> <87bkrbfz8l.fsf@posteo.net> <871qs5lpo2.fsf@posteo.net> <87mtatagzv.fsf@gnus.org> <87edw5n2zm.fsf@posteo.net> <87o7v97zy2.fsf@gnus.org> <87bkr9newj.fsf@posteo.net> <871qs57yai.fsf@gnus.org> <87y1udlzlt.fsf@posteo.net> <87o7v953uf.fsf@gnus.org> <87tu50nca7.fsf@posteo.net> <87a6652lyb.fsf@posteo.net> <875ygtqdho.fsf@gnus.org> <87wn99114w.fsf@posteo.net> <87v8os5vf1.fsf@protesilaos.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2090"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Lars Ingebrigtsen , Eli Zaretskii , Stefan Kangas , 57639@debbugs.gnu.org To: Protesilaos Stavrou Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 10 10:28:48 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oho9X-0000Kq-Cb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 10:28:47 +0200 Original-Received: from localhost ([::1]:60766 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oho9V-00074W-VB for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 10 Oct 2022 04:28:45 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59032) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ohnyA-0003yJ-Vi for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:17:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:46789) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ohnyA-0000HR-Kk for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:17:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ohnyA-0006Sa-Fi for bug-gnu-emacs@gnu.org; Mon, 10 Oct 2022 04:17:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 10 Oct 2022 08:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57639 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 57639-submit@debbugs.gnu.org id=B57639.166538977524752 (code B ref 57639); Mon, 10 Oct 2022 08:17:02 +0000 Original-Received: (at 57639) by debbugs.gnu.org; 10 Oct 2022 08:16:15 +0000 Original-Received: from localhost ([127.0.0.1]:45861 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnxP-0006R9-10 for submit@debbugs.gnu.org; Mon, 10 Oct 2022 04:16:15 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:42165) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ohnxN-0006Qx-HC for 57639@debbugs.gnu.org; Mon, 10 Oct 2022 04:16:14 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 0703E240029 for <57639@debbugs.gnu.org>; Mon, 10 Oct 2022 10:16:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665389768; bh=G5GnNuMYw4H4SbNOwiLzjkvXMRjyGhcHFx0OrA8qnK0=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=W6SdtzJ4CgeSqwhvtiNU6w+T6bGwUFkgcAjTsqT9gTjQ9u8AS65Ci1WyuuQL5lJh9 kQBkp4wDI2G02cn9oNXJunXid2Yw7WGZMBQD05+mSogutiz6IAHKL27mCsAGrroNX7 yhzwS6fGGHfn6qpPLXSd9Xo3bglQNpM9o29eIym8jhDPVF7QII97Qc/s7lPzTEb86g fF9iTZyvDGEzVo4FZ8fL8GfhV9frwrExNOt82EQktTRtAs1SHrDlyTPQtLlDGQL8+X 3XBtJH5Ojq40mJut7MCZp2Xrbu0QsXAlWU0b+jEHhUP6CW3w6BhSOro9l6c9ug758s JXLMssjpk8y9Q== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MmBZG6MsWz6tmG; Mon, 10 Oct 2022 10:16:06 +0200 (CEST) In-Reply-To: <87v8os5vf1.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Mon, 10 Oct 2022 04:17:38 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244989 Archived-At: Protesilaos Stavrou writes: >> From: Stefan Kangas >> Date: Sun, 9 Oct 2022 22:32:49 +0200 >> >> Philip Kaludercic writes: >> >>> --8<---------------cut here---------------start------------->8--- >>> ;;;###autoload >>> (when (and (boundp 'custom-theme-load-path) >>> load-file-name) >>> ;; Add theme folder to `custom-theme-load-path' when installing over MELPA. >>> (add-to-list 'custom-theme-load-path >>> (file-name-as-directory (file-name-directory load-file-name)))) >>> --8<---------------cut here---------------end--------------->8--- >>> >>> from leuven-theme.el to be removed. >> >> Why would the above be necessary for leuven-theme.el in particular? >> >> I've never had a problem loading themes installed from MELPA, so I don't >> understand why it should need any special treatment. > > Note that the modus-themes.el have this: > > ;;;###autoload > (when load-file-name > (let ((dir (file-name-directory load-file-name))) > (unless (equal dir (expand-file-name "themes/" data-directory)) > (add-to-list 'custom-theme-load-path dir)))) > > It is (was?) necessary to make the theme available when installing with > package.el (GNU ELPA). I have just checked a few themes from MELPA, and they all include this snippet. And it appears rightfully, as package.el doesn't do any theme handling.