From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Matt Armstrong Newsgroups: gmane.emacs.bugs Subject: bug#58479: 29.0.50; [feature/noverlay] Displaced overlays in notmuch search buffers after refreshing Date: Wed, 12 Oct 2022 21:25:04 -0700 Message-ID: <87pmewqrj3.fsf@rfc20.org> References: <87zge0tqkt.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="29931"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58479@debbugs.gnu.org, monnier@iro.umontreal.ca, matt@rfc20.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 13 06:26:17 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oipnU-0007bi-WC for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 06:26:17 +0200 Original-Received: from localhost ([::1]:50174 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oipnT-0006nJ-Fr for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 13 Oct 2022 00:26:15 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:50540) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oipnH-0006nB-N5 for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 00:26:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:59773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oipnH-0002ZI-Et for bug-gnu-emacs@gnu.org; Thu, 13 Oct 2022 00:26:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oipnG-0005sq-9v; Thu, 13 Oct 2022 00:26:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Matt Armstrong Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, matt@rfc20.org, bug-gnu-emacs@gnu.org Resent-Date: Thu, 13 Oct 2022 04:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58479 X-GNU-PR-Package: emacs X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca, matt@rfc20.org Original-Received: via spool by 58479-submit@debbugs.gnu.org id=B58479.166563512222567 (code B ref 58479); Thu, 13 Oct 2022 04:26:02 +0000 Original-Received: (at 58479) by debbugs.gnu.org; 13 Oct 2022 04:25:22 +0000 Original-Received: from localhost ([127.0.0.1]:58851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oipmb-0005rv-HX for submit@debbugs.gnu.org; Thu, 13 Oct 2022 00:25:21 -0400 Original-Received: from relay6-d.mail.gandi.net ([217.70.183.198]:35789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oipmX-0005rQ-Ot for 58479@debbugs.gnu.org; Thu, 13 Oct 2022 00:25:19 -0400 Original-Received: (Authenticated sender: matt@rfc20.org) by mail.gandi.net (Postfix) with ESMTPSA id 00E54C0002; Thu, 13 Oct 2022 04:25:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rfc20.org; s=gm1; t=1665635111; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Chx+Yy7jKQtoFzoTLxFuGtunFMrVGNkfAdzHlOLxJWw=; b=jPEtEOhJ/l84haP1DlWc765l0p3N9XxQ7Y5xJLcjeiQbnVt0J1nTWqDWKRSgVaPtMsaQiA nIVSsrLcC1lq+2upucuVPl+lb6B7iPjhtF7Muk9TuvzmAT0uifJ5AQhCCCgBLmBTqNXgFQ bjJsST1/tQbn5Fv1TElnho2vw/VKtzttvqAoTHifRskkVX4U+NiTt36aPtG43+I7c4Dx+/ bg22OYgJDzVm3aF46GgLloih6SX9axRoR36U7xcetdomMcvWpD6eeWXzJSJqF5JRrZVJnQ hzojXhvmv5+LuecckCRBEotSfXQwM987TN0dVlrwnAadJOBGHqcBjMlpO9l/Tg== Original-Received: from matt by naz with local (Exim 4.96) (envelope-from ) id 1oipmK-0008l9-0W; Wed, 12 Oct 2022 21:25:04 -0700 In-Reply-To: <87zge0tqkt.fsf@localhost> (Ihor Radchenko's message of "Thu, 13 Oct 2022 10:17:22 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:245264 Archived-At: X-Debbugs-CC: monnier@iro.umontreal.ca, matt@rfc20.org ^^^ I don't know if Debbugs pseudoheaders work here but I'll give it a shot. Ihor Radchenko writes: > As I mentioned in > https://yhetil.org/emacs-devel/jwvo7ulzmvv.fsf-monnier+emacs@gnu.org/, > I consistently observe issues with overlays in notmuch search buffers > on feature/noverlay branch. > > I have tested with Emacs 29 master vs. feature/noverlay and confirm that > the problem only appears in feature/noverlays. Thank you for following up with a clear report of the problem. I use notmuch so it was easy for me to follow your steps. I agree that an "emacs -Q" recepie won't be practical here. Request: could you try your repro again for notmuch-search and include the output of the `my-dump-overlays' function below? One half of the problem, the left over overlays, appears on master too. You should be able to confirm by running this wth the notmuch-search buffer current after refreshing with 'g': (defun my-dump-overlays () (interactive) (with-output-to-temp-buffer "*Overlays*" (save-restriction (widen) (let ((overlays (overlays-in (point-min) (point-max)))) (princ (format "Buffer %S has %d overlays.\n\n" (current-buffer) (length overlays))) (dolist (o overlays) (pp o) (terpri) (pp (overlay-properties o)) (terpri)))))) I sent the notmuch folks a patch to fix this by setting 'evaporate on them: https://nmbug.notmuchmail.org/nmweb/show/20221013032038.23371-1-matt%40rfc20.org (You verified that the overlays are not cleared up after erasing text, and they shouldn't be *unless* they have 'evaporate set. There have been some discussions that 'evaporate should have been the default from the beginning, but changing that now might break things.) The other half of the problem is this: you can see the ellipsis and I cannot, even on the noverlay branch. When I play around with the buffer created by the following I can see the ellipsis up until when the overlay has length zero, then it disappears. This is true on master and the noverlay branch. (defun my-b58479 () (interactive) (with-current-buffer (get-buffer-create "*b58479*") (add-to-invisibility-spec (cons 'ellipsis t)) (goto-char (point-max)) (insert "Hello, World! ") (let ((overlay (make-overlay (- (point) 10) (- (point) 5)))) (overlay-put overlay 'invisible 'ellipsis)) (display-buffer (current-buffer)))) I am not sure why you see the issue and I do not, but the clue might be in what `my-dump-overlays' prints. -- matt (sent from an Emacs running the feature/noverlay branch)