From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Sean Whitton Newsgroups: gmane.emacs.bugs Subject: bug#58383: 29.0.50; Make it easier to invert vc-prepare-patches-separately Date: Thu, 10 Nov 2022 17:07:03 -0700 Message-ID: <87pmduwdzs.fsf@melete.silentflame.com> References: <87mta6b3yu.fsf@melete.silentflame.com> <87edvh2m3o.fsf@posteo.net> <87v8nq4b62.fsf@melete.silentflame.com> <87cz9xgpd9.fsf@posteo.net> <87sfityxe8.fsf@melete.silentflame.com> <87sfisedkk.fsf@posteo.net> <87educytij.fsf@melete.silentflame.com> <87iljo9g1h.fsf@posteo.net> <875yfnzw14.fsf@melete.silentflame.com> <87v8nm5zzp.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28824"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 58383@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 11 01:08:33 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otHaz-0007JS-4d for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 11 Nov 2022 01:08:33 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otHae-0006XM-1P; Thu, 10 Nov 2022 19:08:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otHab-0006WS-QZ for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 19:08:10 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1otHaU-0000Vx-Qz for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 19:08:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1otHaU-00089e-EH for bug-gnu-emacs@gnu.org; Thu, 10 Nov 2022 19:08:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 11 Nov 2022 00:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58383 X-GNU-PR-Package: emacs Original-Received: via spool by 58383-submit@debbugs.gnu.org id=B58383.166812523831292 (code B ref 58383); Fri, 11 Nov 2022 00:08:02 +0000 Original-Received: (at 58383) by debbugs.gnu.org; 11 Nov 2022 00:07:18 +0000 Original-Received: from localhost ([127.0.0.1]:44668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otHZl-00088e-JN for submit@debbugs.gnu.org; Thu, 10 Nov 2022 19:07:17 -0500 Original-Received: from out4-smtp.messagingengine.com ([66.111.4.28]:55669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1otHZf-00088L-Uy for 58383@debbugs.gnu.org; Thu, 10 Nov 2022 19:07:16 -0500 Original-Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id CC2FA5C00FD; Thu, 10 Nov 2022 19:07:04 -0500 (EST) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 10 Nov 2022 19:07:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1668125224; x=1668211624; bh=gI H9Ju4aJwvMAn3rvrzRhDHNWzVtPUcDnYgQuZ+Xmig=; b=ha3wODguWWwU7tujzQ L97SkIMtjdPrJ6ldjE0qA/ctPhey9P72GkuTPqY1opwbK0qCODNh0zFYCj9H/1fC A0nOQBH98M6WdKMSq4WygqdqZ42oN9sCcjhRZLF6dCrMybtNQZIExsWyug9khsVP rQOPATp7nSydx/IHeD+B1bx9qKs1uQLrTWh6BieqKYkL7MSoPmKoNHmC5+xJko+0 4VxMoJFs60Hjpj3TlSZh28vgjrz4sUMPG5+EfGVNovWQPPqtmhH77AMCNv3toaRf 267ANLZH2f2ZLFvh2tSWoI5UqiQuHvj/nsoZxwStxjQ6pdgZq3mDebSabuNsK/4J bMJQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1668125224; x=1668211624; bh=gIH9Ju4aJwvMAn3rvrzRhDHNWzVt PUcDnYgQuZ+Xmig=; b=U7+bpMFR0+bEb2j4FinSYBOEsyS2Drj2Jyxz4dH26VJE 6uVJp4PaMQU5OJdPVEDhVjrPRt7Joy8lV0wNdPN4YhpPoWawjfRAd0PlIelVMLbM yxdHpvaYRgaJyoXvMeZ00V4Y53gKcAMzsgqLQ7BfWtLXy4XEXnaHmQT9VKX+ze0t 5V7be4yuI2LG+BNrwqYwxd2LoPvmaVsU7w2YAEuZ0oPlN+k7QT0+nfYaOgRVJIrO t2toB6bigIcUSMEXoK6fzM+LGZv6rq9wHaWk+mvxp6tmaxIbMXaTo4OGM8Yyqdrx LYHYseol/W+nk/rNkRb/nUGd0ofxQq/1X6UrT+/ing== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrfeehgddulecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedukeeg geelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 10 Nov 2022 19:07:04 -0500 (EST) Original-Received: by melete.silentflame.com (Postfix, from userid 1000) id 32CB57E6C8B; Thu, 10 Nov 2022 17:07:03 -0700 (MST) In-Reply-To: <87v8nm5zzp.fsf@posteo.net> (Philip Kaludercic's message of "Thu, 10 Nov 2022 20:14:02 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:247562 Archived-At: Hello, On Thu 10 Nov 2022 at 08:14PM GMT, Philip Kaludercic wrote: > Sean Whitton writes: > >> Hello, >> >> On Wed 09 Nov 2022 at 05:46PM GMT, Philip Kaludercic wrote: >> >>> The critical edge-case here is what happens when branches are merged. >>> Do you pick a random branch or collect all the patches. Or do you raise >>> an error, but then how do you detect that vc-generically. >> >> Typically you wouldn't want to format patches across a merge, so I would >> suggest raising an error. > > And this is something I don't think can be /expressed/ using vc, because > while I can collect a number of revisions using `previous-revision', > there is no general way to verify if a commit is a merge commit. Can we do that part on a VCS-by-VCS basis? Default to just calling previous-revision and hoping for the best, but giving vc-git.el a chance to raise an error. -- Sean Whitton