From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud Newsgroups: gmane.emacs.bugs Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Date: Fri, 18 Nov 2022 13:10:07 +0100 Message-ID: <87pmdkwjj4.fsf@elite.giraud> References: <87tu2wlku7.fsf@elite.giraud> <878rk8ee6d.fsf@yahoo.com> <8735agr0g4.fsf@elite.giraud> <874juwebfr.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="19760"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 59351@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 13:11:20 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow0DI-0004wf-9x for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 13:11:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow0D2-0006ko-8G; Fri, 18 Nov 2022 07:11:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow0D0-0006kg-KT for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 07:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow0D0-0001oc-Bp for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 07:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow0D0-00039E-7o for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 07:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 12:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59351-submit@debbugs.gnu.org id=B59351.166877341512034 (code B ref 59351); Fri, 18 Nov 2022 12:11:02 +0000 Original-Received: (at 59351) by debbugs.gnu.org; 18 Nov 2022 12:10:15 +0000 Original-Received: from localhost ([127.0.0.1]:35551 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow0CE-000382-OV for submit@debbugs.gnu.org; Fri, 18 Nov 2022 07:10:15 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:41327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow0CC-00037o-2i for 59351@debbugs.gnu.org; Fri, 18 Nov 2022 07:10:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=/1zVP5UjxQ+PdZft TGxtT4lwHNdf9BELrXu7FxGq6MU=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=wnN2tHq7422wsgBbboXKyz4eIVsJ3+cS5uCcUj +3kX6ifk9cSHp9RhmvIcxDfXKVBvcpXlggJztXjVUXGcmE/w1pSzTpz3ZbqghGWglIyGAl NXQ5U7zcMpJUkupfuE3cMicORsEgdygiHg1t/pXTxgrw4JSV16IjYTfCIxW1B6NL81CY1Z 96R9qbtpumpB5u2zTbQ4vyA1mmU+Mdyy2DYEJyIT2xn8kmXFP6IJXJUQoO7jQ+GXccAgfx a9TLtr555mNAAYAD4rydGbSlGJ5GGdfRwr3OgzVDRLvwcE8q8BS4+OWx/YOC9P5hv/Jt1B d/fQ+pZUCzMOOFZfS9rapLVw== Original-Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id fe5533a7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 18 Nov 2022 13:10:09 +0100 (CET) In-Reply-To: <874juwebfr.fsf@yahoo.com> (Po Lu's message of "Fri, 18 Nov 2022 19:42:16 +0800") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248215 Archived-At: Po Lu writes: > Manuel Giraud writes: > >> +struct glyph *x_y_to_hpos_vpos (struct window *, int, int, int *, int *, >> + int *, int *, int *); > > Shouldn't this be "extern struct glyph *x_y_to_hpos_vpos ...?" Ok. I'll fix that. >> + /* I guess this works because the menu bar is always >> + at position (0, 0) in a frame. Should this changed >> + and we need a way to calculate the correct position >> + into the menu bar from the position of the event in >> + the frame. */ > > I think this comment is unnecessary. Where else would a menu bar be? I don't know. Maybe in some distant future, menu bar will be anywhere :-) It also helps with the previous comment about event position being relative to frame because here we are converting in f->menu_bar_window. -- Manuel Giraud