From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60703: Patches to xwidget code Date: Fri, 27 Jan 2023 08:44:20 +0800 Message-ID: <87pmb024d7.fsf@yahoo.com> References: <87cz7mhfrr.fsf@yahoo.com> <837cxuo6cj.fsf@gnu.org> <874jsxhnwy.fsf@yahoo.com> <83bkmsmk6g.fsf@gnu.org> <83fsc3lwtg.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28117"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 60703@debbugs.gnu.org To: Andrew De Angelis Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 27 01:45:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLCrh-000775-U3 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 27 Jan 2023 01:45:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pLCrY-00047J-4d; Thu, 26 Jan 2023 19:45:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pLCrX-00047A-08 for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2023 19:45:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pLCrW-0000ci-H6 for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2023 19:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pLCrW-000361-Dl for bug-gnu-emacs@gnu.org; Thu, 26 Jan 2023 19:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 27 Jan 2023 00:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60703 X-GNU-PR-Package: emacs Original-Received: via spool by 60703-submit@debbugs.gnu.org id=B60703.167478027711847 (code B ref 60703); Fri, 27 Jan 2023 00:45:02 +0000 Original-Received: (at 60703) by debbugs.gnu.org; 27 Jan 2023 00:44:37 +0000 Original-Received: from localhost ([127.0.0.1]:36442 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLCr7-000351-E6 for submit@debbugs.gnu.org; Thu, 26 Jan 2023 19:44:37 -0500 Original-Received: from sonic317-33.consmr.mail.ne1.yahoo.com ([66.163.184.44]:45142) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pLCr6-00034l-5B for 60703@debbugs.gnu.org; Thu, 26 Jan 2023 19:44:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1674780269; bh=VsJdiSZcDiFKX56XhSPvyJSM5lqq7FEWt2EiYbpXipQ=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=AYqAb0exbR69b1goI47J/eb4APCC+sEDz7eU4usZza7r491y3dypFukMuRXUzCTJZzwQIWgKPLsLP6L+0NNF96zZydy1zPGmafO/ngPeuPUeiNFvr1u1Dw8Tsg1sS82WZOctnEm9ZCzUgHgQo99ol6ZgDDHQ3XIpb/SjbmHnMhG2CB3PHcPHJe/FLHmDnCklXklUNNVBqD3A5yBgyMlgJKs/32MSs59psL20iyTGrFJtyof5J8wstgBu/VBa1aVLX/JNGtZGSRz7y6jfcsjsLlX6C/eq8dpkfrDWKUxbcDAeqluZv0mEgT6Us46CEJJHMNiflqzD+jJew1CPzIl78A== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1674780269; bh=PiMnbFD0OENph097rU89SAodArMyzFONKhmUDzbQlUG=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=FP8xN/OFkpMQMH1prZCyvKe2U25FkMm6UqMEWRI0AUs/pU2AddzpQQLzgytEnA21ibedpem4Q4VNjrBQBh3oCOcpIGizZNc+bSbL/kyJ7v5RSCNtjh5TgGSG9Rj2l0SptrR0nHqswTF9Lkrlziaz2lfZ+kSzkdfoTFCT9fx/8YjWLqTwu82B2uLt467e3wO2ItCmKNAf92lADOhCrmMiniS9OGniV9ZCupXAJ0kbHuad1ZqbCUJlc7Rg3WGWahY/j8zUH4APqSznT0aoma/KnQ2jrZyxSIGYBKb6wbfKvo5XFC65i8dkiZK5urPVug1DwI3OZKFSJ/mgTLh/vyl4jw== X-YMail-OSG: E0iOPx4VM1n1LpNI7E1iwK1cWVUiT6M5rp_rkuwCGtkAryK_U6LkpyiOW5m0_Rr shLrRr0L7e8.HOGt5VNpf70A2czopU2ate7k55dmohzpEoji5YD0fWA_7ozaUEdP0nHyTo9bcw6R RRRdzZnFi8G9CQkZKWoSSalGFZ4OpPrXSlMpHKEvCrFx5x8jj45fMgsICs6A1NpAGxYppRYVQSsx rqbgRA_Im4uBlQwrDGg7QzQWcTvNDoF.DxNbAmkaT.e3X9tc6eSxhlwyNKgZHl0rzPnGbadynjvG 6NZKMbsytvRZw2k4GHxAM3nda6VvCX4jWU1Z5zOXSSEq.8LQQD9h7RHwBpMB0fbpJNJ3etHoOrEB I8zmxtxRkiXPqWtf3M.4uyj.Su.RkQdHTp1KY7u7rmE4eb5R7czJ5Zb7JL4S_wvdp9TPUiEVTijB aOoYKidZzKe5BqHGGu0Di7HrFmXjW5XRdAOrjhraxaTwNzk7UT2hqXtkVjB721P4yeVbYLhR6Nxs 3JnqbqOXboLNZMgHNzZ3pWhuvzdJQNoJcEJiTtn9XMU9hYnqRRNQejATihjpxWxhGLMyEuqgchTF R8_HLin1Gfmoa0FiFDjjJqUoSfAZx3k9s6AbXMVduSe9hqDr9qshldSzaLHp5DSFAj2BHA8MsdCh .UGOLCv9uAzOrHQGPVeKFtVtoU3.0oSZhs2m.xeJOmJMh53Zz3jbeyA3N5iYHvuxt.4gO1OLaUKs 4gpyts_A3ScsR5qFvrfFombFx5SZQd4grCVFPUPpOxnoiytivMPwYUI9VZsHFWl2lSGxevl_3r_M yE.J1FhAMUPCPepIAJw5FSPcJF5JPXetAF_YfDjWEz X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic317.consmr.mail.ne1.yahoo.com with HTTP; Fri, 27 Jan 2023 00:44:29 +0000 Original-Received: by hermes--production-sg3-9fc5746c8-nc5k6 (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID c5d5719550fb0c8bee66179615bc2d12; Fri, 27 Jan 2023 00:44:25 +0000 (UTC) In-Reply-To: (Andrew De Angelis's message of "Thu, 26 Jan 2023 18:45:33 -0500") X-Mailer: WebService/1.1.21123 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:254239 Archived-At: Andrew De Angelis writes: > Thanks for the explanation. I sent out the signed copy yesterday. > I noticed a couple things about the previous patch, so I'm sending this one with a few updates: > > * `xwidget-webkit-current-url` in lisp/xwidget.el: check if the url variable is non-nil before calling `kill-new' on it. This avoids killing an empty > string, which would be pointless. We still alert the user that something's wrong by messaging "URL: nil" (although getting a nil url seems > very unlikely). > * in src/nsxwidget.m: formatting (keep lines below 80 char), and a brief comment describing the purpose of some of the newly added > functions > > I'm also attaching a draft of the ChangeLog. Let me know if you'd like me to make any changes there. > > I do have a question about the X11/GTK implementations for xwidget. I'm not sure I understand the relationship between the two: from the > preprocessor macros it seems at times they are separate and at times that one is an addendum to the other. > I'm asking because I want to make sure I'm using the preprocessor macros correctly: specifically, the function > `xwidget-webkit-estimated-load-progress` within xwidget.c used to be inside a "#ifdef USE_GTK" block. I moved it outside of the block, and > separated the GTK implementation from the NS_IMPL_COCOA implementation. Is this a problem for the X11 build? Should I instead put the > whole function within a block along these lines: "#if defined USE_GTK || defined NS_IMPL_COCOA" ? No, that's not a problem. The X11 implementation shares most of the widget manipulation code with the PGTK one, so both are simply under ``#ifdef USE_GTK''.