From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Felician Nemeth Newsgroups: gmane.emacs.bugs Subject: bug#61506: 30.0.50; [PATCH]: Send command in eglot completion exit-function Date: Tue, 14 Feb 2023 16:56:58 +0100 Message-ID: <87pmacjl4l.fsf@betli.tmit.bme.hu> References: <87h6vo1ph6.fsf@thornhill.no> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21458"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Theodor Thornhill , joaotavora@gmail.com To: 61506@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Feb 14 16:58:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pRxhG-0005Pk-DL for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 14 Feb 2023 16:58:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pRxgz-0002dt-1n; Tue, 14 Feb 2023 10:58:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pRxgw-0002dM-Kk for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 10:58:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pRxgw-0000Pn-CZ for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 10:58:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pRxgv-0005eR-UF for bug-gnu-emacs@gnu.org; Tue, 14 Feb 2023 10:58:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Felician Nemeth Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 14 Feb 2023 15:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61506 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61506-submit@debbugs.gnu.org id=B61506.167639022821660 (code B ref 61506); Tue, 14 Feb 2023 15:58:01 +0000 Original-Received: (at 61506) by debbugs.gnu.org; 14 Feb 2023 15:57:08 +0000 Original-Received: from localhost ([127.0.0.1]:56767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRxg4-0005dI-4b for submit@debbugs.gnu.org; Tue, 14 Feb 2023 10:57:08 -0500 Original-Received: from mail-wr1-f48.google.com ([209.85.221.48]:40450) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pRxg2-0005cn-0Z for 61506@debbugs.gnu.org; Tue, 14 Feb 2023 10:57:06 -0500 Original-Received: by mail-wr1-f48.google.com with SMTP id r2so16147968wrv.7 for <61506@debbugs.gnu.org>; Tue, 14 Feb 2023 07:57:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=5E4qEu6GaZY34DLcOV91Hr5fxnfgcGbbW6adoiqLxVg=; b=mGY4Gy+NzQzKSn94mBbu6zzHBAUcAfTccnV8qtR78mE/ic4fNy59/03YPk3NPPqKpe uWxNSJRdhSCWyis3s27/6uiiojeNb+ON4L2Ha9aJ5CPpQkA99Lrh71dotRBsiUwgFGH4 YUCNmw6rcGzwSOEzyNaBVFT2HebPD5i+Qg+ebkaks1zjnQ/vmPTmWoK8CQELN9TiHuMY 0QYw6CwQcZUejuXQtqrZeU5wxuD0vu2wLUj6sRpcMPTNYK0/AYZ0XFcBCkBPSpNUZs3b AizvXYRx1sBxt3hTAUM5OWyjmrIThj6BPsgjxsqFxNr4kaaZkF3PjaRueLbCWCL5SThf HSDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:face:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5E4qEu6GaZY34DLcOV91Hr5fxnfgcGbbW6adoiqLxVg=; b=v5mTTUy2dnIxpLm8JE8mtzqyZq6nvQaQ5xhKp+uAW2uFSKQRzJFg13/h9gWVudWolh 2v4O493+zfgnQn1WhboEHCxNyeD8njz6jawV4R7PwOC0d2cdGmBL0elmuGnEDisc8IvI InK4tJsJuxrNwKQLkIuKGlwMT3F0REoU+6dy8wWMIri/VGy/4+MvbXp0a3CpcdSNymcY kChCwiQneqBXbslDmA1zgncDgzYTg49pGq1C7J8hFMb9LFJqkE+EhCT2kAJV+5UVXdgs ueddw8Xyb+sx2V5Kjpt0H0kyn0MWJc68S27c2bhkaUAbhspy13kVErIpU6hZnjnTzP// K53A== X-Gm-Message-State: AO0yUKXlwHz3a8OAVmZ1IJlw0C63xoAikigJTA6b8nXvLbzKVJyz8Thq eOEu73O7zTOCNkYX7hSku5g= X-Google-Smtp-Source: AK7set8cwNcIcizuv2O6OuaP9nCTcXjE4nsLTRk2jK4OMqE39/SmehCwvqylmCxorSEZ627p4Yr29w== X-Received: by 2002:a5d:4649:0:b0:2c5:557f:93bb with SMTP id j9-20020a5d4649000000b002c5557f93bbmr2684728wrs.10.1676390219966; Tue, 14 Feb 2023 07:56:59 -0800 (PST) Original-Received: from betli.gmail.com (catv-86-101-66-128.catv.fixed.vodafone.hu. [86.101.66.128]) by smtp.gmail.com with ESMTPSA id d12-20020adfe84c000000b002c3f03d8851sm1603351wrn.16.2023.02.14.07.56.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 07:56:59 -0800 (PST) In-Reply-To: <87h6vo1ph6.fsf@thornhill.no> (Theodor Thornhill via's message of "Tue, 14 Feb 2023 12:00:21 +0100") Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwAgMAAAAqbBEUAAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAADFBMVEX5+fmhoaEwMDD/ ///TMNVWAAAAAWJLR0QDEQxM8gAAAAlwSFlzAAAPEgAADxIBIZvyMwAAAAd0SU1FB+AICBUfHgLs gGoAAAGXSURBVCjPRdK/b5tAFAfw753gBEwM2ApMbuVIqf+Ko0qiyhOu4sj2xJBYMn/FUdX7UUUZ OjHgyvf+yj6IcW6Bjx53934ADEvs8bmEr8UVoTYTOyJO9KoYsVofN8kILdbeJ8Li6YpZWop4xOK0 VdfIoXmkHn5/5D7/Ts/8THacSqnkKTcMTxgUkVzFnEIRTKwwYYSCvzfg16f0i8YApW/XG/Pm8R49 dXjxKmRnxv3OwooQWcv4RUYem1fsNe/WU63uk7AmYxk78y32/ee2tZB4fO+WcZ7lnIGEolXW1EGw LfkSuQ0XTgRefgNlfNwRNV6QhBxJ8JNxTMUPyBqTd0bjaAP5G7NJRU39z80hLOZTjqB7K3tEEFSj aEsuQew6qBxxyhHjVUR7H7NpC9iHJZGLMCEuweqAqE1BHbfK2oRIz9EHYA/+wiFWru9smeVfuWNZ 2+NFtX80UA1TvJNdytM4DwO4kY7bJz8Qcd0G0ceslZGkkeoBsjUHwF1+jjM3XHaXEZ7mGLfwPFO+ RV9QLY2iEdmDo78D/gNPaXVYqd+pyQAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAxNi0wOC0wOFQyMzoz MDoyOCswMjowMGy/yHYAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMTYtMDgtMDhUMjM6MzA6MjgrMDI6 MDAd4nDKAAAAAElFTkSuQmCC X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:255607 Archived-At: Hi Theo, > The LSP spec supports an optional command in the completion results, so > that the server can know what completion candidate was selected. That > information can then be used by the server to score candidates for > better completion results etc. Can you list some servers that send this info? And if it is not too much trouble can write a simple recipe where supporting this feature actually makes a difference? Thanks. > This simple patch adds support for this. > I have no strong opinions on _where_ exactly the command should be sent, > as in before or after the didchange notification. The specification only says: "An optional command that is executed *after* inserting this completion." I think it is worth asking for clarification at https://github.com/microsoft/language-server-protocol (I'd guess it's safer to send the command after the didChange notification.)