From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#62459: [PATCH] Have Xref inherit input method when reading identifiers Date: Sun, 26 Mar 2023 22:05:31 +0000 Message-ID: <87pm8v1844.fsf@posteo.net> References: <87jzz33eu2.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62459@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 27 00:06:45 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pgYVg-0009Uk-7q for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 27 Mar 2023 00:06:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pgYV5-00089Z-Cz; Sun, 26 Mar 2023 18:06:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgYV1-00088j-UU for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 18:06:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pgYV1-0005PS-Lz for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 18:06:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pgYV1-0000M0-Fz for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 18:06:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 22:06:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62459 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 62459-submit@debbugs.gnu.org id=B62459.16798683411289 (code B ref 62459); Sun, 26 Mar 2023 22:06:03 +0000 Original-Received: (at 62459) by debbugs.gnu.org; 26 Mar 2023 22:05:41 +0000 Original-Received: from localhost ([127.0.0.1]:46040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgYUf-0000Kj-0E for submit@debbugs.gnu.org; Sun, 26 Mar 2023 18:05:41 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:44869) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgYUc-0000KQ-VH for 62459@debbugs.gnu.org; Sun, 26 Mar 2023 18:05:39 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id F072824012D for <62459@debbugs.gnu.org>; Mon, 27 Mar 2023 00:05:32 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1679868333; bh=bcn3fxwfVP06isbXSgwDWlZdteah+eJPOKbAWD93Ujk=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=iIG6tKklTYiGL5UmJPvgs8kTq39/uEar0cJxP8CmzVtSBTZ/hzhXA5RkpX1ppyNit NZf9j4J9j5KT+U7Ebig3n/0p/n9n8q818+H12Fnc7wyl7JrIn4yOWQQLKYpQrFrpts RMb/AGAelzvGoB7B7xacoNRVcfFiz6cixh+NVqocff9NDHiBetSnY2ef37d2RFq774 DEy4yLWq3YXmFw7rcTVx4DqYs9Qa/0kyq1kIPZ1fjzbI/5eUpyYWJ7WeCV91NXueXx +kca4XAGJJr+I8ZqBWMqS5aAocJpCZBc4BgdqdVfyMzJgaz8dQyEut7qGtGuSFDHKe I4oCqQrl6kEOQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Pl94D3ghbz9rxG; Mon, 27 Mar 2023 00:05:32 +0200 (CEST) In-Reply-To: (Dmitry Gutov's message of "Sun, 26 Mar 2023 22:04:22 +0300") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:258702 Archived-At: Dmitry Gutov writes: > On 26/03/2023 14:57, Philip Kaludercic wrote: >> Certain languages rely heavily on input methods (two examples I have >> encountered are APL and Agda), and the default behaviour of Xref when >> prompting an identifier can be annoying since the user is required to >> manually enable the input method, if they want to look up an identifier >> that contains "non-ASCII" characters. For that reason I think it should >> be OK to set the INHERIT-INPUT-METHOD argument when calling >> `completing-read'. > > Sure. If you see the improvement from this, please go ahead. OK, I'll push it to master. -- Philip Kaludercic