From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#62762: 'make' often errors with "Org version mismatch" after pulling a new version of the code Date: Sun, 23 Apr 2023 09:21:10 +0000 Message-ID: <87pm7vt0mx.fsf@localhost> References: <17b74a48-94e1-9106-cc79-d31972313910@gutov.dev> <837cujaqzq.fsf@gnu.org> <87wn2ilwed.fsf@localhost> <83zg7ealrd.fsf@gnu.org> <87pm8a8dx4.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5149"; mail-complaints-to="usenet@ciao.gmane.io" Cc: bzg@gnu.org, dmitry@gutov.dev, Eli Zaretskii , 62762@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Apr 23 11:19:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pqVsO-00015J-HY for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 23 Apr 2023 11:19:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pqVs8-0000v3-5p; Sun, 23 Apr 2023 05:19:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqVs6-0000ug-I2 for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2023 05:19:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pqVs6-00023d-9a for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2023 05:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pqVs5-0006kZ-RV for bug-gnu-emacs@gnu.org; Sun, 23 Apr 2023 05:19:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Apr 2023 09:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62762 X-GNU-PR-Package: emacs Original-Received: via spool by 62762-submit@debbugs.gnu.org id=B62762.168224150825901 (code B ref 62762); Sun, 23 Apr 2023 09:19:01 +0000 Original-Received: (at 62762) by debbugs.gnu.org; 23 Apr 2023 09:18:28 +0000 Original-Received: from localhost ([127.0.0.1]:44622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqVrX-0006jg-NN for submit@debbugs.gnu.org; Sun, 23 Apr 2023 05:18:28 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:57383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqVrV-0006jP-64 for 62762@debbugs.gnu.org; Sun, 23 Apr 2023 05:18:26 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 50915240110 for <62762@debbugs.gnu.org>; Sun, 23 Apr 2023 11:18:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1682241499; bh=RYRGCpdx6S4609EvkKkmcSfROXedXXMJxMTFFFPeuXY=; h=From:To:Cc:Subject:Date:From; b=fLl/XO9tll8NcbGOdvcvyhQX1i673/r6poqVugI8bXK1MI3ZePN7e1ejhJ9mnePO5 ARiCI3xNp6sDx6xSg7kl88FkyjFc8ITuLhiCK9l3ZyKPd65ThStanYdn7HGEVPP2nT uwhWZAz5/fWa2MAueZ39JOvb2v69bYPtU/LWxmvVm7trqhd9lKD5aHyHqvDShX6tj0 zttSRTJQihC2bNaJd9g/YpDi3CpG2VnQcCmrEYKE3SYk0KXEzWWPuArYOcAqxhXFaV cupefD7Ai5ihNC6T5JwzzqNtMpXga4a86HkfYhBbEcozxqhYvsKiB9Hm8//XI9YM9S jzU6Jc2MdTyZQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Q42k22Brnz6tvy; Sun, 23 Apr 2023 11:18:18 +0200 (CEST) In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:260501 Archived-At: Stefan Monnier writes: >> I don't. Say, why not to store hash of the macro sources in the byte >> code and verifying the hash when re-compilation is requested? Though I >> am not that much familiar with Emacs source compilation. > > In theory it's possible. Nobody has worked on it :-) > Note that it's not just macros but defsubsts as well. ... and other define-inlines. >> Sure, in the context of Emacs compilation. The code in question is >> mostly aiming at newer Org installed on top of built-in Org. We are >> consistently getting issues related to incorrect macro expansion and >> mixing different Org versions. > > Someone=E2=84=A2 *really* needs to sit down and fix the underlying proble= m in > `package.el`. The current "solution" in `package.el` *should* work (it > should reload the new `org-macs.el` on top of the old one, which > I think should avoid all the problems seen in practice for Org), so it > seems we just have a plain bug in the implementation of our "solution". > [ Which is good: it should be simple to fix, compared to trying to come > up with another solution. ] AFAIK, the current re-loading approach in package.el does help. But not all the Org users are using that new Emacs versions. And not all the Org users are using package.el. >> What we might do to work around the problem is detecting Emacs compilati= on >> and disable the check. Is there a way to detect that Emacs source is >> being compiled from Elisp? > > This sounds like adding more brittle hacks on top of brittle hacks. Sure. But I really have no better ideas, especially considering backward compatibility requirements down to Emacs 26. >> No. We originally tested by commit hash. Version string check is a >> trade-off between the problem with ELPA builds (see the links in my >> previous message) and the need to detect mixed installation problems. > > BTW, have you tried to use a test along the lines of: look through > `load-history` to see if we loaded org-* files from a different directory > than the one in which `load-file-name` resides? Yup. Several problems here: 1. Not all the org-* files are a part of Org. 2. This will completely block the possibility for users to provide custom versions of Org libraries, when they need to. 3. We actually have `org-version' that is using this approach to indicate problems without blocking staff, but it still misses many cases. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at