unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Thuna <thuna.cing@gmail.com>
Cc: 61546@debbugs.gnu.org, Stefan Kangas <stefankangas@gmail.com>
Subject: bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer'
Date: Tue, 02 May 2023 11:38:40 +0000	[thread overview]
Message-ID: <87pm7jdku7.fsf@localhost> (raw)
In-Reply-To: <87r0uq2los.fsf@gmail.com>

Thuna <thuna.cing@gmail.com> writes:

> Some code in org seems to break when calendar-buffer is modified, as
> they rely on it being its default value, "*Calendar*".  The attached
> patch fixes that.  I haven't tested it, however, it should work fine.
> The `require's all seem correct as well.

I now applied an equivalent patch onto main in Org.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=9ea50ca21

Stefan, please note that part of the patch is for Emacs:

test/lisp/calendar/cal-julian-tests.el

> diff --git a/test/lisp/calendar/cal-julian-tests.el b/test/lisp/calendar/cal-julian-tests.el
> index e0d74e8a6cd..4207d1ee285 100644
> --- a/test/lisp/calendar/cal-julian-tests.el
> +++ b/test/lisp/calendar/cal-julian-tests.el
> @@ -47,7 +47,7 @@ with-cal-julian-test
>           (progn
>             (calendar)
>             ,@body)
> -       (kill-buffer "*Calendar*"))))
> +       (kill-buffer calendar-buffer))))
>  
>  (ert-deftest cal-julian-test-goto-date ()
>    (with-cal-julian-test
> -- 
> 2.38.2
>

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>





  parent reply	other threads:[~2023-05-02 11:38 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16  6:01 bug#61546: [PATCH] Fix some org functionality breaking upon changing `calendar-buffer' Thuna
2023-02-16  9:24 ` Stefan Kangas
2023-02-16  9:35   ` Thuna
2023-02-16  9:57     ` Ihor Radchenko
2023-02-16 10:02       ` Thuna
2023-02-16 10:17         ` Ihor Radchenko
     [not found]         ` <87v8k13of6.fsf@localhost>
2023-02-28  9:28           ` Bastien Guerry
2023-05-02 11:38 ` Ihor Radchenko [this message]
2023-05-02 18:04   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pm7jdku7.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=61546@debbugs.gnu.org \
    --cc=stefankangas@gmail.com \
    --cc=thuna.cing@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).