From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#60936: 30.0.50; ERC >5.5: Add erc-fill style based on visual-line-mode Date: Tue, 30 May 2023 07:14:50 -0700 Message-ID: <87pm6h7vol.fsf__11055.9956797928$1685456230$gmane$org@neverwas.me> References: <87tu0nao77.fsf@neverwas.me> <87fs7p3sk6.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="421"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-erc@gnu.org To: 60936@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue May 30 16:17:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q409l-000AQ3-UZ for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 30 May 2023 16:17:02 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q409P-0000f3-Rf; Tue, 30 May 2023 10:16:39 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q408q-0000MY-Pe for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 10:16:12 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q408p-00084C-18 for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 10:16:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q408o-0008Vl-HC for bug-gnu-emacs@gnu.org; Tue, 30 May 2023 10:16:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2023 14:16:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60936 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60936-submit@debbugs.gnu.org id=B60936.168545611032637 (code B ref 60936); Tue, 30 May 2023 14:16:02 +0000 Original-Received: (at 60936) by debbugs.gnu.org; 30 May 2023 14:15:10 +0000 Original-Received: from localhost ([127.0.0.1]:33727 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q407x-0008UK-KP for submit@debbugs.gnu.org; Tue, 30 May 2023 10:15:10 -0400 Original-Received: from mail-108-mta86.mxroute.com ([136.175.108.86]:42331) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q407s-0008TP-12 for 60936@debbugs.gnu.org; Tue, 30 May 2023 10:15:07 -0400 Original-Received: from mail-111-mta2.mxroute.com ([136.175.111.2] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta86.mxroute.com (ZoneMTA) with ESMTPSA id 1886d02fed600074ee.001 for <60936@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 30 May 2023 14:14:52 +0000 X-Zone-Loop: 5fa44a7fcd2c2af48ef7c4123174566b0f4e9d4aa52e X-Originating-IP: [136.175.111.2] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Type:MIME-Version:Message-ID:Date:References:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=XT9uRQ7+Ui4CWVGUIJpU65ydC6qxHeU8Eh4M3/eXgrQ=; b=amXm54BO677XJJmIhtpGVDO4oy s6gWmqzXBHxZ0FpnCMUtP88qE93F4RFXhdhm6RLAskvo0dgVdmr8PItVHI5Qp4Cv0PJUwnURdHAwm JaOmaCnNMfX1LdMJDcGUYj0X+mYM4x+Q/gK/UFlJ1XbofyydZwMHocfbTQdawLAN2uZ7oGbjFpIkE VKKJ/VzCMF4vhP/7+/oPkCWZoKUujsocnLjKOM04ds+cVV/UaGiqofakCHAkG4jktpnpxmbX31MkY QUwz2mL9Z+UgtsZc2ye1M2ytJ++N0LD1yYqn2Z+R/N5RC0ThU3wcfAqc6LsCVzkX+SoB/018p6SJP zIJLvTMg==; In-Reply-To: <87fs7p3sk6.fsf@neverwas.me> (J. P.'s message of "Sun, 21 May 2023 21:20:57 -0700") X-Authenticated-Id: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262632 Archived-At: "J.P." writes: > The following commit introduced a regression: > > commit 05f6fdb9e7893329baff675bd31fb36ad64c756d > Author: F. Jason Park > > [...] > > The attached patch fixes the regression and changes the behavior to > redraw the prompt on every incoming message as well, but only when > `erc-prompt' is a function. I've added this as commit 4f93c52f7fd1b7c5f75a0d049e5a1015a268265a Recompute erc-prompt when inserting messages lisp/erc/erc.el | 16 ++++++++++-- test/lisp/erc/erc-tests.el | 99 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 113 insertions(+), 2 deletions(-) along with commit 31a80f61ec03bcbb79720c0dc640272aba160865 (origin/master) Preserve prompt in erc-cmd-CLEAR etc/ERC-NEWS | 11 ++++ lisp/erc/erc-log.el | 17 ++++-- lisp/erc/erc-stamp.el | 16 +++++ lisp/erc/erc-truncate.el | 21 +++---- lisp/erc/erc.el | 9 ++- test/lisp/erc/erc-scenarios-log.el | 207 ++++++++++++++++++++++++++++++ 6 files changed, 264 insertions(+), 17 deletions(-) which fixes a bug affecting the /CLEAR command. It was introduced by 05f6fdb9e78 "Preserve ERC prompt and its bounding markers" and pointed out by incal on IRC. Some background: For almost two decades, `erc-cmd-CLEAR' was simply defined as (recenter 0) However, in 2019, it was changed to destructively truncate the current buffer, something traditionally (though perhaps inadequately) provided by the command `erc-save-buffer-in-logs' in concert with the option `erc-truncate-buffer-on-save'. It happens that 05f6fdb9e78 "Preserve" also introduced a regression affecting the latter option, which has always suffered from an awkward implementation and insufficient documentation (and, consequently, poor discoverability). In addition to restoring its functionality, I've also deprecated it because of the inherent confusion surrounding its usage and, to a lesser degree, because it's redundant (/CLEAR now does the exact same thing). If anyone thinks this rash or unwarranted, please say so. Thanks.