From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Augusto Stoffel Newsgroups: gmane.emacs.bugs Subject: bug#64406: [PATCH] Improve commands to manage Python imports Date: Fri, 07 Jul 2023 19:02:27 +0200 Message-ID: <87pm534puk.fsf@gmail.com> References: <874jmnbd5v.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16505"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 64406@debbugs.gnu.org To: Matthias Meulien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jul 07 19:03:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qHorT-00045Q-80 for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 07 Jul 2023 19:03:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qHorI-0003Jw-Ao; Fri, 07 Jul 2023 13:03:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qHorG-0003Ir-Kp for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 13:03:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qHorG-00042w-Cb for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 13:03:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qHorF-0004Gc-V2 for bug-gnu-emacs@gnu.org; Fri, 07 Jul 2023 13:03:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 07 Jul 2023 17:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64406 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 64406-submit@debbugs.gnu.org id=B64406.168874936216376 (code B ref 64406); Fri, 07 Jul 2023 17:03:01 +0000 Original-Received: (at 64406) by debbugs.gnu.org; 7 Jul 2023 17:02:42 +0000 Original-Received: from localhost ([127.0.0.1]:43687 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHoqw-0004G4-Ej for submit@debbugs.gnu.org; Fri, 07 Jul 2023 13:02:42 -0400 Original-Received: from mail-ej1-f54.google.com ([209.85.218.54]:44341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qHoqq-0004Fn-DD for 64406@debbugs.gnu.org; Fri, 07 Jul 2023 13:02:40 -0400 Original-Received: by mail-ej1-f54.google.com with SMTP id a640c23a62f3a-992af8b3b1bso263538666b.1 for <64406@debbugs.gnu.org>; Fri, 07 Jul 2023 10:02:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688749350; x=1691341350; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=RET7HxsipvvxOfuHGOBI51tK5NzfbE1ks8EFxYWcAFY=; b=sog7VtVA9bXu8IqAaAZE5Yn8RPdeC9BdnAjkheOJBn3cNzzIGuLtjXKCpy9wG3Vhyi i3QvgBsEeuPFPR9zIjBCwnuEg5g2fpvY2KYJVIV1TKlSiitwQlVW7TQ0KzDSz+Bbrkfa xSnF7QvffXM/gq+NmvdlIcpHPXGdsCwtAiTPQMpNTugp+MJuTZhahzj6cMo10DXSqmK+ Q6YCffyAAHgOQuG4TjX8eHmVBlXTesC2Jx7TFDJoEAncFT0obv7bj1lKKusig8rhWsbl YIZyBCXixxcc/uQKnj42EPZUHV5SfIkp0RoqL3gPL7czjcsoQaPYhO0t1uYyDNoUMRtI Q6Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688749350; x=1691341350; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RET7HxsipvvxOfuHGOBI51tK5NzfbE1ks8EFxYWcAFY=; b=Umk6xFmPXANUfx+4D/kLZ5GMCkDbiKOaIa2kJyRkXFmecdm9E01S7adqdLvuaD0vTo TLs+AJpuHFx540YlGY/O4NtMcdr+8/MmEOpY/KqI4/fTJhz2iJxM305W2Yq/Gv6nRLDl HmgNQkp367lHJ4Y4Q6jlsGHDycrQJ6HzGg2CfhnA0RmmIc9Z5FAS5u9I3Q5IEjfB49CS X8bYl1AqPBqIl/dNUf5QbfwZipfct89OFIkqd7fxzdSbpW7EGI/jfddxRb8JJjujT+cZ mlFPCeSsJ8a7B08piVv44a5jugLzNrK+am0ndsjYLx2yVp7BY3FEsCCX3ZLwgiDGkrEv QJDg== X-Gm-Message-State: ABy/qLZeSrT8xAa3GPjSrp4fUl3KqNR3BLXrnWNXxMsYzdq3ngFV/Yfb SQwzQrw6/J5KwV4Akgnnu0JD+F8NGp8= X-Google-Smtp-Source: APBJJlE7Q11QzN8sODp/xcS09/aZkLz9K1xLreJ7F85jR9RoJZ5zIeMdi3//Y7Px6xbT8qINCCw4QQ== X-Received: by 2002:a17:907:1246:b0:982:ab8d:1e08 with SMTP id wc6-20020a170907124600b00982ab8d1e08mr3876854ejb.59.1688749349908; Fri, 07 Jul 2023 10:02:29 -0700 (PDT) Original-Received: from ars3 ([2a02:8109:8ac0:6098::72ff]) by smtp.gmail.com with ESMTPSA id gt4-20020a170906f20400b009935aba3a9dsm2380529ejb.48.2023.07.07.10.02.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 10:02:29 -0700 (PDT) In-Reply-To: <874jmnbd5v.fsf@gmail.com> (Matthias Meulien's message of "Sat, 01 Jul 2023 22:16:28 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:264737 Archived-At: On Sat, 1 Jul 2023 at 22:16, Matthias Meulien wrote: > -from sys import argv, stdin > +from sys import argv, exit, stdin FWIW, exit is already in the global namespace. > - (unless (eq 0 status) > + (cond > + ((eq 1 status) > (error "%s exited with status %s (maybe isort is missing?)" > python-interpreter status)) > + ((eq 2 status) > + (error "%s exited with status %s (maybe isort version is <5.7.0?)" > + python-interpreter status))) This change implies that the "success" branch may run if the exit code is nonzero (without knowing all the isort internals, it can't be excluded that an exit code > 2 is used somewhere). I suggest instead a (pcase status ...) to construct the " (maybe... ?)" segment of the error message. We could also take this opportunity to distinguish between random exceptions happening in the script (which likely leads to exit code 1) and the ModuleNotFoundError case.