From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#65286: 30.0.50; package-install-file for built-in package Date: Mon, 14 Aug 2023 14:15:07 +0000 Message-ID: <87pm3pyal0.fsf@posteo.net> References: <87o7j9q1nk.fsf@localhost> <87fs4livaf.fsf@posteo.net> <87fs4lpvqv.fsf@localhost> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2632"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65286@debbugs.gnu.org To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Aug 14 16:16:20 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qVYMk-0000Vo-LR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 14 Aug 2023 16:16:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qVYMW-00045X-KX; Mon, 14 Aug 2023 10:16:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qVYMU-0003xu-9A for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 10:16:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qVYMU-0002uM-0Z for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 10:16:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qVYMT-0006fl-Kv for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2023 10:16:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 14 Aug 2023 14:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65286 X-GNU-PR-Package: emacs Original-Received: via spool by 65286-submit@debbugs.gnu.org id=B65286.169202251825598 (code B ref 65286); Mon, 14 Aug 2023 14:16:01 +0000 Original-Received: (at 65286) by debbugs.gnu.org; 14 Aug 2023 14:15:18 +0000 Original-Received: from localhost ([127.0.0.1]:34100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVYLl-0006en-IV for submit@debbugs.gnu.org; Mon, 14 Aug 2023 10:15:18 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:40045) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qVYLj-0006eY-HK for 65286@debbugs.gnu.org; Mon, 14 Aug 2023 10:15:16 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5268E240101 for <65286@debbugs.gnu.org>; Mon, 14 Aug 2023 16:15:09 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1692022509; bh=zLQMDR+u9WXaQX0jKbegBKVzBIQyDI0BEbaFP7lNQUU=; h=From:To:Cc:Subject:Autocrypt:Date:Message-ID:MIME-Version:From; b=hvLRsK4s7qpIcx7hm74DFl12OsabmSdE2iHkFlCy/OSWpJx1y3YoJOy2gCgmg2g92 rRge55fenkDpspB1Mg8o8w+UnBYxG6P2hP3W5kYeRcmE7Pzh9+ubUuLkdlcEkaxri+ 3J0fg9B+YXZuA55Js+jHOrPnQDJyKhLzf5VDL2AG7obNgu7PdUTZHWxeK3+irxxgNl eKBU1RkcJVAFHK0z5VJgclK5fxSDGHiwHZqejx3P0dqCfimsLlwE+WtxusdmogGsMg RBl5SkT71nRbpw62OwifBN3HrY0ryRcDRRuZKKv9hZFjR0H0n6q9wVP+46cYUAD7s3 LnWOlME3Z3Gjg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RPbyN5gfPz9rxL; Mon, 14 Aug 2023 16:15:08 +0200 (CEST) In-Reply-To: <87fs4lpvqv.fsf@localhost> (Ihor Radchenko's message of "Mon, 14 Aug 2023 14:02:48 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267420 Archived-At: --=-=-= Content-Type: text/plain Ihor Radchenko writes: > Philip Kaludercic writes: > >>> Also, keeping elpa directory around between the tests triggers various failures. >> >> Are you sure that this is not an issue related to org-mode? > > It might be. But the difference between package-install-file w/without > built-in Org loaded is unlikely Org's fault in any case. For the record, these are the changes between your checkout and what is on master: --=-=-= Content-Type: text/plain Content-Disposition: inline diff -u /tmp/org-mode/lisp/ob-gnuplot.el /home/philip/Source/emacs/lisp/org/ob-gnuplot.el --- /tmp/org-mode/lisp/ob-gnuplot.el 2023-08-14 16:10:37.615919936 +0200 +++ /home/philip/Source/emacs/lisp/org/ob-gnuplot.el 2023-04-05 22:53:26.932222097 +0200 @@ -3,7 +3,7 @@ ;; Copyright (C) 2009-2023 Free Software Foundation, Inc. ;; Author: Eric Schulte -;; Maintainer: Ihor Radchenko +;; Maintainer: Ihor Radchenko ;; Keywords: literate programming, reproducible research ;; URL: https://orgmode.org @@ -40,9 +40,11 @@ ;;; Code: -(require 'ob-9.7 "ob") -(require 'org-macs-9.7 "org-macs") -(require 'ox-ascii-9.7 "ox-ascii") +(require 'org-macs) +(org-assert-version) + +(require 'ob) +(require 'org-macs) (declare-function org-time-string-to-time "org" (s)) (declare-function orgtbl-to-generic "org-table" (table params)) @@ -196,7 +198,7 @@ (defun org-babel-execute:gnuplot (body params) "Execute a block of Gnuplot code. This function is called by `org-babel-execute-src-block'." - (org-require-package 'gnuplot) + (require 'gnuplot) (let ((session (cdr (assq :session params))) (result-type (cdr (assq :results params))) (body (org-babel-expand-body:gnuplot body params)) @@ -260,7 +262,7 @@ If there is not a current inferior-process-buffer in SESSION then create one. Return the initialized session. The current `gnuplot-mode' doesn't provide support for multiple sessions." - (org-require-package 'gnuplot) + (require 'gnuplot) (unless (string= session "none") (save-window-excursion (gnuplot-send-string-to-gnuplot "" "line") @@ -293,33 +295,17 @@ (require 'ox-org) (with-temp-file data-file (insert (let ((org-babel-gnuplot-timestamp-fmt - (or (plist-get params :timefmt) "%Y-%m-%d-%H:%M:%S")) - ;; Create custom limited backend that will disable - ;; advanced ASCII export features that may alter the - ;; original data. - (ob-gnuplot-data - (org-export-create-backend - :parent 'ascii - :transcoders - `(;; Do not try to resolve links. Export them verbatim. - (link . (lambda (link _ _) (org-element-interpret-data link))) - ;; Drop emphasis markers from verbatim and code. - ;; This way, data can use verbatim when escaping - ;; is necessary and yet be readable by Gnuplot, - ;; which is not aware about Org's markup. - (verbatim . (lambda (verbatim _ _) (org-element-property :value verbatim))) - (code . (lambda (code _ _) (org-element-property :value code))))))) + (or (plist-get params :timefmt) "%Y-%m-%d-%H:%M:%S"))) (orgtbl-to-generic table (org-combine-plists - `( :sep "\t" :fmt org-babel-gnuplot-quote-tsv-field + '( :sep "\t" :fmt org-babel-gnuplot-quote-tsv-field ;; Two setting below are needed to make :fmt work. :raw t - :backend ,ob-gnuplot-data) + :backend ascii) params))))) data-file) (provide 'ob-gnuplot) -(provide 'ob-gnuplot-9.7) ;;; ob-gnuplot.el ends here Diff finished. Mon Aug 14 16:12:51 2023 --=-=-= Content-Type: text/plain The (org-assert-version) seems new, with this check `(unless (or org--inhibit-version-check (equal (org-release) ,(org-release))) ... could evaluating (org-release) during macro-expansion cause this recursive load issue? >> Could you create a minimal working example to reproduce this issue, by >> removing as much as possible from the repository while retaining the >> issue, and then send us a tarball with the remaining files? > > Sorry, but the issue is triggered by interaction between built-in and > non-built-in Org. I have no idea if it is possible at all to create more > minimal reproducer. > To be clear, I have no clue at all what is going on. I made some > relatively innocent changes in Org that added a couple of provide > statements. I could see things breaking completely, but not __only__ > when built-in Org is loaded. So, any attempt to reduce the reproducer > steps will be me trying random things - not very productive unless you > absolutely cannot use the reproducer I provided. No, sorry I couldn't reproduce it on my system :/ M-x emacs-version GNU Emacs 30.0.50 (build 5, x86_64-pc-linux-gnu, GTK+ Version 3.24.37, cairo version 1.16.0) of 2023-08-14 --=-=-=--