From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.bugs Subject: bug#65734: [BUG] kill-whole-line on folded subtrees [9.6.8 (release_9.6.8-3-g21171d @ /home/w/usr/emacs/0/29/0/lisp/org/)] Date: Thu, 07 Sep 2023 10:00:49 +0000 Message-ID: <87pm2upajy.fsf__27226.7338282958$1694080880$gmane$org@localhost> References: <87il8pao4l.fsf@whxvd.name> <87tts8vrpb.fsf@localhost> <83h6o84yz1.fsf@gnu.org> <87ledju2j7.fsf@localhost> <837cp3333w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40134"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65734@debbugs.gnu.org, emacs-orgmode@gnu.org, iota@whxvd.name To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 07 12:01:12 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeBp2-000AFQ-7Q for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 07 Sep 2023 12:01:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeBos-0004oi-LJ; Thu, 07 Sep 2023 06:01:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeBoq-0004n9-Lg for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 06:01:00 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeBoq-0002LF-BW for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 06:01:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeBor-0004ms-U7 for bug-gnu-emacs@gnu.org; Thu, 07 Sep 2023 06:01:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ihor Radchenko Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 07 Sep 2023 10:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65734 X-GNU-PR-Package: emacs Original-Received: via spool by 65734-submit@debbugs.gnu.org id=B65734.169408081118310 (code B ref 65734); Thu, 07 Sep 2023 10:01:01 +0000 Original-Received: (at 65734) by debbugs.gnu.org; 7 Sep 2023 10:00:11 +0000 Original-Received: from localhost ([127.0.0.1]:38661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeBo3-0004lF-Bu for submit@debbugs.gnu.org; Thu, 07 Sep 2023 06:00:11 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:44037) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeBnz-0004iu-63 for 65734@debbugs.gnu.org; Thu, 07 Sep 2023 06:00:10 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7EA4C240028 for <65734@debbugs.gnu.org>; Thu, 7 Sep 2023 11:59:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1694080799; bh=pDBywziPeDpCyUSqOC29KuXs9vFTktph2IkJ+AG+lZU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:From; b=ozw1ZSp/zJv+P5D5yFx02oyI3sfIogXTNahYFAE3Rlz+wM8unKEgJfX3faGv1zJYd 8FgZ4/DXbafxwR1wunlE+GdR2vbaAk4u6IHooRb4GjF5mOXE2QcalZRpquO/n1s2IM vH47BuJ+nLKi6DpuLtRjsk3tTG5dM4SUGmxrdzg5RlSA7r08ZDGnNL6VyOH0bfWwlw B9z/dsL4yTXlvtMLh8mRE8EAFjAqufzcBPOjzaBA2xv3u5Cyb0Nvpt7sE+bCqliwvS cL9lYSpSBJCjrPon1kmk9TMc1qFzR9N2WaNrD3NGky0y0gm25kYKzzjD5+ZOB5HqPZ HGRB5U9gQBHXQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4RhF8t5nVCz6tsg; Thu, 7 Sep 2023 11:59:58 +0200 (CEST) In-Reply-To: <837cp3333w.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269634 Archived-At: Eli Zaretskii writes: >> >> In addition, `org-kill-line' acts specially in certain scenarios: >> >> >> >> For >> >> * Heading text :tag1:tag2: >> >> >> >> `org-kill-line' will keep and re-align ":tag1:tag2:": >> >> >> >> * Heading :tag1:tag2: >> >> >> >> It would be nice if we could express such behavior without overriding >> >> the `kill-line' command. >> ... >> I am not sure if I like the idea of text property - marking all the tags >> in buffer with text property is expensive. > > Then perhaps just a special value for buffer-invisibility-spec, or > some other simple variation of a property Org already uses? We may have a misunderstanding here. In "* Heading text :tag1:tag2:", everything is visible yet Org needs to protect ":tag1:tag2: from being killed by `kill-line', but not from `kill-whole-line'. Moreover, the behaviour also depends on the point position - if point is inside ":tag1:tag2:", we fall back to the default behaviour. And the whole "special" behaviour can also be switched off by flipping `org-special-ctrl-k'. Invisibility has nothing to do with this need. >> What about something like `end-of-visible-line-function'? > > That is also a possibility, but it will then affect kill-line > _anywhere_ in the buffer, whereas a text property can have a more > localized effect. Are you sure kill-line will need this customization > on the whole buffer? Applying text property is not free - (1) we need to do it across the whole buffer, which scales poorly; (2) we need to keep it updated as the buffer changes, which scales even worse. In addition, adding more text properties slow down redisplay, which Org already strains to its limits. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at