From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#67882: 29.1.90; Registers' preview can delete existing window when finishing Date: Mon, 08 Jan 2024 14:36:37 +0000 Message-ID: <87plyb7uyy.fsf@posteo.net> References: <34a9ba4a-a91f-7b3b-9cfd-9d0a56dfcd82@gutov.dev> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32892"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67882@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Jan 08 15:37:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rMqkj-0008MN-KR for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 08 Jan 2024 15:37:21 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rMqkL-00060Y-NJ; Mon, 08 Jan 2024 09:36:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rMqkK-00060F-Hf for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 09:36:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rMqkK-0007AY-3a for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 09:36:56 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rMqkQ-00021z-3S for bug-gnu-emacs@gnu.org; Mon, 08 Jan 2024 09:37:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 08 Jan 2024 14:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67882 X-GNU-PR-Package: emacs Original-Received: via spool by 67882-submit@debbugs.gnu.org id=B67882.17047246217800 (code B ref 67882); Mon, 08 Jan 2024 14:37:02 +0000 Original-Received: (at 67882) by debbugs.gnu.org; 8 Jan 2024 14:37:01 +0000 Original-Received: from localhost ([127.0.0.1]:35576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMqkP-00021k-0o for submit@debbugs.gnu.org; Mon, 08 Jan 2024 09:37:01 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:54327) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rMqkI-00021G-Nf for 67882@debbugs.gnu.org; Mon, 08 Jan 2024 09:36:58 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id B6416240103 for <67882@debbugs.gnu.org>; Mon, 8 Jan 2024 15:36:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1704724601; bh=vbvOeu1SJiU6HFKuYeHnKJ/lP5aVX0iLBCCG9RmtXMM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP: From; b=fgfRGj4Bls8RjA2DfnZnMtlqaAD4nlEWz9sRPn2Y0R/2pkzzrfkc2gO+GPVYXuR3d p2i/uF1+URRd5oDTx378tf8vFPEfzRbN2fZnG2Uvk9soKkuLkg2IfmprOz0lNWlu+E 6CEDNJ678+6KM8p0vyDMc/IHMHa/ZSEtspWX+hp4MV+MUd/D+qZgShjd0+EQycS37z W3LyhhD2Ok2qJ1AHBY9M8XEIIFn0Gbr8G9Ah1+UMxabiU5iPV1E7132M8ieiw4PWNi KVhUbR1UxatbjMEQ7P4ZlhRM18ZcVC/06IHvo3eEJ6u4+p94g1itqz+ahPezCxiax6 FfnDfFOlj6Z5g== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4T7xTM6yYrz6ty0; Mon, 8 Jan 2024 15:36:39 +0100 (CET) In-Reply-To: <34a9ba4a-a91f-7b3b-9cfd-9d0a56dfcd82@gutov.dev> (Dmitry Gutov's message of "Mon, 18 Dec 2023 20:18:55 +0200") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:277560 Archived-At: --=-=-= Content-Type: text/plain Hello Dmitry, is the attached patch fix this issue for you? Thanks. Dmitry Gutov writes: > Set up: > > (defun split-window-prefer-side-by-side (&optional window) > (let ((split-height-threshold (and (< (window-width window) > split-width-threshold) > split-height-threshold))) > (split-window-sensibly window))) > > (setq split-window-preferred-function 'split-window-prefer-side-by-side) > > Split the frame, e.g. 'C-x 3'. > > Then create some register (e.g. using 'C-x r C-@') and then invoke > another command reading it. E.g. 'C-x r j'. > > Wait the necessary 1 second for the preview to appear - it will use one > of the existing windows to show the list of registers. > > Then, whether you choose the register, or C-g out of the choice, the > window used to display the list will be deleted. > > Previously mentioned in bug#66394. > > Not a regression on master, just reproduced it in 29. > > > > -- Thierry --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-window-setting-in-register-preview-bug-67882.patch >From b39ffa6e1db2577ecf3b265ccdcc50b102ee13b7 Mon Sep 17 00:00:00 2001 From: Thierry Volpiatto Date: Tue, 26 Dec 2023 17:49:34 +0100 Subject: [PATCH 1/2] Fix window setting in register preview (bug#67882) and allow configuring it if needed. * lisp/register.el (register-preview-display-buffer-alist): New user var. (register-preview,register-preview-1): Use it. --- lisp/register.el | 31 ++++++++++++++++--------------- 1 file changed, 16 insertions(+), 15 deletions(-) diff --git a/lisp/register.el b/lisp/register.el index baad2c2a05d..f5b0365dec2 100644 --- a/lisp/register.el +++ b/lisp/register.el @@ -386,18 +386,21 @@ Format of each entry is controlled by the variable `register-preview-function'." (setq register-preview-function (register--preview-function register--read-with-preview-function))) (when (or show-empty (consp register-alist)) - (with-current-buffer-window - buffer - (cons 'display-buffer-below-selected - '((window-height . fit-window-to-buffer) - (preserve-size . (nil . t)))) - nil - (with-current-buffer standard-output - (setq cursor-in-non-selected-windows nil) - (mapc (lambda (elem) - (when (get-register (car elem)) - (insert (funcall register-preview-function elem)))) - register-alist))))) + (with-current-buffer-window buffer + register-preview-display-buffer-alist + nil + (with-current-buffer standard-output + (setq cursor-in-non-selected-windows nil) + (mapc (lambda (elem) + (when (get-register (car elem)) + (insert (funcall register-preview-function elem)))) + register-alist))))) + +(defcustom register-preview-display-buffer-alist '(display-buffer-at-bottom + (window-height . fit-window-to-buffer) + (preserve-size . (nil . t))) + "Window configuration for the register preview buffer." + :type display-buffer--action-custom-type) (defun register-preview-1 (buffer &optional show-empty types) "Pop up a window showing the preview of registers in BUFFER. @@ -415,9 +418,7 @@ Format of each entry is controlled by the variable `register-preview-function'." (when (or show-empty (consp registers)) (with-current-buffer-window buffer - (cons 'display-buffer-below-selected - '((window-height . fit-window-to-buffer) - (preserve-size . (nil . t)))) + register-preview-display-buffer-alist nil (with-current-buffer standard-output (setq cursor-in-non-selected-windows nil) -- 2.34.1 --=-=-=--