unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: john muhl <jm@pub.pink>
To: 69909@debbugs.gnu.org
Subject: bug#69909: [PATCH] Use window instead of frame for inferior Lua buffer
Date: Tue, 19 Mar 2024 21:16:57 -0500	[thread overview]
Message-ID: <87plvpk5ma.fsf@pub.pink> (raw)
In-Reply-To: <87il1hlkyu.fsf@pub.pink>

[-- Attachment #1: Type: text/plain, Size: 55 bytes --]

Oops. Probably don’t want these in the Changelog.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Open-inferior-Lua-buffer-in-a-window-not-a-frame.patch --]
[-- Type: text/x-patch, Size: 1065 bytes --]

From 4c7f50cb28489f5f2bf62af2b09bf16ac6b16045 Mon Sep 17 00:00:00 2001
From: john muhl <jm@pub.pink>
Date: Tue, 19 Mar 2024 19:46:12 -0500
Subject: [PATCH] ; Open inferior Lua buffer in a window, not a frame

* lisp/progmodes/lua-ts-mode.el (lua-ts-inferior-lua): Replace
'display-buffer-pop-up-window' with
'display-buffer-pop-up-frame'.  (bug#69909)
---
 lisp/progmodes/lua-ts-mode.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/progmodes/lua-ts-mode.el b/lisp/progmodes/lua-ts-mode.el
index 25fd7792f42..b6d6e90680c 100644
--- a/lisp/progmodes/lua-ts-mode.el
+++ b/lisp/progmodes/lua-ts-mode.el
@@ -628,7 +628,7 @@ lua-ts-inferior-lua
                 nil t)))
   (select-window (display-buffer lua-ts-inferior-buffer
                                  '((display-buffer-reuse-window
-                                    display-buffer-pop-up-frame)
+                                    display-buffer-pop-up-window)
                                    (reusable-frames . t))))
   (get-buffer-process (current-buffer)))
 
-- 
2.41.0


[-- Attachment #3: Type: text/plain, Size: 417 bytes --]



john muhl <jm@pub.pink> writes:

> [1. text/x-patch; 0001-Use-window-instead-of-frame-for-inferior-Lua-buffer.patch]...
>
>
> john muhl <jm@pub.pink> writes:
>
>> Tags: patch
>>
>> I noticed a couple of changes requested in the initial round of
>> review weren’t included in the final patch of bug#65673.
>>
>> This one changes it so the inferior Lua buffer uses a window
>> instead of a frame.


  reply	other threads:[~2024-03-20  2:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-20  1:33 bug#69909: [PATCH] Use window instead of frame for inferior Lua buffer john muhl
2024-03-20  2:00 ` john muhl
2024-03-20  2:16   ` john muhl [this message]
2024-03-23  7:25     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plvpk5ma.fsf@pub.pink \
    --to=jm@pub.pink \
    --cc=69909@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).