From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#70036: a fix that Date: Fri, 19 Apr 2024 09:38:41 +0200 Message-ID: <87plul245a.fsf@thornhill.no> References: <4e670617-6483-4159-a5cf-27a921764c38@email.android.com> <865xwddf5w.fsf@gnu.org> Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25772"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 70036@debbugs.gnu.org, felician.nemeth@gmail.com, joaotavora@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 19 09:40:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rxiqx-0006Ph-7m for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 19 Apr 2024 09:40:12 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rxiqi-0001Pq-Qi; Fri, 19 Apr 2024 03:39:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rxiqb-0001P9-9I for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 03:39:50 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rxiqa-0002gS-C0 for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 03:39:48 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rxiqo-0002Ct-80 for bug-gnu-emacs@gnu.org; Fri, 19 Apr 2024 03:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 Apr 2024 07:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70036 X-GNU-PR-Package: emacs Original-Received: via spool by 70036-submit@debbugs.gnu.org id=B70036.17135123498140 (code B ref 70036); Fri, 19 Apr 2024 07:40:02 +0000 Original-Received: (at 70036) by debbugs.gnu.org; 19 Apr 2024 07:39:09 +0000 Original-Received: from localhost ([127.0.0.1]:57375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxipv-00026z-AU for submit@debbugs.gnu.org; Fri, 19 Apr 2024 03:39:09 -0400 Original-Received: from out-184.mta0.migadu.com ([2001:41d0:1004:224b::b8]:24725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rxipt-00025c-6k for 70036@debbugs.gnu.org; Fri, 19 Apr 2024 03:39:05 -0400 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1713512324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Iaysf7rcU1dR1mfjDOdpRSo7/6IVbKJ2YXBqTS9FO/w=; b=kQTRbnuem78ViZJwf8OlIPLvI6V3hlJxtD8ZygPSisLkJU2ePAxkcq5wYkyQ/dmMnWdV8H LfrJC/n4Y/usSKkRO93CDMYiljJ4ViH4gXFqWcKDEvQMMopmcsJoYVJSIX7P6wv41qB/x7 dZvhPQSPaB4bZ5+Z0B5wkl0cceOz6yY4p/+x68upMCkW+IsbVGsng8rInZdzqGybMSdx2w hbsy9XCB/f92RrK+d9/PrztV9zzpjg+N5wV/aeuOyXy5RXuluSiI7bqI7fIv0dIxPm6hSs B1CNWsPwUoJJkU6I9cE6f2LFJ/XJ/AIzAoGX5PvbZ1+bmihAc9aa7G7paqwdOQ== In-Reply-To: <865xwddf5w.fsf@gnu.org> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283643 Archived-At: Eli Zaretskii writes: >> Date: Thu, 18 Apr 2024 23:32:00 +0200 >> From: Theodor Thornhill >> Cc: Eli Zaretskii , felician.nemeth@gmail.com, >> 70036@debbugs.gnu.org >>=20 >> I'll add two profiles, one is profile-fast and profile-slow. You can >> guess which is which :) >>=20 >> STEPS: >> I've made an intentionally broken commit into a golang repo I just >> forked, to get some publishDiagnostics quickly. >>=20 >> (for good measure evaluate eglot.el before running profiles) >>=20 >> 1. Install gopls >> 2. Make some directory you can wipe out after the test and cd into it >> 3. git clone git@github.com:theothornhill/gin.git foo/bar/baz/foo/bar/ba= z/foo/bar/baz/foo/bar/baz/gin >> 4. cd foo/bar/baz/foo/bar/baz/foo/bar/baz/foo/bar/baz/gin >> 5. open fs.go in emacs and make sure some go mode is available. Go-ts-mo= de for example >> 6. M-x profiler-start >> 7. M-x eglot >> 8. Wait 10-20 seconds. Do no actions other than let the lsp settle. >> 9. M-x profiler-stop >> 10. M-x profiler-report >> 11. Rinse repeat with both or all variants of emacs with/without the >> latest eglot changes. >> I'll add my profiles, and let some metrics talk. > > Thanks, but that is not what I asked to provide, for us to make a > decision in this case. I asked to provide results of a benchmark-run > or similar measure of the run time. Profiles, by contrast, are much > harder to interpret when the issue is the overall time it takes to > perform some operations. > > Could you please show benchmark times of the old code (before your > changes), the code after your changes, and the current code in Git > (after Jo=C3=A3o reverted your change and installed his own improvements)? > This will allow us to see the times (both processing and GC) of each > variant, and will allow to compare their performance. > > Thanks. I'll try. Theo