From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mohsin Kaleem Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v7] Add support for colored and styled underlines on tty frames Date: Mon, 22 Apr 2024 18:52:27 +0100 Message-ID: <87pluhi8tg.fsf@kisara.moe> References: <87pm7x5mxc.fsf@kisara.moe> <87sezeitkj.fsf@kisara.moe> <87sezegra8.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28032"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 62994@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 22 19:53:10 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryxqn-00074s-Ve for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Apr 2024 19:53:10 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryxqV-0008HO-7b; Mon, 22 Apr 2024 13:52:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryxqQ-0008Eg-S9 for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 13:52:46 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ryxqQ-00048v-JL for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 13:52:46 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ryxqg-0004H8-BF for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2024 13:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mohsin Kaleem Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2024 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.171380837216412 (code B ref 62994); Mon, 22 Apr 2024 17:53:02 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 22 Apr 2024 17:52:52 +0000 Original-Received: from localhost ([127.0.0.1]:47049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryxqV-0004Ge-TV for submit@debbugs.gnu.org; Mon, 22 Apr 2024 13:52:52 -0400 Original-Received: from 119.ip-51-38-65.eu ([51.38.65.119]:33670 helo=mail.kisara.moe) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryxqS-0004Fm-MU for 62994@debbugs.gnu.org; Mon, 22 Apr 2024 13:52:50 -0400 Original-Received: from mk-desktop (bcde7b88.skybroadband.com [188.222.123.136]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by mail.kisara.moe (Postfix) with ESMTPSA id 38A3FA2796; Mon, 22 Apr 2024 19:52:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kisara.moe; s=default; t=1713808350; bh=CnORsQj7qWRlrlFD/+gxygbY7O61ICwo4uKW764LW58=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=FK2Jl0uXn+jQXPMukFdpI3iWcv9LZj7WTsRcIXBP0meXgpDXkdfkITCKjkhWjfXZ0 wIu0A6lovz/JyzAnf0kWU3JNJTkQvo2I0SI/tUaYwXWjG+0k+iVJddtKSMavqSKW+w N+O8Eqo/3UWdpx2ZJVGiJFaeQzd52sKxWkaFR+mC8byNPAZiQPfbY4L6G4IDHkCmsz 1reIAYFFKZUpIh2+NIYkOPUHu/DQ6ameb6yaCWsIzjT8TPoybh9DuvGjLluKp2F0ZM QQUi3fMctt+aq1K6CsT/ZfoyDlInRbtFse/8+/q7McyDjSHaxherSekP7h5v19ibsG rvh6eG8x3erxg== In-Reply-To: <87sezegra8.fsf@yahoo.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283843 Archived-At: Po Lu writes: > This is not the proper manner of specifying bug numbers relating to a > change. Place it immediately after the most relevant (in your judgment) > item in the log entry, e.g.: > > * src/foo.c (pertinent_function): Adjust for something. > (bug#62994) I've moved it to after another section. Will resubmit patch. >> * src/xterm.c (x_draw_glyph_string): Updated to use renamed >> FACE_UNDERLINE_SINGLE and FACE_UNDERLINE_WAVE face_underline_type >> enumerations. > > This change should be accompanied by like updates to *_draw_glyph_string > and related functions in the remaining terminal backends. Based on Elis comments I don't think is a hard requirement. I'll defer this to Jim or anyone else who considers it a priority if that's ok :-). > > Last but not least, are there terminal emulators besides Kitty that > support these underline styles? I haven't tested exhaustively, although I listed 2 others in the NEWS file. That being st (through a custom patch) and libvte. Personally I use st so that was my primary motivation in adopting this. -- Mohsin Kaleem