From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.bugs Subject: bug#70134: [PATCH] Show all date options when adding Gnus scores interactively Date: Fri, 10 May 2024 14:27:58 -0700 Message-ID: <87plttpdb5.fsf@ericabrahamsen.net> References: <87edbovjvj.fsf@kubajecminek.cz> <86bk6dr8wi.fsf@gnu.org> <87jzkqjclv.fsf@ericabrahamsen.net> <87le4tz61f.fsf@kubajecminek.cz> <87bk5eu78m.fsf@kubajecminek.cz> <87bk5esfiy.fsf@ericabrahamsen.net> <87y18hph60.fsf@ericabrahamsen.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10672"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) To: 70134@debbugs.gnu.org Cancel-Lock: sha1:UJT81cZw4F81f4iRHPF1sQxtkbw= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 10 23:29:31 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s5Xo2-0002Xw-Se for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 May 2024 23:29:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s5Xne-0006Cg-8G; Fri, 10 May 2024 17:29:06 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5Xnc-00065a-Mk for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 17:29:04 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1s5Xnb-00032v-Tx for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 17:29:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1s5Xna-0002gV-Hf for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 17:29:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: <87edbovjvj.fsf@kubajecminek.cz> Resent-From: Eric Abrahamsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 May 2024 21:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70134 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.171537649510294 (code B ref -1); Fri, 10 May 2024 21:29:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 10 May 2024 21:28:15 +0000 Original-Received: from localhost ([127.0.0.1]:44215 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5Xmo-0002fy-Ux for submit@debbugs.gnu.org; Fri, 10 May 2024 17:28:15 -0400 Original-Received: from lists.gnu.org ([209.51.188.17]:55660) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1s5Xmm-0002fq-Oh for submit@debbugs.gnu.org; Fri, 10 May 2024 17:28:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5Xmn-0005Qo-46 for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 17:28:13 -0400 Original-Received: from ciao.gmane.io ([116.202.254.214]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s5Xml-0002zd-Mb for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 17:28:12 -0400 Original-Received: from list by ciao.gmane.io with local (Exim 4.92) (envelope-from ) id 1s5Xmi-0000eO-JM for bug-gnu-emacs@gnu.org; Fri, 10 May 2024 23:28:08 +0200 X-Injected-Via-Gmane: http://gmane.org/ Received-SPF: pass client-ip=116.202.254.214; envelope-from=geb-bug-gnu-emacs@m.gmane-mx.org; helo=ciao.gmane.io X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, HEADER_FROM_DIFFERENT_DOMAINS=0.249, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:284837 Archived-At: Jakub Ječmínek via "Bug reports for GNU Emacs, the Swiss army knife of text editors" writes: > Apologies for the formatting, I’m writing this reply from my phone. > >> And sure enough, the modification of the string is the point -- it's a >> cache! From gnus-sum.el: >> >> ; Since this is called not only to sort the top-level threads, but >> ; also in recursive sorts to order the articles within a thread, each >> ; article will be processed many times. Thus it speeds things up >> ; quite a bit to use gnus-date-get-time, which caches the time value. >> (defun gnus-thread-latest-date (thread) >> "Return the highest article date in THREAD." >> (apply #'max >> (mapcar (lambda (header) (float-time >> (gnus-date-get-time >> (mail-header-date header)))) >> (flatten-tree thread)))) >> >> Can we strip properties around the call, maybe? > > I don’t think there’s need to do that. The change that I proposed in > the patch should remove the unintended side effect (and thus fix the > bug pointed by Alex) while keeping the caching behaviour intact > (‘gnus-thread-latest-date’ code above will work as expected). Okay, thanks. I won't mess with it, then.