From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions Date: Sat, 25 May 2024 08:47:36 +0000 Message-ID: <87pltanuqf.fsf@posteo.net> References: <87edcrtegz.fsf@gmail.com> <87sf15rjyf.fsf@gmail.com> <8734t5yh49.fsf@posteo.net> <87edcp9p54.fsf@breatheoutbreathe.in> <878qzypbav.fsf@posteo.net> <87o78ul3fb.fsf@breatheoutbreathe.in> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18598"; mail-complaints-to="usenet@ciao.gmane.io" Cc: eliz@gnu.org, 69528@debbugs.gnu.org, iarchivedmywholelife@gmail.com To: Joseph Turner Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat May 25 10:48:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sAn4f-0004eh-Fi for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 May 2024 10:48:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sAn4I-0002wg-Vn; Sat, 25 May 2024 04:47:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sAn4F-0002wD-RF for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 04:47:56 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sAn4E-0003N3-N5 for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 04:47:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sAn4L-0007Tj-QX for bug-gnu-emacs@gnu.org; Sat, 25 May 2024 04:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 May 2024 08:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 69528 X-GNU-PR-Package: emacs Original-Received: via spool by 69528-submit@debbugs.gnu.org id=B69528.171662687428735 (code B ref 69528); Sat, 25 May 2024 08:48:01 +0000 Original-Received: (at 69528) by debbugs.gnu.org; 25 May 2024 08:47:54 +0000 Original-Received: from localhost ([127.0.0.1]:42142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAn4D-0007TP-P4 for submit@debbugs.gnu.org; Sat, 25 May 2024 04:47:54 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:47637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sAn4B-0007TE-3a for 69528@debbugs.gnu.org; Sat, 25 May 2024 04:47:51 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 13402240028 for <69528@debbugs.gnu.org>; Sat, 25 May 2024 10:47:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1716626858; bh=yaiYTkajEsGUSnQV1EOKRmFYYqEqcUsbfu9Vci5lBCM=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:Content-Transfer-Encoding:From; b=Ga2Y6ymZ5mshBMb2a2BBhlzICmK08HpXz6/G4aongktz9cCfh5+77YqGEKJFSTJwP sr/y2ZzSWY56C8DDVC1hP0Ngo1l3CJYdbbvoTaOkmr0g8D+9O5ufomAyCzx3w/mnpU 50+z/edH+WnYtacNhFTRgb+e5KC2pGEeqL0niXbdim46UNzdJwSKwW48t2XvS3//Qm vV+jp8iOv940Ypbzm6PtkMDPVZsTCrOPDmgrGa7TuiCpUOTMZOTfnE0diDLt9j0Cal pLpPtQAba+c30UX4XuTwagh7ax6gH1Q/bQyumdVaV6rJxGeampVyJB+Q0XGaMreavD x8SsTVG1zMRgQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VmbBx2vLmz6tvt; Sat, 25 May 2024 10:47:37 +0200 (CEST) In-Reply-To: <87o78ul3fb.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 25 May 2024 01:08:08 -0700") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285841 Archived-At: Joseph Turner writes: > Philip Kaludercic writes: > >> Joseph Turner writes: >> >>> Philip Kaludercic writes: >>>> So in general, this patch might be appropriate? >>>> >>>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddef= s-gen.el >>>> index 581053f6304..42f386933dc 100644 >>>> --- a/lisp/emacs-lisp/loaddefs-gen.el >>>> +++ b/lisp/emacs-lisp/loaddefs-gen.el >>>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file >>>> ;; loaddefs for packages so that `syntax-ppss' later gives >>>> ;; correct results. >>>> (emacs-lisp-mode) >>>> - (let ((version (lm-header "version")) >>>> + (let ((version (or (lm-header "package-version") >>>> + (lm-header "version"))) >>>> package) >>>> (when (and version >>>> (setq version (ignore-errors (version-to-list ve= rsion))) >>>> >>>> >>> >>> What about making `lm-version' handle the "package-version" header then >>> using `lm-version' in loaddefs-generate--parse-file? See patches. >> >> My main concern was if we want to have Package-Version always override >> Version, but if my patch modified loaddefs-gen, then I don't think there >> is much of a difference if we change lisp-mnt instead (in terms of the >> generality of the change). > > If it would be more appropriate, I can resubmit another patch with > "Version" used preferentially over "Package-Version". No, I believe that would be wrong, at least going by these quotes from the manual: (elisp) Simple Packages: The version number comes from the =E2=80=98Package-Version=E2=80=99 he= ader, if it exists, or from the =E2=80=98Version=E2=80=99 header otherwise. One or t= he other _must_ be present. Here, the version number is 1.3. (elisp) Library Headers: =E2=80=98Package-Version=E2=80=99 If =E2=80=98Version=E2=80=99 is not suitable for use by the package = manager, then a package can define =E2=80=98Package-Version=E2=80=99; it will be use= d instead. This is handy if =E2=80=98Version=E2=80=99 is an RCS id or something= else that cannot be parsed by =E2=80=98version-to-list=E2=80=99. So the patch is fine as it is. --=20 Philip Kaludercic on peregrine