From: Philip Kaludercic <philipk@posteo.net>
To: Joseph Turner <joseph@breatheoutbreathe.in>
Cc: eliz@gnu.org, 69528@debbugs.gnu.org, iarchivedmywholelife@gmail.com
Subject: bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions
Date: Sat, 25 May 2024 08:47:36 +0000 [thread overview]
Message-ID: <87pltanuqf.fsf@posteo.net> (raw)
In-Reply-To: <87o78ul3fb.fsf@breatheoutbreathe.in> (Joseph Turner's message of "Sat, 25 May 2024 01:08:08 -0700")
Joseph Turner <joseph@breatheoutbreathe.in> writes:
> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Joseph Turner <joseph@breatheoutbreathe.in> writes:
>>
>>> Philip Kaludercic <philipk@posteo.net> writes:
>>>> So in general, this patch might be appropriate?
>>>>
>>>> diff --git a/lisp/emacs-lisp/loaddefs-gen.el b/lisp/emacs-lisp/loaddefs-gen.el
>>>> index 581053f6304..42f386933dc 100644
>>>> --- a/lisp/emacs-lisp/loaddefs-gen.el
>>>> +++ b/lisp/emacs-lisp/loaddefs-gen.el
>>>> @@ -433,7 +433,8 @@ loaddefs-generate--parse-file
>>>> ;; loaddefs for packages so that `syntax-ppss' later gives
>>>> ;; correct results.
>>>> (emacs-lisp-mode)
>>>> - (let ((version (lm-header "version"))
>>>> + (let ((version (or (lm-header "package-version")
>>>> + (lm-header "version")))
>>>> package)
>>>> (when (and version
>>>> (setq version (ignore-errors (version-to-list version)))
>>>>
>>>>
>>>
>>> What about making `lm-version' handle the "package-version" header then
>>> using `lm-version' in loaddefs-generate--parse-file? See patches.
>>
>> My main concern was if we want to have Package-Version always override
>> Version, but if my patch modified loaddefs-gen, then I don't think there
>> is much of a difference if we change lisp-mnt instead (in terms of the
>> generality of the change).
>
> If it would be more appropriate, I can resubmit another patch with
> "Version" used preferentially over "Package-Version".
No, I believe that would be wrong, at least going by these quotes from
the manual:
(elisp) Simple Packages:
The version number comes from the ‘Package-Version’ header, if it
exists, or from the ‘Version’ header otherwise. One or the other _must_
be present. Here, the version number is 1.3.
(elisp) Library Headers:
‘Package-Version’
If ‘Version’ is not suitable for use by the package manager, then a
package can define ‘Package-Version’; it will be used instead.
This is handy if ‘Version’ is an RCS id or something else that
cannot be parsed by ‘version-to-list’.
So the patch is fine as it is.
--
Philip Kaludercic on peregrine
next prev parent reply other threads:[~2024-05-25 8:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-03 17:25 bug#69528: 30.0.50; [BUG] transient.el is not a member of package--builtin-versions No Wayman
2024-03-04 17:22 ` No Wayman
2024-03-04 18:41 ` Philip Kaludercic
2024-03-05 6:17 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-09 6:53 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 7:39 ` Eli Zaretskii
2024-05-25 8:04 ` Philip Kaludercic
2024-05-25 8:08 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 8:47 ` Philip Kaludercic [this message]
2024-05-26 0:45 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-05-25 10:49 ` Eli Zaretskii
2024-06-02 10:36 ` Stefan Kangas
2024-06-02 11:07 ` Philip Kaludercic
2024-06-02 12:08 ` Stefan Kangas
2024-06-02 13:11 ` Philip Kaludercic
2024-06-02 18:26 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-02 18:40 ` Philip Kaludercic
2024-06-03 17:24 ` Stefan Kangas
2024-06-03 19:24 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-03 19:58 ` Philip Kaludercic
2024-06-03 20:38 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 22:19 ` Stefan Kangas
2024-06-04 22:34 ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-06-04 22:22 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pltanuqf.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=69528@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=iarchivedmywholelife@gmail.com \
--cc=joseph@breatheoutbreathe.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).