From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#71180: [ELPA Feature Request] Package thumbnail Date: Sun, 26 May 2024 11:01:28 +0000 Message-ID: <87plt8x2ev.fsf@posteo.net> References: <86a5ken8py.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31642"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "Elijah G." , 71180@debbugs.gnu.org, Stefan Monnier To: Stefan Kangas Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun May 26 13:02:14 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sBBdm-00082l-CP for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 26 May 2024 13:02:14 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sBBdV-0002Ov-HC; Sun, 26 May 2024 07:01:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sBBdS-0002OO-3L for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 07:01:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1sBBdR-0007R1-QC for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 07:01:53 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1sBBdZ-0000cm-RG for bug-gnu-emacs@gnu.org; Sun, 26 May 2024 07:02:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 May 2024 11:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 71180 X-GNU-PR-Package: emacs Original-Received: via spool by 71180-submit@debbugs.gnu.org id=B71180.17167213072381 (code B ref 71180); Sun, 26 May 2024 11:02:01 +0000 Original-Received: (at 71180) by debbugs.gnu.org; 26 May 2024 11:01:47 +0000 Original-Received: from localhost ([127.0.0.1]:38449 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBBdL-0000cL-Gd for submit@debbugs.gnu.org; Sun, 26 May 2024 07:01:47 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:60521) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1sBBdI-0000c6-On for 71180@debbugs.gnu.org; Sun, 26 May 2024 07:01:45 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 7C4EE240029 for <71180@debbugs.gnu.org>; Sun, 26 May 2024 13:01:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1716721290; bh=8hL+d+OtGO2yZHagQReayW4bNuh5ZV30iuhegVZ2naM=; h=From:To:Cc:Subject:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=IpD2BK/oCN5nsiSeM4ulmQFcOnuhS7tF6rx0sKldzLPet54z4KR2fVyfXbqRUXPQV ukiIavhAkCCzlcPc9igOhMJZuZP4i0paX7rxtzUehAPjOtamyIl1GnndrrYqfzxj1k OqIFXwTpM9z7d94+z+VcrRn37wY3wFmDhhpbWzw50JZ9uCTC1hsz0P8GpyhB2vdGAl /vxYbJZWMRrWEAFOUzhAJFtdiR48ORwoqrbnD9ZVU8ZDeKrbtAb9c/hpjB19yN1td0 zz4QVinhj0WzHsEIYV1lMgC/0uPma1Ne5s/6OUF80m0YP4m6BTjnlzL9B/YaEc3BPU B4nWfbER+96kA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4VnG6x37stz9rxF; Sun, 26 May 2024 13:01:29 +0200 (CEST) In-Reply-To: (Stefan Kangas's message of "Sun, 26 May 2024 02:23:36 -0700") OpenPGP: id=7126E1DE2F0CE35C770BED01F2C3CC513DB89F66; url="https://keys.openpgp.org/vks/v1/by-fingerprint/7126E1DE2F0CE35C770BED01F2C3CC513DB89F66"; preference=signencrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:285951 Archived-At: Stefan Kangas writes: > tags 71180 - notabug > severity 71180 wishlist > thanks > > "Elijah G." writes: > >> Tags: notabug >> >> Hi, i'm wondering if would be a good idea add support for thumbnail for >> elpa packages (for elpa website and package-menu *Help* buffers). >> I think this is a missing feature that most other editors and non-editors >> does (such as synaptic and vscodium). I am not sure if you mean this as a kind of "logo" or as a kind of screenshot? I assume you mean the latter. >> My idea is to only support 1 image (jpg or png, adding more than 1 >> thumbnail would be hard to read the package *Help* buffer) and resize it >> (if possible) for not take all the buffer size. >> >> For packages developers i think would be fine define new header comment >> line for let them to choose which image they want to use, something like: >> ;;; Thumbnail: ./image.png If anything, I think it would be best to mandate SVG, which after all we can easily generate using (x-export-frames nil 'svg), if supported. That should solve the scaling issue. AFAIK we currently don't support animated SVGs in Emacs, right? That might be a nice feature for some packages. Two points I am not fond of is that screenshots on sites like GitHub are often not uniform and contain a lot of noise. It would be nice if we could give some guidelines, or better yet generate the screenshots ourselves from a given sequence of keys. That might not be nice from a security or performance perspective and could still be circumvented. Otherwise, I also dislike the notion of having package developers version effectively binary data (especially if we are dealing with non-vector graphics) in their repositories -- if one can't meaningfully generate a patch whenever the file changes, I take the position that one should think twice about versioning it in a Git repository. >> Thanks. > > I think this could be a good idea, but it would also depend on how the > idea is executed. We would obviously need knobs to turn it off, the > feature would need to be tested on text displays, etc. If we are talking about screenshots, that these aren't hard requirements to understand what a package does, just as describe-package can do its job now without the help of images. Visual examples should be regarded as an enchantment, where they make sense. > Instead of a header comment, we could just say that the thumbnail should > always be called "thumb.png" and be in the root directory of the > package, or something along those lines. I agree that would be better. -- Philip Kaludercic on peregrine