From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74413: [PATCH] Allow to store and read repository information of VCS builds Date: Tue, 19 Nov 2024 18:16:28 +0200 Message-ID: <87plmrtd0j.fsf@thaodan.de> References: <86frnovhg8.fsf@gnu.org> <867c90vbfk.fsf@gnu.org> <86v7wjtfms.fsf@gnu.org> Reply-To: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34193"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: luangruo@yahoo.com, 74413@debbugs.gnu.org, Stefan Kangas To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Nov 19 17:18:18 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tDQvi-0008hJ-Ao for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 19 Nov 2024 17:18:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tDQvU-0005Q9-Pf; Tue, 19 Nov 2024 11:18:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tDQvT-0005Py-R5 for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 11:18:03 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tDQvT-0007qJ-IX for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 11:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=l86IwqSHV3d+xzcCZ/e/qpxvbYJ5+QMtqu4gfmxz/PA=; b=OuRKIlpEU2ZkkRfKibWfAqGtbvvl+uTKH6w0Ko/MOp5DuPV/RPEtfn/gtZExTYkfL0X62I3tFLtjHifuwYHRBim35L4se242OSPpl1Cyk+0H8CkUSajVL33fRzU0PkDYB1DIwFnjvaC72YIVjxFjHf3pjMpwIQasAPwKIIrvCasM4UfR21A9rRML2iM6wSHYXGqIbs6H9xnkkPxXfrR7jSpkIXginxDydVxGmJk8LbS/7oQWiM+yYYAPmsev2+jWackfoK1+BiCYScwl89Os8iY2GDeDQ3g/2H48fApHT7wellvJTtplIdtT2FZyVtno80rYmp2+HQBn3Dvb0ojw9Q==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tDQvS-0005sm-Cd for bug-gnu-emacs@gnu.org; Tue, 19 Nov 2024 11:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?Bj=C3=B6rn?= Bidar Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 19 Nov 2024 16:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74413 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 74413-submit@debbugs.gnu.org id=B74413.173203302522536 (code B ref 74413); Tue, 19 Nov 2024 16:18:02 +0000 Original-Received: (at 74413) by debbugs.gnu.org; 19 Nov 2024 16:17:05 +0000 Original-Received: from localhost ([127.0.0.1]:43778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDQuW-0005rQ-K2 for submit@debbugs.gnu.org; Tue, 19 Nov 2024 11:17:04 -0500 Original-Received: from thaodan.de ([185.216.177.71]:50826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tDQuU-0005rH-W2 for 74413@debbugs.gnu.org; Tue, 19 Nov 2024 11:17:03 -0500 Original-Received: from NordStern (unknown [185.252.118.71]) by thaodan.de (Postfix) with ESMTPSA id E1409D00038; Tue, 19 Nov 2024 18:16:28 +0200 (EET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=thaodan.de; s=mail; t=1732032989; bh=6REoBNgu8KQFmEdTG+CnR5x4xCoBjpMXxVzahYYoMa8=; h=From:To:Cc:Subject:In-Reply-To:References:Date; b=s1oh4JAIIewBgOXnzsxAZmNzsAEs+pe8jphIspu7fu2p40wac1/xFl+Qnos4z6Fqf jR3utflK09x6GsxrbL6H5aGKHN62s57Qtc1N4GuyF2yFCRK/r8sw6SA8afP1t6wlj3 AJ62gqhxu5cUIBh/CJshb3eONr4Vdzr/+KCUZORqcW7fEcK9F7zFhntscCGUcAP+LL HD/ZlsJXtBXzxPPOHNj9lgsgZVg771xmNwWVHXck5j/EAKg6uR7aaKBZdMRYpkz+uH VqF0cbJL/HZRpXrKUapFJYV8HQA8xn1O9B2CNUZGExQzfKTqqqP6zqpKpD4oWQb82K NpnPRvcNho9QuR3zDs2KArC9XDKuWM04yTfSIS364YrtRT9P5VVvd00b4qvW5o2hR2 7c5pZ1uwFW64KA4d0Xfc15YO0Z/7jyFgP+M8vIT9/zIbuLC7oAU8g9I9UEAQF3vR+0 qrDaEeq6FYI4M6euJBqD4O9BgVV3RgGxAUpWARUOBSxJhAo9CNvZDrHmDxesF1tLl/ I/4tlm2/qcBCiXXEaLgL06AKEJ9aZdHZglNkPaEkcvW2oWqMuEcfMngQHCkOF4fPJF 4qd8yvkrostxJdTbzkMS6iE915ZA147Hg7BMh4JxjjyZVAfChLL6ub7RHzam36WBx4 zEF03GQwQbfgc6/tt7jEKV6Y= In-Reply-To: <86v7wjtfms.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 19 Nov 2024 17:19:55 +0200") Autocrypt: addr=bjorn.bidar@thaodan.de; prefer-encrypt=nopreference; keydata= mDMEZNfpPhYJKwYBBAHaRw8BAQdACBEmr+0xwIIHZfIDlZmm7sa+lHHSb0g9FZrN6qE6ru60JUJq w7ZybiBCaWRhciA8Ympvcm4uYmlkYXJAdGhhb2Rhbi5kZT6IlgQTFgoAPgIbAwULCQgHAgIiAgYV CgkICwIEFgIDAQIeBwIXgBYhBFHxdut1RzAepymoq1wbdKFlHF9oBQJk1/YmAhkBAAoJEFwbdKFl HF9oB9cBAJoIIGQKXm4cpap+Flxc/EGnYl0123lcEyzuduqvlDT0AQC3OlFKm/OiqJ8IMTrzJRZ8 phFssTkSrrFXnM2jm5PYDoiTBBMWCgA7FiEEUfF263VHMB6nKairXBt0oWUcX2gFAmTX6T4CGwMF CwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgkQXBt0oWUcX2hbCQEAtru7kvM8hi8zo6z9ux2h K+B5xViKuo7Z8K3IXuK5ugwA+wUfKzomzdBPhfxDsqLcEziGRxoyx0Q3ld9aermBUccHtBxCasO2 cm4gQmlkYXIgPG1lQHRoYW9kYW4uZGU+iJMEExYKADsCGwMFCwkIBwICIgIGFQoJCAsCBBYCAwEC HgcCF4AWIQRR8XbrdUcwHqcpqKtcG3ShZRxfaAUCZNf2FQAKCRBcG3ShZRxfaCzSAP4hZ7cSp0YN XYpcjHdsySh2MuBhhoPeLGXs+2kSiqBiOwD/TP8AgPEg/R+SI9GI9on7fBJJ0mp2IT8kZ2rhDOjg gA6IkwQTFgoAOxYhBFHxdut1RzAepymoq1wbdKFlH X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:295645 Archived-At: Eli Zaretskii writes: >> From: Stefan Kangas >> Date: Mon, 18 Nov 2024 18:48:31 -0500 >> Cc: luangruo@yahoo.com, 74413@debbugs.gnu.org >> >> Eli Zaretskii writes: >> >> > The branch name could be private. >> > >> > Stefan, WDYT about this feature suggestion? >> >> The privacy risk here is that if a user is building their own private >> branch, announcing the sha or branch name to the world can be used to >> uniquely identify that user. It would be a serious privacy issue if we, >> for example, included that information in User-Agent headers sent by EWW >> or other kinds of network traffic. AFAIK, we don't do that. >> >> IIUC, we use this information only when submitting bug reports. I think >> this is harmless, if we assume privacy threat models where it can also >> be considered safe to report bugs. The few users that have more strict >> privacy requirements, and are eager to report bugs, will just have to >> think about this detail themselves; it's a rather specialized use case. > > AFAIU, the intent is to use this for more than just bug reporting. Where could leak the feature information? If it could it should be adjusted as well for the Android builds. >> I don't fully understand how you can have a situation where you can get >> this information in the Makefile, but you can't also get it when dumping >> using `emacs-repository-get-version` and `emacs-repository-get-branch` >> (lisp/loadup.el:474). Could you please elaborate on this? > > Yes, I still don't understand the utility of this feature, since it > needs Git for producing the information in the file. As explained Git doesn't have to be installed using that feature on the machine that executes the built Emacs or on the builder. The feature is the same as for the Android builds just for other platforms, the reasons are the same as for Android.