From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#74556: 30.0.92; Package upgrade can fail and results in deleted package Date: Tue, 10 Dec 2024 21:24:35 +0100 Message-ID: <87pllzp9q4.fsf@daniel-mendler.de> References: <87plmgq55e.fsf@daniel-mendler.de> <87zflj62ai.fsf@posteo.net> <87v7w7617o.fsf@posteo.net> <86ttbfism4.fsf@gnu.org> <87v7vvz0ay.fsf@posteo.net> <87zfl3h93m.fsf@daniel-mendler.de> <87ldwnxppc.fsf@posteo.net> Reply-To: Daniel Mendler Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25341"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 74556@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Dec 10 21:25:23 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tL6nK-0006QV-L4 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 10 Dec 2024 21:25:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tL6n2-0003u6-K3; Tue, 10 Dec 2024 15:25:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tL6n0-0003tx-NI for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 15:25:02 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1tL6n0-0008O2-EJ for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 15:25:02 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=bJR0CSk7UOIrFbtRQ/Dg8xUN2IZKMp0lkA54B99VTe8=; b=LPr4tlIFiK3R9vWZupuQ5jlHry1swvBwH3pEHY62EpNMPshX3jRMUL0FlogeutaOBNzSS7dSXcKpFbdgimzJxY431BgHflu+rwutb/7xYSMRbP20cyXPwnHP8APmzz01DjVfJyXVG4RUQLW6NmGFevaEk10frIOTBQ2J3BCMa+wOEvIBRvVSIAfJq6fZHf5KpK4eZin05ZR5NRRZ28YFK3Qj8CG2DkgIE56E7z1WpoGeoSw+97ep/mGqUVaFjthTiVpNJmJ+BKFINgpaYmYM8HiLT/+4QEBhNpUSQcfqyBVVBbtOSAa+qKwt2zI5rK+kCfvDZpGyIqDDvwRFSBLKxw==; Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1tL6mz-0006MD-Vh for bug-gnu-emacs@gnu.org; Tue, 10 Dec 2024 15:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Dec 2024 20:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 74556 X-GNU-PR-Package: emacs Original-Received: via spool by 74556-submit@debbugs.gnu.org id=B74556.173386228824371 (code B ref 74556); Tue, 10 Dec 2024 20:25:01 +0000 Original-Received: (at 74556) by debbugs.gnu.org; 10 Dec 2024 20:24:48 +0000 Original-Received: from localhost ([127.0.0.1]:59748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL6ml-0006Kr-FJ for submit@debbugs.gnu.org; Tue, 10 Dec 2024 15:24:48 -0500 Original-Received: from server.qxqx.de ([49.12.34.165]:35951 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1tL6mi-0006KM-NQ for 74556@debbugs.gnu.org; Tue, 10 Dec 2024 15:24:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=daniel-mendler.de; s=key; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=bJR0CSk7UOIrFbtRQ/Dg8xUN2IZKMp0lkA54B99VTe8=; b=Jn8JoJUZjoXah4CzX3u+xUQtOL pw06N5wNXF2ynILYNmDRGz6y6zh3lD9ysjeUCQaH9WezIjVSc2jQ+/3/y/VhM92joYX+xbPG49UYC BhmyDK4QNKG0WE6o1Cs+VyfSRjwjrC/IPN9bcJ6HrbXUvRYVlUEa6yaxDdNDq5i0zwwo=; In-Reply-To: <87ldwnxppc.fsf@posteo.net> (Philip Kaludercic's message of "Tue, 10 Dec 2024 20:12:15 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:296783 Archived-At: Philip Kaludercic writes: > Daniel Mendler writes: > >> Philip Kaludercic writes: >> >>> Eli Zaretskii writes: >>> >>>>> Cc: 74556@debbugs.gnu.org >>>>> From: Philip Kaludercic >>>>> Date: Thu, 28 Nov 2024 11:34:51 +0000 >>>>> >>>>> Philip Kaludercic writes: >>>>> >>>>> [...] >>>>> >>>>> > It might make sense to try and "deactivate" a package before installing >>>>> > the new package. Looking into some second-try fallback for >>>>> > package-install to refresh the package index if a package was not found >>>>> > would also be a good idea ^^ >>>>> >>>>> This might do it? >>>> >>>> Philip, please install this on the emacs-30 branch, unless you see any >>>> problems with the change. We'd like to make another pretest soon. >>> >>> Done. But we should keep the report open as there might be better >>> approaches to discuss in the future. >> >> Hello Philip, >> >> I just tried the modified `package-upgrade' function and it doesn't seem >> to work. It seems to break the upgrade procedure in an even worse way, >> at least in my setup. Now `package-install' is tried first with the >> package symbol, which will be a no-op, since the package is already >> installed. Afterwards the package is deleted and we always end up with >> no package. Probably `package-install' should also be called with a >> package descriptor of the new package version? > > Right, my sincere apologies for that oversight. That being said, I > don't feel comfortable fixing this right now as I am short on time to > fix and test something like this on the "emacs-30" branch. My vote > would be to revert the commit and try to tackle the issue on the > "master" branch. An alternative I can propose that would be closer to > the original code might be Yes, I also vote to revert your commit on the emacs-30 release branch. The issue isn't severe (and not a regression), so I'd say it is okay to fix the issue on the master branch. I don't understand how the code you proposed works. It seems that after the deletion, if the installation fails, the package will stay deleted? Anyway, no hurry from my side to get this fixed. Thanks. Daniel