unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@linkov.net>
To: Paul Nelson <ultrono@gmail.com>
Cc: 74140@debbugs.gnu.org, eliz@gnu.org
Subject: bug#74140: [PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package
Date: Mon, 16 Dec 2024 19:30:03 +0200	[thread overview]
Message-ID: <87plls0zlk.fsf@mail.linkov.net> (raw)
In-Reply-To: <uxsg7t8qsgnpae.fsf@gmail.com> (Paul Nelson's message of "Mon, 16 Dec 2024 06:57:13 +0100")

> Thanks Juri, I took a look at your implementation.  It has at least the
> following issue: the same command cannot be used to continue several
> repeat maps.  Consider for instance the following example:
>
> (defvar-keymap repeat-list-map
>   :doc "Keymap for repeating sequences."
>   :repeat ( :continue-only (yank undo))
>   "n" 'forward-list
>   "p" 'backward-list
>   "C-/" 'undo
>   "y" 'yank)
>
> (defvar-keymap repeat-paragraph-map
>   :doc "Keymap for repeating sequences."
>   :repeat ( :continue-only (yank undo))
>   "]" 'forward-paragraph
>   "}" 'forward-paragraph
>   "[" 'backward-paragraph
>   "{" 'backward-paragraph
>   "C-/" 'undo
>   "y" 'yank)
>
> This is why I think the repeat-continue-only property should be a list
> specifying which repeat maps the command should continue.

When I tried to evaluate your repeat-maps, I see that
the 'repeat-continue-only' property is already a list:

  (symbol-plist 'undo)
  => (repeat-map repeat-paragraph-map
      repeat-continue-only (repeat-paragraph-map repeat-list-map))

Maybe the problem is that currently the 'repeat-map' property
is not a list?





  reply	other threads:[~2024-12-16 17:30 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-31 17:36 bug#74140: [PATCH] Add :continue-only directive for repeat maps in bind-keys, use-package Paul Nelson
2024-11-01  7:54 ` Juri Linkov
2024-11-01  8:29   ` Paul Nelson
2024-11-01  8:58     ` Paul Nelson
2024-11-04 19:22       ` Juri Linkov
2024-11-04 20:45         ` Paul Nelson
2024-11-05 18:25           ` Juri Linkov
2024-11-05 20:51             ` Paul Nelson
2024-11-07 19:41               ` Juri Linkov
2024-11-23 18:44                 ` Paul Nelson
2024-11-27  7:46                   ` Juri Linkov
2024-11-27 15:19                     ` Paul Nelson
2024-11-28 19:12                       ` Juri Linkov
2024-12-03 18:12                         ` Juri Linkov
2024-12-03 18:18                           ` Paul Nelson
2024-12-04 12:08                           ` Eli Zaretskii
2024-12-04 17:29                             ` Juri Linkov
2024-12-11 12:27                               ` Paul Nelson
2024-12-16  5:57                               ` Paul Nelson
2024-12-16 17:30                                 ` Juri Linkov [this message]
2024-12-16 20:01                                   ` Paul Nelson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87plls0zlk.fsf@mail.linkov.net \
    --to=juri@linkov.net \
    --cc=74140@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=ultrono@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).