bug#684: 23.0.60; text-mode redefines "\es", the new search-map prefix

bug#684: 23.0.60; text-mode redefines "\es", the new search-map prefix

[Harald Maier]

Text-Mode redefines the new search-map prefix "\es" with
center-line. Maybe this needs to be changed too.

Harald

Index: text-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/text-mode.el,v
retrieving revision 1.55
diff -w -r1.55 text-mode.el
53,54c53,54
<     (define-key map "\es" 'center-line)
<     (define-key map "\eS" 'center-paragraph)
---
> ;;;     (define-key map "\es" 'center-line)
> ;;;     (define-key map "\eS" 'center-paragraph)



In GNU Emacs 23.0.60.16 (x86_64-unknown-linux-gnu, GTK+ Version 2.8.11)
 of 2008-08-10 on ate-s10-x64
Windowing system distributor `The X.Org Foundation', version 11.0.60900000
Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=local
  locale-coding-system: utf-8-unix
  default-enable-multibyte-characters: t

bug#684: 23.0.60; text-mode redefines "\es", the new search-map prefix

[Juri Linkov]

> Text-Mode redefines the new search-map prefix "\es" with
> center-line. Maybe this needs to be changed too.
>
> Index: text-mode.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/textmodes/text-mode.el,v
> retrieving revision 1.55
> diff -w -r1.55 text-mode.el
> 53,54c53,54
> <     (define-key map "\es" 'center-line)
> <     (define-key map "\eS" 'center-paragraph)
> ---
>> ;;;     (define-key map "\es" 'center-line)
>> ;;;     (define-key map "\eS" 'center-paragraph)

Instead of removing these useful commands from key bindings,
I think we should find a good replacement.

Starting from Emacs 22 we dedicated a special prefix map M-o
just for such formatting commands.  So I propose to move these
commands to the following keys:

M-o M-s    center-line
M-o M-S    center-paragraph

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#684: 23.0.60; text-mode redefines "\es", the new search-map prefix

[Chong Yidong]

> > Text-Mode redefines the new search-map prefix "\es" with
> > center-line. Maybe this needs to be changed too.
>
> Instead of removing these useful commands from key bindings,
> I think we should find a good replacement.
>
> Starting from Emacs 22 we dedicated a special prefix map M-o
> just for such formatting commands.  So I propose to move these
> commands to the following keys:
>
> M-o M-s    center-line
> M-o M-S    center-paragraph

Isn't the M-o prefix key used for text properties?  I don't think it's
such a good fit.  Maybe M-g would be better.  WDYT?

bug#684: 23.0.60; text-mode redefines "\es", the new search-map prefix

[Juri Linkov]

>> > Text-Mode redefines the new search-map prefix "\es" with
>> > center-line. Maybe this needs to be changed too.
>>
>> Instead of removing these useful commands from key bindings,
>> I think we should find a good replacement.
>>
>> Starting from Emacs 22 we dedicated a special prefix map M-o
>> just for such formatting commands.  So I propose to move these
>> commands to the following keys:
>>
>> M-o M-s    center-line
>> M-o M-S    center-paragraph
>
> Isn't the M-o prefix key used for text properties?  I don't think it's
> such a good fit.  Maybe M-g would be better.  WDYT?

M-g was intended for navigation commands ("goto" mnemonics), and
M-o for formatting commands (see (emacs) Formatted Text).
I think center-line and center-paragraph are more formatting
than navigation commands.

If this is ok then the following patch implements this.
It binds `M-o M-s' and `M-o M-S' globally after loading
text-mode.el.  This is perfectly fine since these bindings
have no conflicts with other modes.

Index: lisp/textmodes/text-mode.el
===================================================================
RCS file: /sources/emacs/emacs/lisp/textmodes/text-mode.el,v
retrieving revision 1.55
diff -c -r1.55 text-mode.el
*** lisp/textmodes/text-mode.el	6 May 2008 04:33:13 -0000	1.55
--- lisp/textmodes/text-mode.el	21 Aug 2008 20:43:55 -0000
***************
*** 50,62 ****
  (defvar text-mode-map
    (let ((map (make-sparse-keymap)))
      (define-key map "\e\t" 'ispell-complete-word)
-     (define-key map "\es" 'center-line)
-     (define-key map "\eS" 'center-paragraph)
      map)
    "Keymap for `text-mode'.
  Many other modes, such as `mail-mode', `outline-mode' and `indented-text-mode',
  inherit all the commands defined in this map.")
  
  \f
  (define-derived-mode text-mode nil "Text"
    "Major mode for editing text written for humans to read.
--- 50,63 ----
  (defvar text-mode-map
    (let ((map (make-sparse-keymap)))
      (define-key map "\e\t" 'ispell-complete-word)
      map)
    "Keymap for `text-mode'.
  Many other modes, such as `mail-mode', `outline-mode' and `indented-text-mode',
  inherit all the commands defined in this map.")
  
+ (define-key facemenu-keymap "\es" 'center-line)
+ (define-key facemenu-keymap "\eS" 'center-paragraph)
+ 
  \f
  (define-derived-mode text-mode nil "Text"
    "Major mode for editing text written for humans to read.

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#684: 23.0.60; text-mode redefines "\es", the new search-map prefix

[Chong Yidong]

Juri Linkov <juri@jurta.org> writes:

>>> Starting from Emacs 22 we dedicated a special prefix map M-o
>>> just for such formatting commands.  So I propose to move these
>>> commands to the following keys:
>>>
>>> M-o M-s    center-line
>>> M-o M-S    center-paragraph
>>
>> Isn't the M-o prefix key used for text properties?  I don't think it's
>> such a good fit.  Maybe M-g would be better.  WDYT?
>
> M-g was intended for navigation commands ("goto" mnemonics), and
> M-o for formatting commands (see (emacs) Formatted Text).
> I think center-line and center-paragraph are more formatting
> than navigation commands.

But center-line and center-paragraph have nothing to do with text
formatting as such -- currently, the commands in M-o all change
properties.  In contrast, center-line and center-paragraph perform
indentation.

How about C-c C-s and C-c C-S?

bug#684: 23.0.60; text-mode redefines "\es", the new search-map prefix

[Juri Linkov]

> Juri Linkov <juri@jurta.org> writes:
>
>>>> Starting from Emacs 22 we dedicated a special prefix map M-o
>>>> just for such formatting commands.  So I propose to move these
>>>> commands to the following keys:
>>>>
>>>> M-o M-s    center-line
>>>> M-o M-S    center-paragraph
>>>
>>> Isn't the M-o prefix key used for text properties?  I don't think it's
>>> such a good fit.  Maybe M-g would be better.  WDYT?
>>
>> M-g was intended for navigation commands ("goto" mnemonics), and
>> M-o for formatting commands (see (emacs) Formatted Text).
>> I think center-line and center-paragraph are more formatting
>> than navigation commands.
>
> But center-line and center-paragraph have nothing to do with text
> formatting as such -- currently, the commands in M-o all change
> properties.  In contrast, center-line and center-paragraph perform
> indentation.

In word processors, formatting has a broader sense - it includes
indentation, centering, alignment, justification, bulleting, numbering.
There was an idea to develop Emacs into a word processor
with the M-o map as the starting point.

> How about C-c C-s and C-c C-S?

These are good keybindings for the text major mode.  However, I don't see
why center-line and center-paragraph should be restricted to text-mode
only.  These commands are useful in any mode, and with a global keybinding
they will be available everywhere just like other formatting commands
such as `fill-paragraph' and commands in the `M-o' map that now has
enough room for more keybindings:

M-o b           facemenu-set-bold
M-o d           facemenu-set-default
M-o i           facemenu-set-italic
M-o l           facemenu-set-bold-italic
M-o o           facemenu-set-face
M-o u           facemenu-set-underline
M-o M-o         font-lock-fontify-block

-- 
Juri Linkov
http://www.jurta.org/emacs/

bug#684: 23.0.60; text-mode redefines "\es", the new search-map prefix

[Chong Yidong]

Juri Linkov <juri@jurta.org> writes:

>>> M-g was intended for navigation commands ("goto" mnemonics), and
>>> M-o for formatting commands (see (emacs) Formatted Text).
>>> I think center-line and center-paragraph are more formatting
>>> than navigation commands.
>>
>> But center-line and center-paragraph have nothing to do with text
>> formatting as such -- currently, the commands in M-o all change
>> properties.  In contrast, center-line and center-paragraph perform
>> indentation.
>
> I don't see why center-line and center-paragraph should be restricted
> to text-mode only.  These commands are useful in any mode, and with a
> global keybinding they will be available everywhere just like other
> formatting commands such as `fill-paragraph' and commands in the `M-o'
> map that now has enough room for more keybindings:
>
> M-o b           facemenu-set-bold
> M-o d           facemenu-set-default
> M-o i           facemenu-set-italic
> M-o l           facemenu-set-bold-italic
> M-o o           facemenu-set-face
> M-o u           facemenu-set-underline
> M-o M-o         font-lock-fontify-block

Okay then.  Could please check in a couple of NEWS entry explaining this
as well?  Thanks.