From: Eduard Wiebe <usenet@pusto.de>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 7308@debbugs.gnu.org, Chong Yidong <cyd@stupidchicken.com>
Subject: bug#7308: [patch] locate under windoze
Date: Sat, 13 Nov 2010 23:33:08 +0100 [thread overview]
Message-ID: <87oc9sq2fv.fsf@pusto.de> (raw)
In-Reply-To: <8339r4exco.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 13 Nov 2010 23:18:31 +0200")
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Chong Yidong <cyd@stupidchicken.com>
>> Cc: Eduard Wiebe <usenet@pusto.de>, 7308@debbugs.gnu.org
>> Date: Sat, 13 Nov 2010 13:57:03 -0500
>>
>> Eduard Wiebe <usenet@pusto.de> writes:
>>
>> > Eduard Wiebe <usenet@pusto.de> writes:
>> >
>> > Ping.
>>
>> Eli, are you happy with the patch introducing the backslash changes from
>>
>> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=7308#50
>>
>> ? It looks OK to me, but I am not sure I've correctly followed the
>> discussion in this bug report.
>
> I'm okay with the main change, but I don't understand the reason (or
> need) for this hunk:
>
> @@ -473,9 +483,9 @@ do not work in subdirectories.
> (make-local-variable 'directory-listing-before-filename-regexp)
> ;; This should support both Unix and Windoze style names
> (setq directory-listing-before-filename-regexp
> - (concat "^."
> + (concat "^.\\("
> (make-string (1- locate-filename-indentation) ?\s)
> - "\\(/\\|[A-Za-z]:\\)\\|"
^^^^^^^^^^^^^^^^^^^^
> + "\\)\\|"
> (default-value 'directory-listing-before-filename-regexp)))
> (make-local-variable 'dired-actual-switches)
> (setq dired-actual-switches "")
This hunk is essential. The new value of the regexp avoids the
truncation of the drive letter from absolute path of the selected file.
Btw. Under GNU/Linux this change leads to correct position of cursor in
*Locate* buffer, too.
PS: I tested my patch under GNU/Linux with GNU locate und MS-Windows
with everything-Tool for a while and it works fine.
--
Eduard Wiebe
next prev parent reply other threads:[~2010-11-13 22:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 19:50 bug#7308: [patch] locate under windoze Eduard Wiebe
2010-10-30 21:21 ` Eli Zaretskii
2010-10-31 9:36 ` Eduard Wiebe
2010-10-31 9:48 ` Thierry Volpiatto
2010-10-31 10:51 ` Eli Zaretskii
2010-10-31 19:54 ` Eduard Wiebe
2010-10-31 20:26 ` Eli Zaretskii
2010-10-31 6:56 ` Thierry Volpiatto
2010-10-31 7:49 ` Eli Zaretskii
2010-10-31 9:41 ` Thierry Volpiatto
2010-10-31 10:47 ` Eli Zaretskii
2010-10-31 11:13 ` Thierry Volpiatto
2010-11-01 6:54 ` Glenn Morris
2010-11-01 7:46 ` Eduard Wiebe
2010-11-01 14:06 ` Stefan Monnier
2010-11-01 14:59 ` Eduard Wiebe
2010-11-12 20:28 ` Eduard Wiebe
2010-11-13 18:57 ` Chong Yidong
2010-11-13 21:18 ` Eli Zaretskii
2010-11-13 22:33 ` Eduard Wiebe [this message]
2010-11-14 3:59 ` Eli Zaretskii
2010-11-14 9:15 ` Eduard Wiebe
2010-11-27 9:59 ` Eli Zaretskii
[not found] ` <87bp5970hs.fsf@pusto.de>
2010-11-28 19:46 ` bug#5462: " Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oc9sq2fv.fsf@pusto.de \
--to=usenet@pusto.de \
--cc=7308@debbugs.gnu.org \
--cc=cyd@stupidchicken.com \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).