From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Juri Linkov Newsgroups: gmane.emacs.bugs Subject: bug#7534: 24.0.50; G-g within Isearch regexp mode Date: Sun, 05 Dec 2010 23:11:57 +0000 Organization: JURTA Message-ID: <87oc8zhl1e.fsf@mail.jurta.org> References: <878w0724dn.fsf@mail.jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1291592749 27197 80.91.229.12 (5 Dec 2010 23:45:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 5 Dec 2010 23:45:49 +0000 (UTC) Cc: 7534@debbugs.gnu.org To: Dani Moncayo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Dec 06 00:45:44 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PPOH1-0003OK-Co for geb-bug-gnu-emacs@m.gmane.org; Mon, 06 Dec 2010 00:45:44 +0100 Original-Received: from localhost ([127.0.0.1]:56156 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPOH0-0003MU-RG for geb-bug-gnu-emacs@m.gmane.org; Sun, 05 Dec 2010 18:45:42 -0500 Original-Received: from [140.186.70.92] (port=58397 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PPOGj-0003Fu-N0 for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 18:45:26 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PPOGi-0002B4-IY for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 18:45:25 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38284) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PPOGi-0002Aw-FR for bug-gnu-emacs@gnu.org; Sun, 05 Dec 2010 18:45:24 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1PPNiV-0003xT-Ny; Sun, 05 Dec 2010 18:10:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Juri Linkov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 05 Dec 2010 23:10:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7534 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7534-submit@debbugs.gnu.org id=B7534.129159055715156 (code B ref 7534); Sun, 05 Dec 2010 23:10:03 +0000 Original-Received: (at 7534) by debbugs.gnu.org; 5 Dec 2010 23:09:17 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPNhk-0003wO-KI for submit@debbugs.gnu.org; Sun, 05 Dec 2010 18:09:16 -0500 Original-Received: from smarty.dreamhost.com ([208.113.175.8]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1PPNhi-0003w5-Hf for 7534@debbugs.gnu.org; Sun, 05 Dec 2010 18:09:14 -0500 Original-Received: from ps18281.dreamhostps.com (ps18281.dreamhost.com [69.163.218.105]) by smarty.dreamhost.com (Postfix) with ESMTP id 2CAB96E8052; Sun, 5 Dec 2010 15:15:05 -0800 (PST) Original-Received: from localhost (ps18281.dreamhostps.com [69.163.218.105]) by ps18281.dreamhostps.com (Postfix) with ESMTP id B8E2C451C09E; Sun, 5 Dec 2010 15:15:03 -0800 (PST) In-Reply-To: (Dani Moncayo's message of "Fri, 3 Dec 2010 08:57:23 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 05 Dec 2010 18:10:03 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42191 Archived-At: > So, IMO, the main principle for C-g (within Isearch mode) should be: > * if there is unmatched and/or incomplete input --> Delete it. > * Otherwise --> Exit Isearch mode. Please try the following patch. Does it provide the behavior you are asking for? === modified file 'lisp/isearch.el' --- lisp/isearch.el 2010-10-02 22:37:21 +0000 +++ lisp/isearch.el 2010-12-05 23:08:19 +0000 @@ -1253,7 +1253,7 @@ (defun isearch-abort () (interactive) ;; (ding) signal instead below, if quitting (discard-input) - (if isearch-success + (if (and isearch-success (not isearch-error)) ;; If search is successful, move back to starting point ;; and really do quit. (progn