From: "Štěpán Němec" <stepnem@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 9148@debbugs.gnu.org
Subject: bug#9148: Make `comment-normalize-vars' more syntax-aware
Date: Tue, 02 Aug 2011 12:35:03 +0200 [thread overview]
Message-ID: <87oc083xuw.fsf@gmail.com> (raw)
In-Reply-To: <jwv62mg8nsh.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Tue, 02 Aug 2011 00:04:03 -0400")
On Tue, 02 Aug 2011 06:04:03 +0200
Stefan Monnier wrote:
>> Unfortunately, even though there is a `comment-use-syntax' variable
>> which is apparently supposed to indicate that the comment functions
>> should rely on syntax information instead of `comment-prefix' and
>> friends, one piece is missing -- the function `comment-normalize-vars',
>> called at invocation of functions like {comment,uncomment}-region, still
>> requires `comment-start' to be set explicitly even though the syntax
>> information is sufficient and `comment-use-syntax' set.
>
> I'm not sure I understand the problem. Can you give a more concrete
> example where you get undesirable behavior?
> Setting comment-start is usually needed to tell Emacs *which* of the
> major mode's comment syntaxes to use (so it's only theoretically
> unneeded if the syntax-table only include a single comment syntax).
The point is that you can define a major mode with different syntax
tables in different parts of the text (using the syntax-table text
property), but instead of using that information to determine
comment-start and the other variables, `comment-normalize-vars' still
relies on `comment-start' being hard-coded (which doesn't really make
sense in a buffer with multiple comment syntaxes), even when
`comment-use-syntax' is set and the syntax-table information is
sufficient.
--
Štěpán
next prev parent reply other threads:[~2011-08-02 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-22 14:52 bug#9148: Make `comment-normalize-vars' more syntax-aware Štěpán Němec
2011-08-02 4:04 ` Stefan Monnier
2011-08-02 10:35 ` Štěpán Němec [this message]
2011-08-02 19:03 ` Stefan Monnier
2011-08-02 19:49 ` Štěpán Němec
2011-08-02 20:45 ` Stefan Monnier
2022-01-27 17:57 ` Lars Ingebrigtsen
2022-01-31 21:39 ` Štěpán Němec
2022-02-02 17:21 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oc083xuw.fsf@gmail.com \
--to=stepnem@gmail.com \
--cc=9148@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).