From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Chong Yidong Newsgroups: gmane.emacs.bugs Subject: bug#10195: 24.0.92; M-w may no longer provide visual feedback Date: Sun, 04 Dec 2011 23:59:15 +0800 Message-ID: <87obvopbu4.fsf@gnu.org> References: <20111202110953.0484349381.qww314159@jberkenbilt-linux.appiancorp.com> <83aa7bc597.fsf@gnu.org> <87d3c6xltz.fsf@maru.md5i.com> <8362hyces6.fsf@gnu.org> <878vmty979.fsf@maru.md5i.com> <83r50lbogk.fsf@gnu.org> <87wradxe6b.fsf@gnu.org> <83obvpaswm.fsf@gnu.org> <87y5ussqmv.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1323014389 5228 80.91.229.12 (4 Dec 2011 15:59:49 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 4 Dec 2011 15:59:49 +0000 (UTC) Cc: 10195@debbugs.gnu.org, ejb@ql.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 04 16:59:44 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RXETf-0004z4-D1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Dec 2011 16:59:43 +0100 Original-Received: from localhost ([::1]:44703 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXETe-0006lJ-Qv for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Dec 2011 10:59:42 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:55263) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXETa-0006l3-NB for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2011 10:59:40 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RXETY-0006sK-4s for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2011 10:59:38 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51696) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RXETY-0006sB-3O for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2011 10:59:36 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RXETy-0006wX-I9 for bug-gnu-emacs@gnu.org; Sun, 04 Dec 2011 11:00:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Chong Yidong Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Dec 2011 16:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10195 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10195-submit@debbugs.gnu.org id=B10195.132301439826658 (code B ref 10195); Sun, 04 Dec 2011 16:00:02 +0000 Original-Received: (at 10195) by debbugs.gnu.org; 4 Dec 2011 15:59:58 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXETt-0006vu-33 for submit@debbugs.gnu.org; Sun, 04 Dec 2011 10:59:58 -0500 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RXETq-0006vm-Fv for 10195@debbugs.gnu.org; Sun, 04 Dec 2011 10:59:55 -0500 Original-Received: from bb121-6-69-237.singnet.com.sg ([121.6.69.237]:40426 helo=furball) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1RXETN-0005rR-Al; Sun, 04 Dec 2011 10:59:26 -0500 In-Reply-To: (Eli Zaretskii's message of "Sun, 04 Dec 2011 06:25:49 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.92 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sun, 04 Dec 2011 11:00:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54686 Archived-At: Eli Zaretskii writes: >> It's an X selection request event. I'm not sure where the request is >> coming from---Gnome's clipboard manager, maybe. > > Looks like readable_events should filter out a few more event types, > when passed READABLE_EVENTS_FILTER_EVENTS in `flags'? I could think > of additional events that should not end sit-for, e.g. keyboard > language switch... selection requests shouldn't interrupt sit-for > regardless, since (AFAIR) they can come in out of Emacs's control. I don't think sit-for should ignore selection requests. If so, doing (sit-for 10) would cause Emacs to stop responding to selection requests from other applications for 10 seconds. That doesn't sound right. The workaround of putting the (redisplay t) in kill-ring-save works because Fredisplay calls swallow_events(), which has code in it to process selection request events. I think the right fix is for input-pending-p to call swallow_events(), as below. Thoughts? *** src/keyboard.c 2011-12-01 18:27:52 +0000 --- src/keyboard.c 2011-12-04 15:58:03 +0000 *************** *** 10522,10527 **** --- 10522,10528 ---- || !NILP (Vunread_input_method_events)) return (Qt); + swallow_events (0); get_input_pending (&input_pending, READABLE_EVENTS_DO_TIMERS_NOW | READABLE_EVENTS_FILTER_EVENTS);