From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kenichi Handa Newsgroups: gmane.emacs.bugs Subject: bug#11082: 24.0.94; u.glyphless member in struct glyph does not fit in 32 bits Date: Mon, 26 Mar 2012 14:47:16 +0900 Message-ID: <87obrjncbf.fsf@m17n.org> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1332740945 6790 80.91.229.3 (26 Mar 2012 05:49:05 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 26 Mar 2012 05:49:05 +0000 (UTC) Cc: 11082@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 26 07:49:04 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SC2nf-0008JE-3Q for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Mar 2012 07:49:03 +0200 Original-Received: from localhost ([::1]:50648 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC2ne-0004BO-8S for geb-bug-gnu-emacs@m.gmane.org; Mon, 26 Mar 2012 01:49:02 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:42959) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC2na-0004BB-Gr for bug-gnu-emacs@gnu.org; Mon, 26 Mar 2012 01:48:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SC2nY-0003dK-NN for bug-gnu-emacs@gnu.org; Mon, 26 Mar 2012 01:48:58 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:60402) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SC2nY-0003d6-KZ for bug-gnu-emacs@gnu.org; Mon, 26 Mar 2012 01:48:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SC3He-0002Bw-3M for bug-gnu-emacs@gnu.org; Mon, 26 Mar 2012 02:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kenichi Handa Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Mar 2012 06:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11082 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11082-submit@debbugs.gnu.org id=B11082.13327427678376 (code B ref 11082); Mon, 26 Mar 2012 06:20:02 +0000 Original-Received: (at 11082) by debbugs.gnu.org; 26 Mar 2012 06:19:27 +0000 Original-Received: from localhost ([127.0.0.1]:39001 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SC3H3-0002Az-2F for submit@debbugs.gnu.org; Mon, 26 Mar 2012 02:19:26 -0400 Original-Received: from mx1.aist.go.jp ([150.29.246.133]:41023) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SC3GU-00029w-Cx for 11082@debbugs.gnu.org; Mon, 26 Mar 2012 02:19:24 -0400 Original-Received: from rqsmtp1.aist.go.jp (rqsmtp1.aist.go.jp [150.29.254.115]) by mx1.aist.go.jp with ESMTP id q2Q5lepN018346; Mon, 26 Mar 2012 14:47:40 +0900 (JST) env-from (handa@m17n.org) Original-Received: from smtp3.aist.go.jp by rqsmtp1.aist.go.jp with ESMTP id q2Q5leO3018553; Mon, 26 Mar 2012 14:47:40 +0900 (JST) env-from (handa@m17n.org) Original-Received: by smtp3.aist.go.jp with ESMTP id q2Q5ldLG029927; Mon, 26 Mar 2012 14:47:39 +0900 (JST) env-from (handa@m17n.org) In-Reply-To: <83zkb6trdb.fsf@gnu.org> (message from Eli Zaretskii on Sat, 24 Mar 2012 09:01:04 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58154 Archived-At: In article <83zkb6trdb.fsf@gnu.org>, Eli Zaretskii writes: > > 447 /* Sub-stretch for type == GLYPHLESS_GLYPH. */ > > 448 struct > > 449 { > > 450 /* Value is an enum of the type glyphless_display_method. */ > > 451 unsigned method : 2; > > 452 /* 1 iff this glyph is for a character of no font. */ > > 453 unsigned for_no_font : 1; > > 454 /* Length of acronym or hexadecimal code string (at most 8). */ > > 455 unsigned len : 4; > > 456 /* Character to display. Actually we need only 22 bits. */ > > 457 unsigned ch : 26; > > 458 } glyphless; [...] > > According to the comment above, it seems to be OK to shorten the > > length of `u.glyphless.ch' member from 26 to 25. Could someone > > confirm this? > Confirmed. From the ELisp manual: [...] > I would actually suggest to use 22-bit for this field, to avoid > confusion in the future. I agree to change the bit length. I don't remeber well but I think the current bit length setting was just my mistake. In article , Stefan Monnier writes: > > dispextern.h (struct glyph): Change the bit length of glyphless.ch to 22 > > to make the member glyphless fit in 32 bits. > I think it's safer to reduce it to 25 bits, otherwise `val' field will > refer to undefined bits. Ok. I've just installed that change. --- Kenichi Handa handa@m17n.org