unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 12708@debbugs.gnu.org, Kevin Ryde <user42@zip.com.au>
Subject: bug#12708: 24.1; M-x display-time-world "q" close window
Date: Wed, 24 Oct 2012 10:44:44 +0300	[thread overview]
Message-ID: <87objs9uvn.fsf@mail.jurta.org> (raw)
In-Reply-To: <50863A2C.1010008@gmx.at> (martin rudalics's message of "Tue, 23 Oct 2012 08:33:16 +0200")

> We could do
>
> (defun quit-window-kill-buffer (&optional window)
>   "Quit WINDOW and kill its buffer.
> WINDOW must be a live window and defaults to the selected one."
>   (interactive)
>   (quit-restore-window window 'kill))
>
> (defvar display-time-world-mode-map
>   (let ((map (make-sparse-keymap)))
>     (define-key map "q" 'quit-window-kill-buffer)
>     map)
>   "Keymap of Display Time World mode.")

BTW, when I needed to do the same for the *Occur* buffer
(to kill it after going to the occurrence) I created a new command
`occur-mode-goto-occurrence-kill-buffer' based on
`occur-mode-goto-occurrence-other-window':

(defun occur-mode-goto-occurrence-kill-buffer ()
  "Go to the occurrence the current line describes, and kill the Occur buffer."
  (interactive)
  (let ((buf (current-buffer))
        (pos (occur-mode-find-occurrence)))
    (switch-to-buffer-other-window (marker-buffer pos))
    (goto-char pos)
    (kill-buffer buf)
    (run-hooks 'occur-mode-find-occurrence-hook)))

I still have no idea how to generalize this common behavior.

> But `display-time-world' should probably also use `display-buffer'
> instead of `pop-to-buffer' and put the buffer in `view-mode'.  After
> all, who wants to edit or navigate the *wclock* buffer?

In addition to this, it could also use the action
`display-buffer-below-selected' (like in dired),
and instead of `fit-window-to-buffer' it could use
'((window-height . fit-window-to-buffer)).





  reply	other threads:[~2012-10-24  7:44 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22 20:44 bug#12708: 24.1; M-x display-time-world "q" close window Kevin Ryde
2012-10-23  6:33 ` martin rudalics
2012-10-24  7:44   ` Juri Linkov [this message]
2012-10-27 11:04     ` martin rudalics
2012-10-27 11:45       ` Juri Linkov
2012-10-27 13:45         ` martin rudalics
2012-10-27 15:02           ` Juri Linkov
2012-10-28 15:23             ` martin rudalics
2012-10-28 17:41               ` Juri Linkov
2012-10-24 14:53   ` Chong Yidong
2012-10-24 16:25     ` Glenn Morris
2012-10-24 18:27       ` Chong Yidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87objs9uvn.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=12708@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    --cc=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).