From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jambunathan K Newsgroups: gmane.emacs.bugs Subject: bug#11131: 24.0.94; Apropos bookmarks Date: Sat, 27 Oct 2012 01:41:59 +0530 Message-ID: <87objphu28.fsf@gmail.com> References: <81sjgqqyt2.fsf@gmail.com> <87wr01htcz.fsf@gmail.com> <87sjao33j1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1351282258 23804 80.91.229.3 (26 Oct 2012 20:10:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 26 Oct 2012 20:10:58 +0000 (UTC) Cc: 11131@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Oct 26 22:11:05 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TRqFE-0001cO-Kh for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Oct 2012 22:11:04 +0200 Original-Received: from localhost ([::1]:50039 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRqF6-000529-9Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 26 Oct 2012 16:10:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:40701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRqF4-00051q-1U for bug-gnu-emacs@gnu.org; Fri, 26 Oct 2012 16:10:54 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TRqF2-0004x5-BS for bug-gnu-emacs@gnu.org; Fri, 26 Oct 2012 16:10:53 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53200) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TRqF1-0004wz-Sg for bug-gnu-emacs@gnu.org; Fri, 26 Oct 2012 16:10:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1TRqH8-0003kc-5v for bug-gnu-emacs@gnu.org; Fri, 26 Oct 2012 16:13:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jambunathan K Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Oct 2012 20:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11131 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11131-submit@debbugs.gnu.org id=B11131.135128233314364 (code B ref 11131); Fri, 26 Oct 2012 20:13:02 +0000 Original-Received: (at 11131) by debbugs.gnu.org; 26 Oct 2012 20:12:13 +0000 Original-Received: from localhost ([127.0.0.1]:35218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRqGK-0003jc-KA for submit@debbugs.gnu.org; Fri, 26 Oct 2012 16:12:13 -0400 Original-Received: from mail-da0-f44.google.com ([209.85.210.44]:37170) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1TRqGH-0003jQ-10 for 11131@debbugs.gnu.org; Fri, 26 Oct 2012 16:12:11 -0400 Original-Received: by mail-da0-f44.google.com with SMTP id h15so1395262dan.3 for <11131@debbugs.gnu.org>; Fri, 26 Oct 2012 13:09:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-type; bh=quGmiCS/UyjZC0XWrD9XCa3CN6oPaUmgRNEhug8wfTg=; b=ffXfcYVBuqhjDlZWnW8hXzoO46LkQqaURLlgN2+/bKTy3QF0ndK8pvZxgixqc6/diS 7KZbqZ8pW4tPQdGOCtIV6Yz0XpgufIazdnGFwguBZMjMKh04rgZjt237c/AaLLiZu/CE S5SZThh0LAfmwiqBo+WztLcpP/siKLCpk9i0GZSL1gBAnBE/clxPD1OeGvccM6ArDk+X Am9ryMYcqaLbhCdq+jA+AuLX8a+wmpIbliChgTnFg4l7nMWhX9+VaWtHhRPmGX5+zlZ/ 51+DsdDMrj5J0ADaFqdSqvqDcaocz31oeVhZMkZcUOQZ4GoRIAhqnpRoT1RDbuL3DqGA q4qw== Original-Received: by 10.66.80.133 with SMTP id r5mr65212754pax.24.1351282197441; Fri, 26 Oct 2012 13:09:57 -0700 (PDT) Original-Received: from debian-6.05 ([101.63.222.21]) by mx.google.com with ESMTPS id sg7sm1633648pbb.50.2012.10.26.13.09.54 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 26 Oct 2012 13:09:56 -0700 (PDT) In-Reply-To: (Stefan Monnier's message of "Fri, 26 Oct 2012 13:35:40 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:66092 Archived-At: --=-=-= Content-Type: text/plain Stefan Monnier writes: >> Since my bookmarks are function names, substring completion is what I >> desire. (Many functions share the *same* prefix) > > I haven't changed the default, but I have added a `category' of > `bookmark', so you can use substring completion simply by customizing > completion-category-overrides. Thanks for this patch. Good news: I can confirm that `substring' for `bookmark' category works. (custom-set-variables '(completion-category-overrides (quote ((buffer (styles basic substring)) (bookmark (styles substring)))))) Bad news: `icomplete-mode' never kicks in for `C-x r b' (even with default setting of `completion-category-overrides'). Once I reverse your changes icomplete-mode kicks in. $ bzr merge . -r 110680..110679 Something is surely amiss. Request: Following patch advertizes new category. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=bug11131.diff Content-Description: bug11131.diff === modified file 'lisp/ChangeLog' --- lisp/ChangeLog 2012-10-26 18:01:30 +0000 +++ lisp/ChangeLog 2012-10-26 20:02:27 +0000 @@ -1,3 +1,8 @@ +2012-10-26 Jambunathan K + + * minibuffer.el (completion-category-overrides): New completion + category `bookmark' (bug#11131). + 2012-10-26 Stefan Monnier * emacs-lisp/advice.el (ad-assemble-advised-definition): === modified file 'lisp/minibuffer.el' --- lisp/minibuffer.el 2012-10-25 12:56:13 +0000 +++ lisp/minibuffer.el 2012-10-26 19:58:22 +0000 @@ -743,6 +743,7 @@ (const buffer) (const file) (const unicode-name) + (const bookmark) symbol) :value-type (set :tag "Properties to override" --=-=-=--