* bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included)
@ 2013-10-02 17:12 Nicolas Petton
2013-10-04 10:36 ` Michael Albinus
0 siblings, 1 reply; 2+ messages in thread
From: Nicolas Petton @ 2013-10-02 17:12 UTC (permalink / raw)
To: 15516
In secrets.el, secrets-create-collection is broken (the DBus message
signature is wrong and the collection label is not the right one).
Here's a fixed version of the function:
(defun secrets-create-collection (collection)
"Create collection labeled COLLECTION if it doesn't exist.
Return the D-Bus object path for collection."
(let ((collection-path (secrets-collection-path collection)))
;; Create the collection.
(when (secrets-empty-path collection-path)
(setq collection-path
(secrets-prompt
(cadr
;; "CreateCollection" returns the prompt path as second arg.
(dbus-call-method
:session secrets-service secrets-path
secrets-interface-service "CreateCollection"
`(:array
(:dict-entry "org.freedesktop.Secret.Collection.Label" (:variant ,collection)))
"")))))
;; Return object path of the collection.
collection-path))
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included)
2013-10-02 17:12 bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included) Nicolas Petton
@ 2013-10-04 10:36 ` Michael Albinus
0 siblings, 0 replies; 2+ messages in thread
From: Michael Albinus @ 2013-10-04 10:36 UTC (permalink / raw)
To: Nicolas Petton; +Cc: 15516
Nicolas Petton <petton.nicolas@gmail.com> writes:
Hi Nicolas,
> In secrets.el, secrets-create-collection is broken (the DBus message
> signature is wrong and the collection label is not the right one).
Thanks for the report. I have applied a slightly different patch to the
Emacs repository. Please check
<http://bzr.savannah.gnu.org/lh/emacs/trunk/download/head:/secrets.el-20100313201810-6s62gy70hbdnhfs1-1/secrets.el>.
Best regards, Michael.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-10-04 10:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-02 17:12 bug#15516: 24.3; secrets.el `secrets-create-collection' is broken (fix included) Nicolas Petton
2013-10-04 10:36 ` Michael Albinus
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).