From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dima Kogan Newsgroups: gmane.emacs.bugs Subject: bug#16949: 24.3; [PATCH] insert-pair now leaves the point where the docstring says it should Date: Wed, 05 Mar 2014 23:17:01 -0800 Message-ID: <87ob1j4x02.fsf@secretsauce.net> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: ger.gmane.org 1394090826 23845 80.91.229.3 (6 Mar 2014 07:27:06 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 6 Mar 2014 07:27:06 +0000 (UTC) To: 16949@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 06 08:27:14 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WLSi1-00070c-CR for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Mar 2014 08:27:13 +0100 Original-Received: from localhost ([::1]:56056 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLSi1-000466-00 for geb-bug-gnu-emacs@m.gmane.org; Thu, 06 Mar 2014 02:27:13 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40019) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLShx-00045y-KF for bug-gnu-emacs@gnu.org; Thu, 06 Mar 2014 02:27:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLShr-000526-4F for bug-gnu-emacs@gnu.org; Thu, 06 Mar 2014 02:27:09 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:51116) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLShq-000522-U0 for bug-gnu-emacs@gnu.org; Thu, 06 Mar 2014 02:27:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WLShq-0007PP-Ay for bug-gnu-emacs@gnu.org; Thu, 06 Mar 2014 02:27:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Dima Kogan Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Mar 2014 07:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 16949 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.139409080028440 (code B ref -1); Thu, 06 Mar 2014 07:27:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 6 Mar 2014 07:26:40 +0000 Original-Received: from localhost ([127.0.0.1]:52298 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLShT-0007Od-Hq for submit@debbugs.gnu.org; Thu, 06 Mar 2014 02:26:40 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:37102) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WLSYW-00078i-GS for submit@debbugs.gnu.org; Thu, 06 Mar 2014 02:17:25 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLSYP-0002EY-M0 for submit@debbugs.gnu.org; Thu, 06 Mar 2014 02:17:24 -0500 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:56693) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLSYP-0002EU-Is for submit@debbugs.gnu.org; Thu, 06 Mar 2014 02:17:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38796) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLSYJ-0000mp-Oe for bug-gnu-emacs@gnu.org; Thu, 06 Mar 2014 02:17:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLSYE-0002Cs-1O for bug-gnu-emacs@gnu.org; Thu, 06 Mar 2014 02:17:11 -0500 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:46789) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLSYD-0002Cj-TE for bug-gnu-emacs@gnu.org; Thu, 06 Mar 2014 02:17:05 -0500 Original-Received: from compute4.internal (compute4.nyi.mail.srv.osa [10.202.2.44]) by gateway1.nyi.mail.srv.osa (Postfix) with ESMTP id 25E2620970 for ; Thu, 6 Mar 2014 02:17:04 -0500 (EST) Original-Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Thu, 06 Mar 2014 02:17:04 -0500 DKIM-Signature: v=1; a=rsa-sha1; c=relaxed/relaxed; d= messagingengine.com; h=from:to:subject:date:message-id :mime-version:content-type; s=smtpout; bh=h4ZClIPVadZ+tfaxorg3Iz SymOk=; b=CTNqLk31dmicQSJGa2hM5vKhK+QHhwwPYXWtv4YBAvhow36dUtWrJw XdlxKTUhrfa7zGJ71CqH76jtSrCu6nb6VEwZLML8hpNKRpuL46bTGlj2NmmFGmIE zSFBFPNMibir5gZ/5zAYDL5escpoLp+TRlxSNmf+bmlYBxM6TpW1k= X-Sasl-enc: 0alj7BVlaL1INlpXFE5hgWaApwUuK+ByZWvotOqOsqwu 1394090223 Original-Received: from shorty.local (unknown [23.243.199.75]) by mail.messagingengine.com (Postfix) with ESMTPA id E0C3C6800D4 for ; Thu, 6 Mar 2014 02:17:03 -0500 (EST) Original-Received: from dima by shorty.local with local (Exim 4.80) (envelope-from ) id 1WLSYA-0005kM-4d for bug-gnu-emacs@gnu.org; Wed, 05 Mar 2014 23:17:02 -0800 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Mailman-Approved-At: Thu, 06 Mar 2014 02:26:37 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:86599 Archived-At: --=-=-= Content-Type: text/plain The docstring of insert-pair states that after insertion, the point ends up after the opening character. This was not true if the pair was inserted to surround a region. This small patch fixes it. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-insert-pair-now-behaves-like-its-docstring-says.patch >From 5ae4b68706e4a1c8daa0bb91602a62911c29a9a8 Mon Sep 17 00:00:00 2001 From: Dima Kogan Date: Wed, 5 Mar 2014 23:10:57 -0800 Subject: [PATCH] insert-pair now behaves like its docstring says The docstring of insert-pair states that after insertion, the point ends up after the opening character. This was not true if the pair was inserted to surround a region --- lisp/emacs-lisp/lisp.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/emacs-lisp/lisp.el b/lisp/emacs-lisp/lisp.el index 0487515..420b205 100644 --- a/lisp/emacs-lisp/lisp.el +++ b/lisp/emacs-lisp/lisp.el @@ -536,7 +536,7 @@ This command assumes point is not in a string or comment." (if (and transient-mark-mode mark-active) (progn (save-excursion (goto-char (region-end)) (insert close)) - (save-excursion (goto-char (region-beginning)) (insert open))) + (goto-char (region-beginning)) (insert open)) (if arg (setq arg (prefix-numeric-value arg)) (setq arg 0)) (cond ((> arg 0) (skip-chars-forward " \t")) -- 1.9.0 --=-=-=--