From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Daimrod Newsgroups: gmane.emacs.bugs Subject: bug#17746: bug#17746: 24.4.50; "byte-code: `recenter'ing a window that does not display current-buffer." when composing a message Date: Sat, 14 Jun 2014 12:28:10 +0900 Message-ID: <87oaxw9nlh.fsf__3876.62337529964$1402716590$gmane$org@tanger.home> References: <837g4o1x3r.fsf@gnu.org> <87r42vlavi.fsf@geodiff-mac3.ulb.ac.be> <87ha3rxx79.fsf@bzg.ath.cx> <87ppifudvd.fsf@tanger.home> <878up24k6j.fsf@yahoo.fr> <878up2ec7z.fsf@tanger.home> <874mzqeaug.fsf__22767.2755755068$1402565401$gmane$org@tanger.home> <87lht2l9vo.fsf__32258.4286136136$1402567739$gmane$org@bzg.ath.cx> <87ioo56k5h.fsf@geodiff-mac3.ulb.ac.be> <8761k46d56.fsf@bzg.ath.cx> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1402716590 29816 80.91.229.3 (14 Jun 2014 03:29:50 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 14 Jun 2014 03:29:50 +0000 (UTC) Cc: Nicolas Richard , 17746@debbugs.gnu.org, David Griffiths To: Bastien Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 14 05:29:42 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wvef0-0005a3-9N for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Jun 2014 05:29:42 +0200 Original-Received: from localhost ([::1]:34044 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wveez-0007yc-S6 for geb-bug-gnu-emacs@m.gmane.org; Fri, 13 Jun 2014 23:29:41 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45104) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wveec-0007X6-6y for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 23:29:23 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WveeX-0008Qy-4c for bug-gnu-emacs@gnu.org; Fri, 13 Jun 2014 23:29:18 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55968) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WveeM-0008ML-Py; Fri, 13 Jun 2014 23:29:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WveeM-0002nM-Gj; Fri, 13 Jun 2014 23:29:02 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Daimrod Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org, emacs-orgmode@gnu.org Resent-Date: Sat, 14 Jun 2014 03:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17746 X-GNU-PR-Package: emacs,org-mode X-GNU-PR-Keywords: Original-Received: via spool by 17746-submit@debbugs.gnu.org id=B17746.140271650410677 (code B ref 17746); Sat, 14 Jun 2014 03:29:02 +0000 Original-Received: (at 17746) by debbugs.gnu.org; 14 Jun 2014 03:28:24 +0000 Original-Received: from localhost ([127.0.0.1]:47118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvedk-0002m9-AW for submit@debbugs.gnu.org; Fri, 13 Jun 2014 23:28:24 -0400 Original-Received: from mail-pa0-f42.google.com ([209.85.220.42]:36787) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wvedh-0002le-DW for 17746@debbugs.gnu.org; Fri, 13 Jun 2014 23:28:22 -0400 Original-Received: by mail-pa0-f42.google.com with SMTP id lj1so2762708pab.29 for <17746@debbugs.gnu.org>; Fri, 13 Jun 2014 20:28:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:references:date:message-id:user-agent :mime-version:content-type; bh=FRZgjacyx1Xfgfry+zCaITF0jAu9GvOjIecdTgcqDTU=; b=J8OB0rbQbcyfdLsSIXcjn/HDQOLe0rHK2AIZJbtYM8hSKhfXxfLRgBCm+RQxvESb3D Dj/RX5lo+IDGgvwaPp9e2ujV5Iqo9MJAZYNOE/W8M/FChnRhZT6D8c2fBWWMjQOt/D3L gGk0ickKrNczXsmcmZLgu7cRzXVQHYPajMuzFQcrwKtOR6JjrxVfAUdrLBoaerYCds4f kSC1O97ooVpGhdk61G+NnG0tXx0S9JN1VMfx76oNS4Hg4eaj05r6hZC85FZefZK61V5T pcSS0dr/IHYegA8K3Ee7jG4NmRfSAwmFMNGQgUrrb8NDqE0hoFiODfBGFyt9/mdD6l/+ Tkqg== X-Received: by 10.66.151.144 with SMTP id uq16mr8119426pab.68.1402716495071; Fri, 13 Jun 2014 20:28:15 -0700 (PDT) Original-Received: from localhost (i118-21-141-133.s30.a048.ap.plala.or.jp. [118.21.141.133]) by mx.google.com with ESMTPSA id lq6sm30279251pab.48.2014.06.13.20.28.12 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Jun 2014 20:28:14 -0700 (PDT) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:90365 Archived-At: Bastien writes: > Nicolas Richard writes: > >> Perhaps this isn't the right place to ask, but I wonder how >> (save-excursion (set-window-start (selected-window) (window-start))) >> isn't a noop. > > Perhaps it is a noop -- The purpose of `org-fix-ellipsis-at-bol' > is to remove the ellipsis overlay that outline-mode may leave > when navigating through folded regions. At least this was the > purpose of the original version, and using recenter did the > job. I'll try to reproduce the original bug, see if the new > version of `org-fix-ellipsis-at-bol' does the job and if not, > why. In `org-fix-ellipsis-at-bol', the change wasn't : (save-excursion (set-window-start (selected-window) (window-start))) but : (save-excursion (set-window-start (selected-window) (point-min))) which is not a noop. But it does the wrong thing with isearch. When isearch is done, that is, when it has found a match and we leave isearch with RET for example. Then it calls `isearch-done' which runs `org-fix-ellipsis-at-bol' because it is in `isearch-mode-end-hook' (I didn't look to find why). Because of this, if the pattern found isn't at the top of the buffer, then the point won't be at the pattern, but at the top of the buffer. Best, -- Daimrod/Greg