unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Juri Linkov <juri@jurta.org>
To: martin rudalics <rudalics@gmx.at>
Cc: Trevor Jim <tjim@mac.com>, 18181@debbugs.gnu.org
Subject: bug#18181: bug in display-buffer-below-selected
Date: Tue, 05 Aug 2014 02:58:04 +0300	[thread overview]
Message-ID: <87oavzre6z.fsf@mail.jurta.org> (raw)
In-Reply-To: <53DFC15D.3060607@gmx.at> (martin rudalics's message of "Mon, 04 Aug 2014 19:22:37 +0200")

>>       (let ((buffer (get-buffer-create "test-buffer")))
>>         (display-buffer-below-selected buffer nil)
>>         (display-buffer-below-selected buffer nil))
>
> This is the intended behavior.  `display-buffer-at-bottom' and
> `display-buffer--maybe-pop-up-frame-or-window' also display the buffer a
> second time even if it's already shown.  The correct use of this is to
> try `display-buffer-reuse-window' before `display-buffer-below-selected'.

I agree that `display-buffer-below-selected' should be prepended by
`display-buffer-reuse-window' in the list of display actions
when there is a need to reuse an already displayed window like

  (let ((buffer (get-buffer-create "test-buffer")))
    (display-buffer buffer `((display-buffer-reuse-window
                              display-buffer-below-selected)))
    (display-buffer buffer `((display-buffer-reuse-window
                              display-buffer-below-selected))))

>> This behavior seems to have been introduced in git commit
>>       6a5d9e9a3247566bf69575444e2a1f75f5b3e021
>> in the emacs-24 branch of git://git.savannah.gnu.org/emacs.git
>
> Can you please tell me which commit this was.  I don't have git.

It's bzr revno 115543 from our discussion at bug#16115
that removed the need to add `(split-height-threshold 0)'
to every use of `display-buffer-below-selected'.





  reply	other threads:[~2014-08-04 23:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-03 10:59 bug#18181: bug in display-buffer-below-selected Trevor Jim
2014-08-04 17:22 ` martin rudalics
2014-08-04 23:58   ` Juri Linkov [this message]
2014-08-04 17:53 ` Trevor Jim
2014-08-05  8:36   ` martin rudalics
2014-08-05 14:07 ` Trevor Jim
2014-08-09 17:04   ` martin rudalics
2014-08-09 23:49     ` Juri Linkov
2014-08-29 10:47     ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87oavzre6z.fsf@mail.jurta.org \
    --to=juri@jurta.org \
    --cc=18181@debbugs.gnu.org \
    --cc=rudalics@gmx.at \
    --cc=tjim@mac.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).