From: "Óscar Fuentes" <ofv@wanadoo.es>
To: 17945@debbugs.gnu.org
Subject: bug#17945: 24.4.50; vc-git-annotate-command is too slow
Date: Tue, 24 Feb 2015 16:31:45 +0100 [thread overview]
Message-ID: <87oaojuxzy.fsf@wanadoo.es> (raw)
In-Reply-To: <h97fv7pxl3.fsf@fencepost.gnu.org> (Glenn Morris's message of "Tue, 24 Feb 2015 02:39:36 -0500")
So what about this patch?
Modified lisp/vc/vc-git.el
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index a31c121..07ff083 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -120,6 +120,16 @@ (defcustom vc-git-diff-switches t
:version "23.1"
:group 'vc-git)
+(defcustom vc-git-annotate-switches t
+ "String or list of strings specifying switches for Git blame under VC.
+If nil, use the value of `vc-annotate-switches'. If t, use no switches."
+ :type '(choice (const :tag "Unspecified" nil)
+ (const :tag "None" t)
+ (string :tag "Argument String")
+ (repeat :tag "Argument List" :value ("") string))
+ :version "25.1"
+ :group 'vc-git)
+
(defcustom vc-git-program "git"
"Name of the Git executable (excluding any arguments)."
:version "24.1"
@@ -1013,7 +1023,9 @@ (defun vc-git-revision-completion-table (files)
(defun vc-git-annotate-command (file buf &optional rev)
(let ((name (file-relative-name file)))
- (vc-git-command buf 'async nil "blame" "--date=iso" "-C" "-C" rev "--" name)))
+ (apply #'vc-git-command buf 'async nil "blame" "--date=iso"
+ (append (vc-switches 'git 'annotate)
+ (list rev "--" name)))))
(declare-function vc-annotate-convert-time "vc-annotate" (time))
next prev parent reply other threads:[~2015-02-24 15:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-05 12:28 bug#17945: 24.4.50; vc-git-annotate-command is too slow William Xu
2014-07-05 13:34 ` Dmitry
2014-07-05 15:16 ` William Xu
2014-07-05 16:15 ` Stefan Monnier
2015-02-24 7:39 ` Glenn Morris
2015-02-24 15:31 ` Óscar Fuentes [this message]
2015-02-24 16:12 ` Eli Zaretskii
2015-02-24 16:36 ` Dmitry Gutov
2015-02-24 17:57 ` Glenn Morris
2015-02-24 20:55 ` Dmitry Gutov
2015-02-24 22:25 ` Óscar Fuentes
2015-02-25 17:46 ` Óscar Fuentes
2015-02-25 17:58 ` Dmitry Gutov
2015-02-25 18:06 ` Óscar Fuentes
2015-02-25 20:37 ` Dmitry Gutov
2015-02-26 14:56 ` Óscar Fuentes
2015-02-24 16:47 ` Dmitry Gutov
2015-02-24 17:56 ` Glenn Morris
2015-02-24 18:04 ` Dmitry Gutov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oaojuxzy.fsf@wanadoo.es \
--to=ofv@wanadoo.es \
--cc=17945@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).