From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#20193: 25.0.50; declarative type specification for D-Bus args Date: Thu, 03 Sep 2015 12:07:30 +0200 Message-ID: <87oahj95p9.fsf@gmx.de> References: <87bnjgat6z.fsf@gmx.de> <874mp628is.fsf@gmx.de> <87613wkhkm.fsf@gmx.de> <87d1y0apav.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1441274905 9501 80.91.229.3 (3 Sep 2015 10:08:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 3 Sep 2015 10:08:25 +0000 (UTC) Cc: 20193@debbugs.gnu.org To: Daiki Ueno Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Sep 03 12:08:13 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZXRRE-0003C1-3S for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Sep 2015 12:08:12 +0200 Original-Received: from localhost ([::1]:46493 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXRRD-0008OF-Op for geb-bug-gnu-emacs@m.gmane.org; Thu, 03 Sep 2015 06:08:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXRR8-0008Kz-55 for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 06:08:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZXRR4-0004CJ-RK for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 06:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55075) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZXRR4-0004C7-Oz for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 06:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1ZXRR4-0003Vd-4G for bug-gnu-emacs@gnu.org; Thu, 03 Sep 2015 06:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Sep 2015 10:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 20193 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 20193-submit@debbugs.gnu.org id=B20193.144127485613453 (code B ref 20193); Thu, 03 Sep 2015 10:08:02 +0000 Original-Received: (at 20193) by debbugs.gnu.org; 3 Sep 2015 10:07:36 +0000 Original-Received: from localhost ([127.0.0.1]:47285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZXRQe-0003Uv-3U for submit@debbugs.gnu.org; Thu, 03 Sep 2015 06:07:36 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:54993) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1ZXRQc-0003Un-Dq for 20193@debbugs.gnu.org; Thu, 03 Sep 2015 06:07:34 -0400 Original-Received: from detlef.gmx.de ([87.146.55.149]) by mail.gmx.com (mrgmx001) with ESMTPSA (Nemesis) id 0Lmb2Z-1YzCbf0cGB-00aG56; Thu, 03 Sep 2015 12:07:32 +0200 In-Reply-To: (Daiki Ueno's message of "Thu, 03 Sep 2015 18:29:40 +0900") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-Provags-ID: V03:K0:ddoKOCS96/PyxEnXMTI8mNhLzWh+Cmdok/n+IpraWVbHImEnei6 rWnnnZGrgPSxsmA7rQANUH3AEjFww+TEHxJ/bOT/UVhlfbAYLlrydSixXWLPgNbkNO+GD1p rscowTbwltZKcnoDMGK6rdUwUN/XgLvoVE5lFRrcte3h8AwY5uMQ0Wjqe6BkNs0s+y6RAeZ K8Tj0I5I7nNWBRqtjnTcQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:wuYi5PCZ/EU=:MlsT8hP7KyZsZfiXvodDKP jnvs50A5ahcRjEuVbOkYju7kXqLsXAQJx9nv8Ahm/pSvZkCKt3jnemuskKzIHkBrxPObV3pwU Ezqa6yhbOZKO8plVaT8dIQVRKXq9do0F1YByxRRP0Gh8diYpRcH4BfqfW2OTi7qT27L1ZcTXw QlzQ5krmiVbxlAi38ZAx4rD2YImf9dYdYBOWBSi7qKgta5YWAFWGKTrdwdtVvMnF4kly2XVGa vd8hOgOVyU9Tbhnv13xBcsQgytUiMIKhXUoyojqcQw3p9aHFsxqxGLsNYupwtU40rTuaLHIuN mMClmkRg4trduYRql506DFetoVXEosGZXudtYfDvhQcBfd8kYvkkmCN0WW9+vaJdB17sY//2t 9QZJnPenGDtMkM2THsQRxx8fB4sAdbt8B4hS1CLHqgo0Pxil0ojXN9w1eNpggGZ+L+THXd06c jNSI1QQOfOVm605M9EJ7GFLBKo9ndBrptt2sJHm095lhff0VAZJNF6XxmqLyhiNnZ1WfUMX90 lXTm4W2XbzqPzAMshTAwYsQllKHiJ41ux7csbEGVBwIt554c0d8NOcfJRI3942A/k1xGSY68Z hyfUkEw6kOjIKfduovw6hdonlmprDFzHIqD0+jrvutXh3QlxQwyeMzGkIrDlOxignrMBnH8Dk Btv0eyeiLWF5vjI1NaAgXHy4s2fNevGmJzqdefWa6O5ov/OUllOS9lm/EE/bGVD1NoTznaRrZ la8aUJGXOJwKgZS47X2eXyS62S+CQbSLMnmbrA== X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:106104 Archived-At: Daiki Ueno writes: >> For the second new test I'm not sure whether this is possible (the >> documentation doesn't speak about), but it looks natural to me. > > Yes, this was actually a bug because of missing checks on the number of > required arguments after `:type'. Fixed as: > http://git.savannah.gnu.org/cgit/emacs.git/commit/?h=scratch/dbusbind-type-tests&id=def5829c0769b142b3cc0d69a9ad58935a9f237f Well, dbus-test.el passes now, thanks. But there are still some cases I'm not so happy with: plist-get (dbus--test-create-message-with-args '(:array) '(:array :signature "u") :type '(:array :uint32) nil) :signature) |- "asauau" I would expect "asauaub" (plist-get (dbus--test-create-message-with-args '(:array) :type '(:array :uint32) '(:array :signature "u") '()) :signature) |- Debugger entered--Lisp error: (wrong-type-argument numberp :array) How to specify an empty array, if it isn't the last argument? Maybe like this: (plist-get (dbus--test-create-message-with-args '(:array) '(:array :signature "u") :type '(:array :uint32) nil nil) :signature) |- "asauaub" (plist-get (dbus--test-create-message-with-args '(:array) :type '(:array :uint32) nil '(:array :signature "u") nil) :signature) |- "asauaub" Maybe you could be a little bit more verbose about, and adapt the code? When there is a :type argument, there must *always* be two additional arguments? Or shall we allow the sloppy writing of one argument (the type spec), when it is the last in the call, and it is an empty list? This must be documented, then. As you see, even I (who has tried to understand the new syntax) am a little bit confused. > Regards, Best regards, Michael.