From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ben Gamari Newsgroups: gmane.emacs.bugs Subject: bug#21559: 25.0.50; auto-revert-mode breaks git rebase Date: Sat, 06 Feb 2016 13:34:06 +0100 Message-ID: <87oabu9fwh.fsf@smart-cactus.org> References: <87wpvebraz.fsf@smart-cactus.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha1; protocol="application/pgp-signature" X-Trace: ger.gmane.org 1454762131 2009 80.91.229.3 (6 Feb 2016 12:35:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 6 Feb 2016 12:35:31 +0000 (UTC) Cc: 21559@debbugs.gnu.org To: Mitchel Humpherys Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 06 13:35:20 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aS258-0007ML-F0 for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Feb 2016 13:35:18 +0100 Original-Received: from localhost ([::1]:53312 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aS254-0003V6-6I for geb-bug-gnu-emacs@m.gmane.org; Sat, 06 Feb 2016 07:35:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46549) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aS250-0003Rr-Cu for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 07:35:11 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aS24s-0002ql-RY for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 07:35:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54814) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aS24s-0002qh-LT for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 07:35:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aS24s-0008VW-GV for bug-gnu-emacs@gnu.org; Sat, 06 Feb 2016 07:35:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ben Gamari Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 06 Feb 2016 12:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21559 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 21559-submit@debbugs.gnu.org id=B21559.145476205832645 (code B ref 21559); Sat, 06 Feb 2016 12:35:02 +0000 Original-Received: (at 21559) by debbugs.gnu.org; 6 Feb 2016 12:34:18 +0000 Original-Received: from localhost ([127.0.0.1]:35170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aS24A-0008UT-E9 for submit@debbugs.gnu.org; Sat, 06 Feb 2016 07:34:18 -0500 Original-Received: from mail.smart-cactus.org ([54.187.36.80]:45615) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aS247-0008UG-Qn for 21559@debbugs.gnu.org; Sat, 06 Feb 2016 07:34:16 -0500 Original-Received: from localhost.localdomain (HSI-KBW-149-172-43-78.hsi13.kabel-badenwuerttemberg.de [149.172.43.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: ben@smart-cactus.org) by mail.smart-cactus.org (Postfix) with ESMTPSA id A747240449; Sat, 6 Feb 2016 12:20:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mail.smart-cactus.org; s=mail; t=1454761214; bh=B1BU0jqAHEoNnQPqp7wEhDW0840wriGeFTLHytcUjZc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=RD3iwL6xVBHh2YkjO24PEWN+sm6cqopeIUyQ27P9PahUXagjhMQ1tR3eWOD/KYZ/7 a7JpJOozcTAJE//Yd5rXmDWr289ubzI5ftNfrai1xntGRkt+q843yq3ck1c5GKjqGk DErlWwvDRh6Bn2HlYCtVtNCr5xKt/z1bxo+OnORs= In-Reply-To: User-Agent: Notmuch/0.21+24~gbceb651 (http://notmuchmail.org) Emacs/25.1.50.1 (x86_64-pc-linux-gnu) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:112562 Archived-At: --=-=-= Content-Type: text/plain Mitchel Humpherys writes: > On Fri, Sep 25 2015 at 03:45:56 PM, Ben Gamari wrote: >> Arguably `git rebase` should be holding the `index.lock` for the entire >> duration of the process (or be more resilient to the lock being taken) >> but sadly this isn't the case. Emacs should behave appropriately to >> accomodate this behavior. > > I don't think this is quite right. As I understand it, git only takes > index.lock for operations that mutate the index [1]. > > It wouldn't make sense for git to hold index.lock for the entirety of > the rebase operation since you can stop in the middle of an interactive > rebase and do anything you want (mess with the index, add new commits, > anything). > Ahh, yes. You are quite right. > I think the real question is: why is vc-find-file-hook (or > vc-refresh-state) trying to mutate the index? Shouldn't refreshing a > buffer be a read-only operation (at least with respect to the VCS)? > As far as I can tell vc-find-file-hook is merely calling `git ls-files -c -z -- $FILE`, which sounds to me like it should indeed be a read-only operation. Cheers, - Ben --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJWteg+AAoJEHPt6ejPuu8BwawIAIBB7Nn+z+hFNHm0YhXWhvZ2 TJfoOWSznJ/Z8oOyGT7VWvstpn3RLaSOjt/7r5GVyyGd7U6GdPCz/p4tokPqxrGC bfNEGLjc+mH4vi/XgR1wqqxV1HbI2RUW2dSRypCCl3nYyHrZEz19l73MSaX4GGcT W8ci6JeSHgvrZ0ycyPkUtbiEURoWrp9buEBJbTwTl7Ckt3VhtzWAnsKxJgXjU7hf aoF7+8UqnJ7JMYZMYVf6z6uLTejAe5MClJsOo5YcxWYmL7NEVe/xZHp/MDxxTfnH KDbBYQ8PqOwUcDe4skg/j5VAEqgmruMcD44Kp+2PXn/1iTCrAarteYC+iZnDNmM= =6e84 -----END PGP SIGNATURE----- --=-=-=--