From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#22729: 25.0.50; cl-union ignores :test when lists are equal Date: Tue, 23 Feb 2016 14:39:02 +1100 Message-ID: <87oab83xk9.fsf@gnus.org> References: <86oabf67qu.fsf@ulb.ac.be> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1456198825 25626 80.91.229.3 (23 Feb 2016 03:40:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 23 Feb 2016 03:40:25 +0000 (UTC) Cc: 22729@debbugs.gnu.org To: Nicolas Richard Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Feb 23 04:40:11 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aY3pb-0002I3-61 for geb-bug-gnu-emacs@m.gmane.org; Tue, 23 Feb 2016 04:40:11 +0100 Original-Received: from localhost ([::1]:53594 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY3pa-0002U0-Kv for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Feb 2016 22:40:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58079) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY3pW-0002SN-56 for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 22:40:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aY3pS-0000fJ-2n for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 22:40:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41611) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aY3pS-0000fF-0M for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 22:40:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84) (envelope-from ) id 1aY3pR-0004Aq-Od for bug-gnu-emacs@gnu.org; Mon, 22 Feb 2016 22:40:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 23 Feb 2016 03:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 22729 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 22729-submit@debbugs.gnu.org id=B22729.145619878116000 (code B ref 22729); Tue, 23 Feb 2016 03:40:01 +0000 Original-Received: (at 22729) by debbugs.gnu.org; 23 Feb 2016 03:39:41 +0000 Original-Received: from localhost ([127.0.0.1]:38735 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY3p7-0004A0-5W for submit@debbugs.gnu.org; Mon, 22 Feb 2016 22:39:41 -0500 Original-Received: from hermes.netfonds.no ([80.91.224.195]:60914) by debbugs.gnu.org with esmtp (Exim 4.84) (envelope-from ) id 1aY3p5-00049q-5i for 22729@debbugs.gnu.org; Mon, 22 Feb 2016 22:39:40 -0500 Original-Received: from cpe-60-225-211-161.nsw.bigpond.net.au ([60.225.211.161] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1aY3oa-0007C4-56; Tue, 23 Feb 2016 04:39:08 +0100 In-Reply-To: <86oabf67qu.fsf@ulb.ac.be> (Nicolas Richard's message of "Wed, 17 Feb 2016 09:50:17 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) X-MailScanner-ID: 1aY3oa-0007C4-56 MailScanner-NULL-Check: 1456803550.31167@6RVxcFDy8R++MM7ma65oBA X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:113511 Archived-At: Nicolas Richard writes: > * cl-seq.el (cl-union): Do not ignore :test argument when lists are equal. Thanks; applied. > * test/automated/cl-seq-tests.el: New file. The test fails: (ert-test-failed ((should (equal (cl-union ... ... :test ...) (list str1 str2))) :form (equal ("foo") ("foo" "foo")) :value nil :explanation (proper-lists-of-different-length 1 2 ("foo") ("foo" "foo") first-mismatch-at 1))) And that's because the two "foo" strings are eql here. Apparently the Emacs reader is being clever... I've fixed that by using non-literal strings and applied. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no