bug#22938: 24.5; Cannot rename files in directory with escaped spaces

bug#22938: 24.5; Cannot rename files in directory with escaped spaces

[Marty Rosenberg]

[-- Attachment #1: Type: text/plain, Size: 2857 bytes --]

most of this happens outside of emacs:
mkdir 'escape\ me'
cd 'escape\ me'
touch a
emacs -Q .
C-x C-q
rename the file from a to b
C-c C-c

when I inspect the error, it looks like it is attempting to rename
/home/mjrosenb/tmp/escapeme/a to /home/mjrosenb/tmp/escapeme/b
which fails, because the name of the directory is 'escape\ me', not
'escapeme'


In GNU Emacs 24.5.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.16.6)
 of 2015-09-09 on foutrelis
Configured using:
 `configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
 --localstatedir=/var --with-x-toolkit=gtk3 --with-xft
 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong
 --param=ssp-buffer-size=4' CPPFLAGS=-D_FORTIFY_SOURCE=2
 LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro'

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: Dired

Minor modes in effect:
  tooltip-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Press C-c C-c when finished or C-c ESC to abort changes
1 rename actions failed--type ? for details
C-c C-c is undefined

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr emacsbug message format-spec rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums
mm-util help-fns mail-prsvr mail-utils dired-aux wdired dired xterm
time-date tooltip electric uniquify ediff-hook vc-hooks lisp-float-type
mwheel x-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list newcomment lisp-mode prog-mode register page menu-bar
rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax
facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese
tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak
czech european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev minibuffer nadvice loaddefs button
faces cus-face macroexp files text-properties overlay sha1 md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process dbusbind gfilenotify dynamic-setting
system-font-setting font-render-setting move-toolbar gtk x-toolkit x
multi-tty emacs)

Memory information:
((conses 16 83726 8439)
 (symbols 48 18125 0)
 (miscs 40 36 149)
 (strings 32 10824 4459)
 (string-bytes 1 289384)
 (vectors 16 7637)
 (vector-slots 8 346167 28364)
 (floats 8 65 189)
 (intervals 56 214 3)
 (buffers 960 13)
 (heap 1024 10595 1622))

[-- Attachment #2: Type: text/html, Size: 3296 bytes --]

bug#22938: 24.5; Cannot rename files in directory with escaped spaces

[Marcin Borkowski]

On 2016-03-08, at 09:29, Marty Rosenberg <marty.rosenberg@gmail.com> wrote:

> most of this happens outside of emacs:
> mkdir 'escape\ me'
> cd 'escape\ me'
> touch a
> emacs -Q .
> C-x C-q
> rename the file from a to b
> C-c C-c
>
> when I inspect the error, it looks like it is attempting to rename
> /home/mjrosenb/tmp/escapeme/a to /home/mjrosenb/tmp/escapeme/b
> which fails, because the name of the directory is 'escape\ me', not
> 'escapeme'

Hi,

and thanks for the report.

However, it seems to work just fine on GNU Emacs 25.1.50.6 (commit
ac9a931).  It might have been fixed in the meantime.

Best,

-- 
Marcin Borkowski
http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
Faculty of Mathematics and Computer Science
Adam Mickiewicz University

bug#22938: 24.5; Cannot rename files in directory with escaped spaces

[Marty Rosenberg]

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

Strange, I just checked out git master, and reproduced it (I
used e0400b72a24). Did you both quote and escape the space? (alternately,
you can run mkdir escape\\\ me)  I've reproduced this on both an ubuntu
system, an arch-linux system, and a gentoo system.  I haven't tried on a
redhat based system, nor on OSX.

On Tue, Mar 8, 2016 at 3:52 AM, Marcin Borkowski <mbork@mbork.pl> wrote:

>
> On 2016-03-08, at 09:29, Marty Rosenberg <marty.rosenberg@gmail.com>
> wrote:
>
> > most of this happens outside of emacs:
> > mkdir 'escape\ me'
> > cd 'escape\ me'
> > touch a
> > emacs -Q .
> > C-x C-q
> > rename the file from a to b
> > C-c C-c
> >
> > when I inspect the error, it looks like it is attempting to rename
> > /home/mjrosenb/tmp/escapeme/a to /home/mjrosenb/tmp/escapeme/b
> > which fails, because the name of the directory is 'escape\ me', not
> > 'escapeme'
>
> Hi,
>
> and thanks for the report.
>
> However, it seems to work just fine on GNU Emacs 25.1.50.6 (commit
> ac9a931).  It might have been fixed in the meantime.
>
> Best,
>
> --
> Marcin Borkowski
> http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
> Faculty of Mathematics and Computer Science
> Adam Mickiewicz University
>

[-- Attachment #2: Type: text/html, Size: 1869 bytes --]

bug#22938: 24.5; Cannot rename files in directory with escaped spaces

[Marty Rosenberg]

[-- Attachment #1: Type: text/plain, Size: 1502 bytes --]

Addendum: I have discovered that there are multiple ways to rename a file
in dired.  I simply deleted the a, and replaced it with a b, while dired
was in Editable mode.

On Tue, Mar 8, 2016 at 1:45 PM, Marty Rosenberg <marty.rosenberg@gmail.com>
wrote:

> Strange, I just checked out git master, and reproduced it (I
> used e0400b72a24). Did you both quote and escape the space? (alternately,
> you can run mkdir escape\\\ me)  I've reproduced this on both an ubuntu
> system, an arch-linux system, and a gentoo system.  I haven't tried on a
> redhat based system, nor on OSX.
>
> On Tue, Mar 8, 2016 at 3:52 AM, Marcin Borkowski <mbork@mbork.pl> wrote:
>
>>
>> On 2016-03-08, at 09:29, Marty Rosenberg <marty.rosenberg@gmail.com>
>> wrote:
>>
>> > most of this happens outside of emacs:
>> > mkdir 'escape\ me'
>> > cd 'escape\ me'
>> > touch a
>> > emacs -Q .
>> > C-x C-q
>> > rename the file from a to b
>> > C-c C-c
>> >
>> > when I inspect the error, it looks like it is attempting to rename
>> > /home/mjrosenb/tmp/escapeme/a to /home/mjrosenb/tmp/escapeme/b
>> > which fails, because the name of the directory is 'escape\ me', not
>> > 'escapeme'
>>
>> Hi,
>>
>> and thanks for the report.
>>
>> However, it seems to work just fine on GNU Emacs 25.1.50.6 (commit
>> ac9a931).  It might have been fixed in the meantime.
>>
>> Best,
>>
>> --
>> Marcin Borkowski
>> http://octd.wmi.amu.edu.pl/en/Marcin_Borkowski
>> Faculty of Mathematics and Computer Science
>> Adam Mickiewicz University
>>
>
>

[-- Attachment #2: Type: text/html, Size: 2473 bytes --]

bug#22938: 24.5; Cannot rename files in directory with escaped spaces

[Eli Zaretskii]

> Date: Tue, 8 Mar 2016 13:45:07 -0500
> From: Marty Rosenberg <marty.rosenberg@gmail.com>
> Cc: 22938@debbugs.gnu.org
> 
> Strange, I just checked out git master, and reproduced it (I used e0400b72a24). Did you both quote and
> escape the space? (alternately, you can run mkdir escape\\\ me) I've reproduced this on both an ubuntu
> system, an arch-linux system, and a gentoo system. I haven't tried on a redhat based system, nor on OSX.

You are right, I see it too.

AFAICS, the problem is in wdired-normalize-filename: it removes the
backslash and the following blank from the name, thus creating a name
of a file that doesn't exist.

bug#22938: 24.5; Cannot rename files in directory with escaped spaces

[Andreas Schwab]

Eli Zaretskii <eliz@gnu.org> writes:

> AFAICS, the problem is in wdired-normalize-filename: it removes the
> backslash and the following blank from the name, thus creating a name
> of a file that doesn't exist.

Should be fixed in commit 02bf7cc.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#22938: 24.5; Cannot rename files in directory with escaped spaces

[Eli Zaretskii]

> From: Andreas Schwab <schwab@linux-m68k.org>
> Cc: Marty Rosenberg <marty.rosenberg@gmail.com>,  22938-done@debbugs.gnu.org,  mbork@mbork.pl
> Date: Tue, 08 Mar 2016 21:48:31 +0100
> 
> Eli Zaretskii <eliz@gnu.org> writes:
> 
> > AFAICS, the problem is in wdired-normalize-filename: it removes the
> > backslash and the following blank from the name, thus creating a name
> > of a file that doesn't exist.
> 
> Should be fixed in commit 02bf7cc.

Thanks!