From: phillip.lord@russet.org.uk (Phillip Lord)
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: 23769@debbugs.gnu.org, Dmitry Gutov <dgutov@yandex.ru>
Subject: bug#23769: 25.0.95; Mode Line breakage in vc-git
Date: Thu, 16 Jun 2016 22:47:42 +0100 [thread overview]
Message-ID: <87oa70lsap.fsf@russet.org.uk> (raw)
In-Reply-To: <CAM-tV-_Jo0m_sP_e9wvCUOKMMHD0g6Zs1bYOOTuBSGeEk7kjwA@mail.gmail.com> (Noam Postavsky's message of "Thu, 16 Jun 2016 12:54:54 -0400")
Noam Postavsky <npostavs@users.sourceforge.net> writes:
> On Thu, Jun 16, 2016 at 12:06 PM, Dmitry Gutov <dgutov@yandex.ru> wrote:
>> Actually, this is better. The previous one broke vc-git. :)
>>
>> diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
>> index f35c84d..2b827a3 100644
>> --- a/lisp/vc/vc-git.el
>> +++ b/lisp/vc/vc-git.el
>> @@ -1451,6 +1451,7 @@ vc-git--call
>> (coding-system-for-write
>> (or coding-system-for-write vc-git-commits-coding-system))
>> (process-environment (cons "PAGER=" process-environment)))
>> + (setenv "GIT_DIR" nil)
>>
>
> I think you want (cons "GIT_DIR" ...) [without "="], using setenv can
> modify the process-environment list by side-effect.
Confused. Can you right a full patch?
Phil
next prev parent reply other threads:[~2016-06-16 21:47 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-14 11:16 bug#23769: 25.0.95; Mode Line breakage in vc-git Phillip Lord
2016-06-14 16:29 ` Glenn Morris
2016-06-14 17:03 ` Phillip Lord
2016-06-14 21:52 ` Dmitry Gutov
2016-06-14 22:21 ` Phillip Lord
2016-06-15 20:48 ` Phillip Lord
2016-06-15 21:02 ` Dmitry Gutov
2016-06-15 22:09 ` Phillip Lord
2016-06-15 22:27 ` Noam Postavsky
2016-06-15 23:20 ` Dmitry Gutov
2016-06-16 7:11 ` Phillip Lord
2016-06-16 7:45 ` Phillip Lord
2016-06-15 23:25 ` Dmitry Gutov
2016-06-16 7:41 ` Phillip Lord
2016-06-16 11:25 ` Dmitry Gutov
2016-06-16 16:06 ` Dmitry Gutov
2016-06-16 16:54 ` Noam Postavsky
2016-06-16 16:59 ` Dmitry Gutov
2016-06-16 21:47 ` Phillip Lord [this message]
2016-06-16 22:13 ` Dmitry Gutov
2016-06-16 22:23 ` Phillip Lord
2016-06-16 22:31 ` Dmitry Gutov
2016-06-16 22:42 ` Phillip Lord
2016-06-17 2:41 ` Dmitry Gutov
2016-06-17 3:37 ` Noam Postavsky
2016-06-17 6:54 ` Eli Zaretskii
2016-06-17 12:06 ` Dmitry Gutov
2016-06-17 13:21 ` Eli Zaretskii
2016-06-17 13:54 ` Dmitry Gutov
2016-06-17 15:09 ` Phillip Lord
2016-06-16 21:47 ` Phillip Lord
2016-06-16 22:04 ` Dmitry Gutov
2016-06-21 16:46 ` Dmitry Gutov
2016-06-21 20:45 ` Phillip Lord
2016-06-21 23:06 ` Dmitry Gutov
2016-06-15 21:56 ` John Wiegley
2016-06-14 21:30 ` Phillip Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87oa70lsap.fsf@russet.org.uk \
--to=phillip.lord@russet.org.uk \
--cc=23769@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
--cc=npostavs@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).