From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#19547: Patch for this bug Date: Sun, 27 Nov 2016 20:03:10 +0100 Message-ID: <87oa10wxsh.fsf@gmail.com> References: <874ms03qj1.fsf@web.de> <8360nxhfiw.fsf@gnu.org> <83k2ccfnh8.fsf@gnu.org> <83wpgbdy82.fsf@gnu.org> <87y4071o5k.fsf@gmail.com> <83h96u3d07.fsf@gnu.org> <87zikl8leb.fsf@gmail.com> <871sxxj9s8.fsf@users.sourceforge.net> <87twat6kjd.fsf@gmail.com> <834m2s2a0d.fsf@gnu.org> <87r35wx0qe.fsf@gmail.com> <83twaszrzk.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1480273452 3196 195.159.176.226 (27 Nov 2016 19:04:12 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 27 Nov 2016 19:04:12 +0000 (UTC) User-Agent: mu4e 0.9.17; emacs 24.5.1 Cc: npostavs@users.sourceforge.net, 19547@debbugs.gnu.org, rrt@sc3d.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Nov 27 20:04:08 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4kB-0000OC-N1 for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Nov 2016 20:04:07 +0100 Original-Received: from localhost ([::1]:55255 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB4kF-0001b2-IC for geb-bug-gnu-emacs@m.gmane.org; Sun, 27 Nov 2016 14:04:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cB4k9-0001am-Fm for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2016 14:04:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cB4k6-0002kn-Bn for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2016 14:04:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56667) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cB4k6-0002kR-7E for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2016 14:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cB4k5-0007XU-Qn for bug-gnu-emacs@gnu.org; Sun, 27 Nov 2016 14:04:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 27 Nov 2016 19:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19547 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 19547-submit@debbugs.gnu.org id=B19547.148027340228930 (code B ref 19547); Sun, 27 Nov 2016 19:04:01 +0000 Original-Received: (at 19547) by debbugs.gnu.org; 27 Nov 2016 19:03:22 +0000 Original-Received: from localhost ([127.0.0.1]:43833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4jS-0007WX-6G for submit@debbugs.gnu.org; Sun, 27 Nov 2016 14:03:22 -0500 Original-Received: from mail-wm0-f43.google.com ([74.125.82.43]:36748) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cB4jQ-0007WK-FQ for 19547@debbugs.gnu.org; Sun, 27 Nov 2016 14:03:20 -0500 Original-Received: by mail-wm0-f43.google.com with SMTP id g23so186911311wme.1 for <19547@debbugs.gnu.org>; Sun, 27 Nov 2016 11:03:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=references:user-agent:from:to:cc:subject:in-reply-to:date :message-id:mime-version:content-transfer-encoding; bh=B7eUKuArVkQ0bQtiz/M7Qe5KqXTn4q7G6l2QvVpKw8A=; b=lAuVgns+FL0FGvdyZGfkFL1pa8JMFAcjaACJgr0VBas9s1pu1Fpf2aQMszjnVQ7Njy 2chHifSUZ092PhsJpbo5WSU5fqKSHaszJIubo1WhR7qV2K+fZBRRYAhxzRn1vNw5520V 1L/isvUUObHxu+AdQe76OoQUY+jkD5yO0QZUcS9BvGDDHGyUudX1EH6sHrXSzO2cvSgS qeAHxVWhvgJWGj8hhxmsjaoSDBaE0z7ADf2fEGNmERwSeLWT96laXPHJzuZbniJI7mBu J/2HDlprWINQ3CEm4aUHMP6udZ/HATaiU8U6lcOHvgUMTxW3+kEmR63S1XEAzeXQGZfB 7WVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:references:user-agent:from:to:cc:subject :in-reply-to:date:message-id:mime-version:content-transfer-encoding; bh=B7eUKuArVkQ0bQtiz/M7Qe5KqXTn4q7G6l2QvVpKw8A=; b=mfFiGLKiXg9cEOWuDtMQjyXbI/BNIqXhBqVS709lvyVjVrcnXn4gpte/I68VN7S3sN mz88dPqO/WT8O63t9ewF1ipUJ2QY31iM4zn/GzW2U6dHbt3+JyJaDdkEQqIT7pcV3DTN /z72frdDKzl23FEMM6pWW/phcJCbQrmeyE0CyvyfXgm4dUj7Yx50jocGhkuWD4nVGpe6 cgLo7iPgD0e+6JStxhDU3A0TbtoooT3J08hxdUuGrcYD8sIIiS/bhAtznqxlzlqww5b1 f4eX5/0CU3t3bHzgjBPblHcYhsgJFDeKw/UaDBUbk/d44uzfmlFvwngQB4Z7c4HCDKP0 GLWA== X-Gm-Message-State: AKaTC02JUzUvnlKHhqTxtaLJwY+vTtvczoGCa+dotQ9R2Fu6xv4j3w10mQkDcPWtD8PDXA== X-Received: by 10.28.73.135 with SMTP id w129mr15116483wma.42.1480273394740; Sun, 27 Nov 2016 11:03:14 -0800 (PST) Original-Received: from dell-14z ([37.167.8.218]) by smtp.gmail.com with ESMTPSA id d8sm24847441wmi.21.2016.11.27.11.03.12 (version=TLS1_2 cipher=AES128-SHA bits=128/128); Sun, 27 Nov 2016 11:03:13 -0800 (PST) In-reply-to: <83twaszrzk.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:126182 Archived-At: Eli Zaretskii writes: > My advice is to look at how a function is used elsewhere in the > sources, before using it in your code. In this case, you will find > stuff like this: > > arg = Flist (nargs - i, &arg_vector[i]); > > IOW, the first argument to Flist is the number of arguments, and the > second argument is an array of that dimension. Ok, I understand now why there is also a warning about 2 args or something like this, great, thanks for explanations. > Why not? You will see quite a few examples of such stuff there. Ok no problem, 2 last questions: - What about like suggested by Noam to put this just above the definition of while-no-input in subr.el ? - IIRC you didn't want to add by default selection-request aka SELECTION_REQUEST_EVENT, is this always true ? >> keyboard.c: In function ‘kbd_buffer_store_buffered_event’: >> keyboard.c:3572:3: warning: enumeration value ‘NO_EVENT’ not handled in switch [-Wswitch] >> switch (event->kind) >> ^ >> keyboard.c:3572:3: warning: enumeration value ‘ASCII_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] >> keyboard.c:3572:3: warning: enumeration value ‘MULTIBYTE_CHAR_KEYSTROKE_EVENT’ not handled in switch [-Wswitch] > > That's because you don't have a "case default". You should, as I > explained earlier. Ok so this should be fixed now. Thanks. -- Thierry