unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Thierry Volpiatto <thierry.volpiatto@gmail.com>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 25482@debbugs.gnu.org
Subject: bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil
Date: Sun, 22 Jan 2017 21:14:03 +0100	[thread overview]
Message-ID: <87o9yy26pg.fsf@gmail.com> (raw)
In-Reply-To: <83lgu252zc.fsf@gnu.org>


Eli Zaretskii <eliz@gnu.org> writes:

> I'm afraid we are mis-communicating.

Yes.

> The current code uses a null character as the separator, giving it a
> display property and a separator property.  The display property uses
> a non-ASCII character (→).  What I wanted to suggest is to keep the
> same code, and just allow users to specify the ASCII string " -> " for
> the display property.

No change is needed for this, it's what the current code does.

> That should be much simpler than your proposed patch,

What would be much more simple would be to not use at all properties,
the actual implementation is too complex for something quite simple.

I will not have much time to continue on this, I will look into this
maybe later, if you think this change is not important, just close the bug for
now (if you need the last patch I wrote which works fine, let me know).

Thanks.

-- 
Thierry





  reply	other threads:[~2017-01-22 20:14 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-19  8:18 bug#25482: 26.0.50; Allow setting `query-replace-from-to-separator` to nil Thierry Volpiatto
2017-01-19 16:01 ` Eli Zaretskii
2017-01-20  5:54   ` Thierry Volpiatto
     [not found]   ` <87vatac0a2.fsf@gmail.com>
2017-01-20  5:42     ` bug#25482: Fwd: " Thierry Volpiatto
2017-01-20  7:56     ` Eli Zaretskii
2017-01-20 11:35       ` Thierry Volpiatto
2017-01-20 13:06         ` Eli Zaretskii
2017-01-20 15:16           ` Thierry Volpiatto
2017-01-22 19:06             ` Eli Zaretskii
2017-01-22 20:14               ` Thierry Volpiatto [this message]
2017-01-22 20:32                 ` Eli Zaretskii
2017-01-23  8:13                   ` Thierry Volpiatto
2017-01-28  6:50                     ` Thierry Volpiatto
2017-01-28  7:31                       ` Eli Zaretskii
2017-01-28 10:43                         ` Thierry Volpiatto
2017-01-28 11:01                           ` Eli Zaretskii
2017-01-28 11:23                             ` Thierry Volpiatto
2017-01-28 13:50                               ` Eli Zaretskii
2017-01-28 16:46                                 ` Thierry Volpiatto
     [not found]                                   ` <87k29ey93n.fsf@mail.linkov.net>
2017-01-29  3:42                                     ` Eli Zaretskii
2017-01-30  0:16                                       ` Juri Linkov
2017-02-13  0:37                                   ` Juri Linkov
2017-02-13  2:24                                     ` Glenn Morris
2017-02-13  3:04                                       ` Glenn Morris
2017-02-13  5:51                                     ` Eli Zaretskii
2017-02-14  0:04                                       ` Juri Linkov
2017-02-14  0:24                                         ` Drew Adams
2017-02-18 10:45                                           ` Eli Zaretskii
2017-02-13  5:53                                     ` Thierry Volpiatto
2017-02-16 20:43                                       ` Juri Linkov
2017-01-21 10:05           ` Thierry Volpiatto
2017-01-21 10:24             ` Thierry Volpiatto

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o9yy26pg.fsf@gmail.com \
    --to=thierry.volpiatto@gmail.com \
    --cc=25482@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).